You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-03-30] Android - Expense - Button icons are hard to see when PDF receipt is added offline #84367
Version Number: 9.3.32-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#83994 Email or phone of affected tester (no customers):sjodijsoijosjoidsji@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Samsung Galaxy S25 FE / Android 16 App Component: Money Requests
Action Performed:
Precondition:
App is in dark mode.
Launch Expensify app.
Go to workspace chat.
Create an expense without receipt.
Open the expense.
Go offline.
Tap receipt modal.
Add a PDF receipt.
Expected Result:
Button icons on the receipt will be easy to see.
Actual Result:
Button icons are hard to see when PDF receipt is added offline.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #83994 - "feat: allow multiple receipts to be attached to a single expense" by @TaduJR (High confidence) Related Issues: N/A
Recommendation: REVERT
PR #83994 introduced new button overlays on receipt images (enlarge and add attachment buttons). On mobile/touch devices, these buttons are always visible. When a PDF receipt is added offline on Android, the buttons lack sufficient visual contrast against the PDF background, making them hard to see. Since this is a new feature that does not exist in production, reverting is the safest approach to unblock the deploy while the styling can be improved.
Labels: Removed DeployBlocker label (backend is not affected). Kept DeployBlockerCash label (App deploy remains blocked).
📋 Detailed Analysis
Evidence
The issue explicitly states this is a "new feature, does not exist in prod"
This styling logic means on Android (touch device), buttons are always visible with no opacity change. The primaryMediumIcon styling provides a background, but it appears insufficient for contrast against PDF content.
Root Cause
The button overlay styling lacks adequate visual contrast when displayed over PDF receipt content on mobile devices. The buttons use theme.buttonDefaultBG for background and theme.icon for fill color, but this combination is not providing enough differentiation from PDF backgrounds, especially in offline scenarios where the rendering might differ.
The code path:
User adds PDF receipt offline on Android
canShowReceiptActions evaluates to true (receipt exists, is editable, not scanning)
Buttons render with isTouchScreen = true
Opacity remains at 1 (buttons always visible)
Visual contrast is insufficient against PDF background
📣 @AbdulSalaamazimi! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
Activity
melvin-bot commentedon Mar 6, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #83994
melvin-bot commentedon Mar 6, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Mar 6, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Mar 6, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #83994 - "feat: allow multiple receipts to be attached to a single expense" by @TaduJR (High confidence)
Related Issues: N/A
Recommendation: REVERT
PR #83994 introduced new button overlays on receipt images (enlarge and add attachment buttons). On mobile/touch devices, these buttons are always visible. When a PDF receipt is added offline on Android, the buttons lack sufficient visual contrast against the PDF background, making them hard to see. Since this is a new feature that does not exist in production, reverting is the safest approach to unblock the deploy while the styling can be improved.
Labels: Removed
DeployBlockerlabel (backend is not affected). KeptDeployBlockerCashlabel (App deploy remains blocked).📋 Detailed Analysis
Evidence
Verification
Affected file:
src/components/ReportActionItem/MoneyRequestReceiptView.tsxPR #83994 modified this exact file, adding:
isTouchScreen)The relevant code from the PR:
This styling logic means on Android (touch device), buttons are always visible with no opacity change. The
primaryMediumIconstyling provides a background, but it appears insufficient for contrast against PDF content.Root Cause
The button overlay styling lacks adequate visual contrast when displayed over PDF receipt content on mobile devices. The buttons use
theme.buttonDefaultBGfor background andtheme.iconfor fill color, but this combination is not providing enough differentiation from PDF backgrounds, especially in offline scenarios where the rendering might differ.The code path:
canShowReceiptActionsevaluates to true (receipt exists, is editable, not scanning)isTouchScreen = truemelvin-bot commentedon Mar 6, 2026
📣 @AbdulSalaamazimi! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
30 remaining items
melvin-bot commentedon Mar 23, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)ahmedGaber93 commentedon Mar 24, 2026
Follow-up PR — no payment required.
melvin-bot commentedon Mar 30, 2026
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
ahmedGaber93 commentedon Mar 30, 2026
#84367 (comment)
melvin-bot commentedon Mar 30, 2026
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Mar 31, 2026
Closing, no payment due and a comment about the regression is on the parent issue