Skip to content

[Due for payment 2026-03-30] Android - Expense - Button icons are hard to see when PDF receipt is added offline #84367

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.32-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #83994
Email or phone of affected tester (no customers): sjodijsoijosjoidsji@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Samsung Galaxy S25 FE / Android 16
App Component: Money Requests

Action Performed:

Precondition:

  • App is in dark mode.
  1. Launch Expensify app.
  2. Go to workspace chat.
  3. Create an expense without receipt.
  4. Open the expense.
  5. Go offline.
  6. Tap receipt modal.
  7. Add a PDF receipt.

Expected Result:

Button icons on the receipt will be easy to see.

Actual Result:

Button icons are hard to see when PDF receipt is added offline.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Image

Bug7095287_1772776650289!E_receipt_PDF.pdf

Bug7095287_1772776472569.az_recorder_20260306_134810_1_1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Mar 6, 2026
  2. melvin-bot commented on Mar 6, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #83994

  3. melvin-bot commented on Mar 6, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on Mar 6, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. OSBotify commented on Mar 6, 2026

    @OSBotify
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: #83994 - "feat: allow multiple receipts to be attached to a single expense" by @TaduJR (High confidence)
    Related Issues: N/A

    Recommendation: REVERT

    PR #83994 introduced new button overlays on receipt images (enlarge and add attachment buttons). On mobile/touch devices, these buttons are always visible. When a PDF receipt is added offline on Android, the buttons lack sufficient visual contrast against the PDF background, making them hard to see. Since this is a new feature that does not exist in production, reverting is the safest approach to unblock the deploy while the styling can be improved.

    Labels: Removed DeployBlocker label (backend is not affected). Kept DeployBlockerCash label (App deploy remains blocked).

    📋 Detailed Analysis

    Evidence

    Verification

    Affected file: src/components/ReportActionItem/MoneyRequestReceiptView.tsx

    PR #83994 modified this exact file, adding:

    1. Two overlay buttons (enlarge and add attachment) positioned absolutely at top-right of receipt images
    2. Hover behavior for web (buttons hidden until hover)
    3. Always-visible behavior for touch devices (isTouchScreen)

    The relevant code from the PR:

    <View style={[styles.receiptActionButtonsContainer, styles.pointerEventsBoxNone, !hovered && !isTouchScreen && styles.opacity0]}>

    This styling logic means on Android (touch device), buttons are always visible with no opacity change. The primaryMediumIcon styling provides a background, but it appears insufficient for contrast against PDF content.

    Root Cause

    The button overlay styling lacks adequate visual contrast when displayed over PDF receipt content on mobile devices. The buttons use theme.buttonDefaultBG for background and theme.icon for fill color, but this combination is not providing enough differentiation from PDF backgrounds, especially in offline scenarios where the rendering might differ.

    The code path:

    1. User adds PDF receipt offline on Android
    2. canShowReceiptActions evaluates to true (receipt exists, is editable, not scanning)
    3. Buttons render with isTouchScreen = true
    4. Opacity remains at 1 (buttons always visible)
    5. Visual contrast is insufficient against PDF background
  6. removed
    DeployBlockerIndicates it should block deploying the API
    on Mar 6, 2026
  7. melvin-bot commented on Mar 6, 2026

    @melvin-bot

    📣 @AbdulSalaamazimi! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  8. 30 remaining items

  9. melvin-bot commented on Mar 23, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  10. ahmedGaber93 commented on Mar 24, 2026

    @ahmedGaber93
    Contributor

    Follow-up PR — no payment required.

  11. melvin-bot commented on Mar 30, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@mallenexpensify)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  12. ahmedGaber93 commented on Mar 30, 2026

    @ahmedGaber93
    Contributor
  13. melvin-bot commented on Mar 30, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@mallenexpensify)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  14. mallenexpensify commented on Mar 31, 2026

    @mallenexpensify
    Contributor

    Closing, no payment due and a comment about the regression is on the parent issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions