You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-03-19] Reports - Report row shows fallback avatar when user has custom avatar #84472
Version Number: 9.3.33-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#84284 Email or phone of affected tester (no customers):sodijsnoidnjsoijsod@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Money Requests
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
Report rows on the Reports page show fallback (generic silhouette) avatars instead of the user's custom uploaded avatar.
What is the root cause of that problem?
PR #84284 replaced the desktop/large-screen avatar rendering in ExpenseReportListItemRow with a new lightweight SearchReportAvatar component. The previous approach used the full ReportActionAvatars component, which internally reads personal details from Onyx's live PERSONAL_DETAILS_LIST via the useReportActionAvatars hook (src/components/ReportActionAvatars/useReportActionAvatars.ts:57-62). This store contains complete avatar data for all known users.
The new approach pre-computes avatar data at data-transformation time via getSearchReportAvatarProps() (src/libs/SearchUIUtils.ts:1846-1878), which calls ReportUtils.getIcons() using onlydata.personalDetailsList from the search API response — with no fallback to Onyx's comprehensive personal details store.
If the search API's personalDetailsList does not include the avatar field for a user (it's optional per src/types/onyx/PersonalDetails.ts:51), or if data.personalDetailsList is undefined entirely (allowed by src/types/onyx/SearchResults.ts:294), then getIcons() resolves to FallbackAvatar via the pattern at src/libs/ReportUtils.ts:3310:
This only affects the desktop/large-screen layout (line 283 of ExpenseReportListItemRow.tsx). The mobile/narrow layout still uses ReportSearchHeader → AvatarWithDisplayName → ReportActionAvatars, which reads from the full Onyx store and is unaffected.
What changes do you think we should make in order to solve the problem?
In getSearchReportAvatarProps() (or its call site in getSections() at src/libs/SearchUIUtils.ts:2352), merge data.personalDetailsList with the full Onyx PERSONAL_DETAILS_LIST so that custom avatar URLs are available even when the search API response doesn't include them. This mirrors the fallback behavior the old useReportActionAvatars hook had.
Alternatively, since getSections already receives data.personalDetailsList, the caller could be updated to merge it with Onyx personal details before passing it to getSearchReportAvatarProps, ensuring avatar data is complete.
What alternative solutions did you explore? (Optional)
Convert SearchReportAvatar to use a hook that reads from Onyx at render time — this would match the old behavior exactly but defeats the performance purpose of PR [PERF] - Use lighter avatar component in Report Item Row #84284, which aimed to avoid per-item Onyx subscriptions.
Pre-populate avatars in the search API response — this would be a backend change to ensure personalDetailsList always includes avatar fields, but that's a larger scope change and wouldn't protect against missing data.
The merge approach (option in the recommended fix) preserves the performance benefit of pre-computing avatars while ensuring custom avatar data is always available.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken.
Link to discussion: N/A — Not critical. Functional behavior is correct; only avatar display is affected.
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Mar 7, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #84284
melvin-bot commentedon Mar 7, 2026
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Mar 7, 2026
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Mar 7, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Mar 7, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
Report rows on the Reports page show fallback (generic silhouette) avatars instead of the user's custom uploaded avatar.
What is the root cause of that problem?
PR #84284 replaced the desktop/large-screen avatar rendering in
ExpenseReportListItemRowwith a new lightweightSearchReportAvatarcomponent. The previous approach used the fullReportActionAvatarscomponent, which internally reads personal details from Onyx's livePERSONAL_DETAILS_LISTvia theuseReportActionAvatarshook (src/components/ReportActionAvatars/useReportActionAvatars.ts:57-62). This store contains complete avatar data for all known users.The new approach pre-computes avatar data at data-transformation time via
getSearchReportAvatarProps()(src/libs/SearchUIUtils.ts:1846-1878), which callsReportUtils.getIcons()using onlydata.personalDetailsListfrom the search API response — with no fallback to Onyx's comprehensive personal details store.At
src/libs/SearchUIUtils.ts:2352:If the search API's
personalDetailsListdoes not include theavatarfield for a user (it's optional persrc/types/onyx/PersonalDetails.ts:51), or ifdata.personalDetailsListisundefinedentirely (allowed bysrc/types/onyx/SearchResults.ts:294), thengetIcons()resolves toFallbackAvatarvia the pattern atsrc/libs/ReportUtils.ts:3310:This only affects the desktop/large-screen layout (line 283 of
ExpenseReportListItemRow.tsx). The mobile/narrow layout still usesReportSearchHeader→AvatarWithDisplayName→ReportActionAvatars, which reads from the full Onyx store and is unaffected.What changes do you think we should make in order to solve the problem?
In
getSearchReportAvatarProps()(or its call site ingetSections()atsrc/libs/SearchUIUtils.ts:2352), mergedata.personalDetailsListwith the full OnyxPERSONAL_DETAILS_LISTso that custom avatar URLs are available even when the search API response doesn't include them. This mirrors the fallback behavior the olduseReportActionAvatarshook had.Alternatively, since
getSectionsalready receivesdata.personalDetailsList, the caller could be updated to merge it with Onyx personal details before passing it togetSearchReportAvatarProps, ensuring avatar data is complete.What alternative solutions did you explore? (Optional)
SearchReportAvatarto use a hook that reads from Onyx at render time — this would match the old behavior exactly but defeats the performance purpose of PR [PERF] - Use lighter avatar component in Report Item Row #84284, which aimed to avoid per-item Onyx subscriptions.personalDetailsListalways includesavatarfields, but that's a larger scope change and wouldn't protect against missing data.The merge approach (option in the recommended fix) preserves the performance benefit of pre-computing avatars while ensuring custom avatar data is always available.
Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.29 remaining items
melvin-bot commentedon Mar 19, 2026
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Mar 20, 2026
Payment Summary
Contributor+: @abzokhattab due $250 via NewDot
@abzokhattab plz complete the BZ checklist and tag me in a post once you have. Thx
abzokhattab commentedon Mar 20, 2026
@mallenexpensify Here is the main PR #84599. The mentioned PR is a follow-up that tackled this review comment
mallenexpensify commentedon Mar 21, 2026
@abzokhattab payment summary updated above, plz complete the BZ checklist and tag me in a post once you have. Thx
melvin-bot commentedon Mar 24, 2026
@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
abzokhattab commentedon Mar 26, 2026
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/84284/changes#r2996080088
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken.
Link to discussion: N/A — Not critical. Functional behavior is correct; only avatar display is affected.
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/616717
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
Zapier Logs
Run ID: 00040eee-b499-ae26-3493-2bbd01b34874abzokhattab commentedon Mar 26, 2026
@mallenexpensify done
mallenexpensify commentedon Mar 26, 2026
Thx @abzokhattab
^ Test case created
twisterdotcom commentedon Mar 26, 2026
@abzokhattab has submitted payment for this report on ND here.
SO: https://stackoverflowteams.com/c/expensify/questions/7582
Zapier Logs
Run ID: 00040eee-41fd-a7e4-4d43-9e64522eeb24