Skip to content

AcceptSpotnanaTerms sends wrong parameter name, causing permission denied for non-owner domains #84473

Closed

Description

@blimpich

Problem

Coming from here. When a domain admin on a non-owner domain (e.g. cardtest.expensify.com) tries to enable Expensify Travel, they receive:

"You don't have permission to enable Expensify Travel for this domain"

Root Cause

The App client sends the domain as parameter domain in the AcceptSpotnanaTerms API call, but api.php reads domainName. This causes the domain to be empty when passed to Auth, which then falls back to the policy owner's email domain (e.g. expensify.com), failing the membership check.

Fix

Rename the domain parameter to domainName in:

  • AcceptSpotnanaTermsParams.ts
  • Travel.ts

so it matches what the backend expects.

Activity

  1. melvin-bot commented on Mar 30, 2026

    @melvin-bot

    This issue has not been updated in over 15 days. eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions