You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-03-24] UpdateTravelInvoiceSettlementFrequency should not call API when same option is reselected #84638
When a user selects the same settlement frequency option that is already active (e.g. clicking "Daily" when the current setting is already "Daily"), the UpdateTravelInvoiceSettlementFrequency API call is still made. This is an unnecessary network request.
Expected Behavior
If the selected settlement frequency matches the current value, the RHP should close without making an API call. The API should only be called when the user selects a different option.
Steps to Reproduce
Navigate to Travel Invoice settlement frequency settings
Note the current selection (e.g. "Daily")
Click the same option again (e.g. "Daily")
Observe that the API call is still made despite no change in value
changed the title [-]UpdateTravelInvoiceSettlementFrequency should not call API when same option is reselected[/-][+][Due for payment 2026-03-24] UpdateTravelInvoiceSettlementFrequency should not call API when same option is reselected[/+]on Mar 17, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.38-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Activity
blimpich commentedon Mar 9, 2026
Screen.Recording.2026-03-09.at.2.21.43.PM.mov
ikevin127 commentedon Mar 11, 2026
I'll get to this sometime by the EOW when I'll be back at full capacity 🙏
ikevin127 commentedon Mar 13, 2026
🟢 PR #85153 open for review!
[-]UpdateTravelInvoiceSettlementFrequency should not call API when same option is reselected[/-][+][Due for payment 2026-03-24] UpdateTravelInvoiceSettlementFrequency should not call API when same option is reselected[/+]melvin-bot commentedon Mar 17, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 17, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.38-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-03-24. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 17, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)parasharrajat commentedon Mar 17, 2026
Part of project.
rlinoz commentedon Mar 17, 2026
Good to close.