Skip to content

[Due for payment 2026-03-24] UpdateTravelInvoiceSettlementFrequency should not call API when same option is reselected #84638

Closed

Description

@blimpich

Description

When a user selects the same settlement frequency option that is already active (e.g. clicking "Daily" when the current setting is already "Daily"), the UpdateTravelInvoiceSettlementFrequency API call is still made. This is an unnecessary network request.

Expected Behavior

If the selected settlement frequency matches the current value, the RHP should close without making an API call. The API should only be called when the user selects a different option.

Steps to Reproduce

  1. Navigate to Travel Invoice settlement frequency settings
  2. Note the current selection (e.g. "Daily")
  3. Click the same option again (e.g. "Daily")
  4. Observe that the API call is still made despite no change in value
Issue OwnerCurrent Issue Owner: @ikevin127

Activity

  1. self-assigned this
    on Mar 9, 2026
  2. blimpich commented on Mar 9, 2026

    @blimpich
    ContributorAuthor
    Screen.Recording.2026-03-09.at.2.21.43.PM.mov
  3. ikevin127 commented on Mar 11, 2026

    @ikevin127
    Contributor

    I'll get to this sometime by the EOW when I'll be back at full capacity 🙏

  4. ikevin127 commented on Mar 13, 2026

    @ikevin127
    Contributor

    🟢 PR #85153 open for review!

  5. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 17, 2026
  6. changed the title [-]UpdateTravelInvoiceSettlementFrequency should not call API when same option is reselected[/-] [+][Due for payment 2026-03-24] UpdateTravelInvoiceSettlementFrequency should not call API when same option is reselected[/+] on Mar 17, 2026
  7. melvin-bot commented on Mar 17, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  8. melvin-bot commented on Mar 17, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.38-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-03-24. 🎊

    For reference, here are some details about the assignees on this issue:

    • @parasharrajat requires payment through NewDot Manual Requests
    • @ikevin127 requires payment through NewDot Manual Requests
  9. melvin-bot commented on Mar 17, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  10. parasharrajat commented on Mar 17, 2026

    @parasharrajat
    Member

    Part of project.

  11. rlinoz commented on Mar 17, 2026

    @rlinoz
    Contributor

    Good to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions