Skip to content

Revert reportDrafts removal from IOURequestStepConfirmation #84788

Closed as not planned

Description

@marcaaron

Problem

In #84286, the reportDrafts collection subscription was removed from IOURequestStepConfirmation. The component now relies on the module-level allReportsDraft variable via getReportOrDraftReport(), which is an impure function pattern we're actively trying to remove.

Solution

Revert the reportDrafts removal from IOURequestStepConfirmation so it uses a proper subscription instead of the module-level Onyx connect. Specifically, restore reportDrafts to the component's dependencies and pass it through to getReportOption.

Activity

  1. marcaaron commented on Mar 10, 2026

    @marcaaron
    ContributorAuthor

    Closing - folding this into a broader issue for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions