Skip to content

[Due for payment 2026-06-09] [$250] [Exploratory] 84634 - Wallet - International Bank can be saved with wrong credentials failing if autocorrected #84811

Closed

Description

@vincdargento

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.34-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176692/test-cases/41236749
Email or phone of affected tester (no customers): gatantm+636a@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: iPhone 12 mini, iOS 16.7
App Component: Other

Action Performed:

  1. Launch expensify and login with any account
  2. Tap on Account > Wallet
  3. Tap on Add bank account > Get reimbursed
  4. Select India as the country
  5. Add an ISFC code
  6. For account number type something that will be autocorrected from IOS (e.g Whats)
  7. Tap next and follow the flow until reaching he confirm page and confirm

Expected Result:

The word is not autocorrected to something that is invalid and the app doesn't allow it to be saved

Actual Result:

On specific strings the iOS will auto correct them even if leaving the screen with the on screen validation be skipped and then the bank can't saved although the typed word is valid. The user won't easily understand why the validation fails

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mallenexpensify
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022043614610167989966
  • Upwork Job ID: 2043614610167989966
  • Last Price Increase: 2026-05-04

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed on Apr 13, 2026
  2. MelvinBot commented on Apr 13, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    The bank account input fields (account number, IFSC/routing code, SWIFT, etc.) in the international deposit account flow are rendered as TextInput components with iOS autocorrect enabled by default. The native BaseTextInput defaults to autoCorrect = true (index.native.tsx:65), and none of the bank detail form pages override this.

    The affected pages are:

    Additionally, the Confirmation page only validates acceptTerms — it does not re-validate bank field values before sending them to the API. So if autocorrect modifies a value after step-level validation passed, the corrupted value reaches the API unchecked.

    What changes do you think we should make in order to solve the problem?

    Add autoCorrect={false} and spellCheck={false} to all TextInput fields in the bank account detail forms listed above. These fields accept structured data (account numbers, IFSC codes, SWIFT codes) where autocorrect is always harmful.

    This should be applied to the InputWrapper components in all three affected files, specifically for fields that render as TextInput (not ValuePicker).

    What alternative solutions did you explore? (Optional)

    An alternative would be to re-validate all bank field values on the Confirmation page before submission. However, disabling autocorrect on structured financial input fields is the more direct and appropriate fix — autocorrect should never apply to bank account numbers and routing codes regardless of downstream validation.


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  3. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 13, 2026
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 13, 2026
  5. melvin-bot commented on Apr 13, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @truph01 (External)

  6. changed the title [-][Exploratory] 84634 - Wallet - International Bank can be saved with wrong credentials failing if autocorrected[/-] [+][$250] [Exploratory] 84634 - Wallet - International Bank can be saved with wrong credentials failing if autocorrected[/+] on Apr 13, 2026
  7. 46 remaining items

  8. melvin-bot commented on Jun 8, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  9. melvin-bot commented on Jun 8, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    • Reviewer: @truph01 owed $250 via NewDot

    BugZero Checklist (@mallenexpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/2043614610167989966/hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  10. melvin-bot commented on Jun 11, 2026

    @melvin-bot

    @mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  11. melvin-bot commented on Jun 17, 2026

    @melvin-bot

    @mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  12. mallenexpensify commented on Jun 17, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @truph01 due $250 via NewDot

  13. garrettmknight commented on Aug 10, 2026

    @garrettmknight
    Contributor

    $250 approved for @truph01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions