Skip to content

[Due for payment 2026-03-23] Investigate workflow job failing on main: typecheck / typecheck #84928

Closed

Description

@github-actions

🚨 Failure Summary 🚨:

  • 📋 Job Name: typecheck / typecheck
  • 🔧 Failure in Workflow: Process new code merged to main
  • 🔗 Triggered by PR: PR Link
  • 👤 PR Author: @daledah
  • 🤝 Merged by: @dangrous
  • 🐛 Error Message:
    warning: Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@8ade135. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
    failure: Process completed with exit code 2.
    failure: Cannot find name 'allReportsViolations'. Did you mean 'reportViolations'?

⚠️ Action Required ⚠️:

🛠️ A recent merge appears to have caused a failure in the job named typecheck / typecheck.
🔍 This issue has been automatically created and labeled with Workflow Failure for investigation.

👀 Please look into the following:

  1. Why the PR caused the job to fail?
  2. Address any underlying issues.

🐛 We appreciate your help in squashing this bug!

Activity

  1. MelvinBot commented on Mar 11, 2026

    @MelvinBot
    Contributor

    🔍 This issue shares the same root cause as #84930 and #84929. See my analysis on #84930 for full details and recommended fix.

    TL;DR: PR #83424 added a hasVisibleReportFieldViolations function in ReportUtils.ts that references allReportsViolations (line 13076) — a variable that was never declared. This directly causes the Cannot find name 'allReportsViolations' TypeScript error. A single fix (adding reportViolations as a function parameter) resolves all three issues.

  2. dangrous commented on Mar 12, 2026

    @dangrous
    Contributor

    This was resolved by a revert of #83424, caused by a bad merge

  3. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 16, 2026
  4. changed the title [-]Investigate workflow job failing on main: typecheck / typecheck[/-] [+][Due for payment 2026-03-23] Investigate workflow job failing on main: typecheck / typecheck[/+] on Mar 16, 2026
  5. melvin-bot commented on Mar 16, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  6. melvin-bot commented on Mar 16, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.37-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-03-23. 🎊

  7. melvin-bot commented on Mar 16, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions