You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-03-19] Report field & Taxes - Name field auto throws error #84958
Version Number: 9.3.36-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#82510 Email or phone of affected tester (no customers):sjnodijsodjnoindjisoj@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Workspace Settings
Action Performed:
Precondition:
Enable Report fields in workspace settings > Reports.
Go to staging.new.expensify.com
Go to workspace settings > Reports.
Click Add field.
Click Name.
Expected Result:
Name field will not throw error.
Actual Result:
Name field auto throws error.
If user enters text on Name field before error shows up, "Name" header is highlighted instead.
Similar issue is observed in Taxes > Add rate > Name.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #82510 - "fix: Screen Reader: Many Pages: There is no dialog role and title announced" by @TaduJR (High confidence) Related Issues: None
Recommendation: REVERT
PR #82510 introduces a focus management conflict that causes immediate validation errors when opening TextSelectorModal for required fields. The PR added accessibility improvements but inadvertently breaks the user flow for creating report fields and tax rates.
Labels: No label changes needed - keeping both DeployBlockerCash and DeployBlocker as this is reproducible on staging only and requires an App PR fix.
Detailed Analysis
Evidence
PR #82510 added dialog accessibility features to RHP (Right Hand Panel) pages, including:
DialogLabelContext - tracks the dialog title
useDialogTitleFocus - automatically focuses the Header title after RHP transition completes
Header component registers its title and receives focus via tabIndex={-1}
The focus happens after SCREEN_TRANSITION_END_TIMEOUT (1000ms) as a fallback or when the transitionEnd navigation event fires.
useFocusEffect(useCallback(()=>{focusTimeoutRef.current=setTimeout(()=>{if(inputRef.current&&isVisible){inputRef.current.focus();// This happens at T+300ms
...
}},CONST.ANIMATED_TRANSITION);// 300ms},[isVisible,autoGrowHeight]),);
The issue description confirms this: "If user enters text on Name field before error shows up, Name header is highlighted instead" - the header text is receiving focus as designed by PR #82510.
Labels: Removed DeployBlocker label. This is a frontend bug that requires reverting or fixing PR #82510 in the App repository. Keeping DeployBlockerCash to block the App deploy until resolved.
changed the title [-]Report field & Taxes - Name field auto throws error[/-][+][Due for payment 2026-03-19] Report field & Taxes - Name field auto throws error[/+]on Mar 12, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.36-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@amyevans The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Mar 11, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #82510
melvin-bot commentedon Mar 11, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Mar 11, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Mar 11, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #82510 - "fix: Screen Reader: Many Pages: There is no dialog role and title announced" by @TaduJR (High confidence)
Related Issues: None
Recommendation: REVERT
PR #82510 introduces a focus management conflict that causes immediate validation errors when opening TextSelectorModal for required fields. The PR added accessibility improvements but inadvertently breaks the user flow for creating report fields and tax rates.
Labels: No label changes needed - keeping both
DeployBlockerCashandDeployBlockeras this is reproducible on staging only and requires an App PR fix.Detailed Analysis
Evidence
PR #82510 added dialog accessibility features to RHP (Right Hand Panel) pages, including:
DialogLabelContext- tracks the dialog titleuseDialogTitleFocus- automatically focuses the Header title after RHP transition completestabIndex={-1}The focus happens after
SCREEN_TRANSITION_END_TIMEOUT(1000ms) as a fallback or when thetransitionEndnavigation event fires.Verification
Affected files from PR #82510:
/home/runner/_work/App/App/src/components/Header.tsx- Added dialog label registration and focus management/home/runner/_work/App/App/src/hooks/useDialogTitleFocus/index.ts- New hook that focuses title after transition/home/runner/_work/App/App/src/components/DialogLabelContext.tsx- New context for managing dialog labels/home/runner/_work/App/App/src/libs/Navigation/AppNavigator/Navigators/RightModalNavigator.tsx- Wrapped Stack.Navigator in DialogLabelProviderAffected pages:
/home/runner/_work/App/App/src/pages/workspace/reports/CreateReportFieldsPage.tsx- Uses TextPicker for Name field/home/runner/_work/App/App/src/pages/workspace/taxes/WorkspaceCreateTaxPage.tsx- Uses TextPicker for Name fieldBoth pages use
TextPickercomponent which opensTextSelectorModal.Root Cause
Timeline of events when clicking "Name" field:
useFocusEffectwithANIMATED_TRANSITIONdelayuseDialogTitleFocuswithSCREEN_TRANSITION_END_TIMEOUTfallbackKey code locations:
src/hooks/useDialogTitleFocus/index.ts:32:src/components/Header.tsx:112-117:src/components/TextPicker/TextSelectorModal.tsx:99-118:The issue description confirms this: "If user enters text on Name field before error shows up, Name header is highlighted instead" - the header text is receiving focus as designed by PR #82510.
OSBotify commentedon Mar 11, 2026
Labels: Removed
DeployBlockerlabel. This is a frontend bug that requires reverting or fixing PR #82510 in the App repository. KeepingDeployBlockerCashto block the App deploy until resolved.10 remaining items
melvin-bot commentedon Mar 12, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Mar 12, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Mar 12, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Mar 12, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
[-]Report field & Taxes - Name field auto throws error[/-][+][Due for payment 2026-03-19] Report field & Taxes - Name field auto throws error[/+]melvin-bot commentedon Mar 12, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 12, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.36-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-03-19. 🎊
melvin-bot commentedon Mar 12, 2026
@amyevans The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Mar 12, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)