Skip to content

[Due for payment 2026-03-19] Expense - Scan expense from QAB does not redirect to confirm page #84961

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.36-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #84552
Email or phone of affected tester (no customers): sdoisjdnosjiodisoj22@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a new Gmail account.
  3. Complete onboarding with Something else as intent.
  4. Create a workspace.
  5. Open FAB > click Scan receipt from Quick action.
  6. Upload a receipt.

Expected Result:

After uploading a receipt, RHP will open confirm page with the new workspace as destination.

Actual Result:

After uploading a receipt, RHP opens recipient list and says "You no longer have access to your previous quick action destination."

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7100343_1773260690716.2.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Mar 11, 2026
  2. melvin-bot commented on Mar 11, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #84552

  3. melvin-bot commented on Mar 11, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on Mar 11, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. MelvinBot commented on Mar 11, 2026

    @MelvinBot
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    After creating a new workspace, clicking Scan receipt from the Quick Action Button (QAB) in the FAB menu, and uploading a receipt, the user sees the recipient list with "You no longer have access to your previous quick action destination" instead of being taken to the confirmation page.

    What is the root cause of that problem?

    PR #84552 added !initialTransaction?.isFromFloatingActionButton to the condition in handleMoneyRequestStepScanParticipants at src/libs/actions/IOU/MoneyRequest.ts:368:

    if (!initialTransaction?.isFromGlobalCreate && !initialTransaction?.isFromFloatingActionButton && !isArchivedExpenseReport && iouType !== CONST.IOU.TYPE.CREATE) {

    The intent was to prevent the green receipt FAB button from auto-assigning participants. However, the green receipt FAB already uses iouType=CREATE, which makes this condition FALSE via iouType !== CONST.IOU.TYPE.CREATE — so the new check is redundant for that flow.

    The unintended side effect is on the Quick Action flow. When the user clicks "Scan receipt" from the QAB menu, navigateToQuickAction (QuickActionNavigation.ts:52) calls startMoneyRequest(CONST.IOU.TYPE.SUBMIT, ...) with isFromFloatingActionButton=true and skipConfirmation=true. The flow then:

    1. clearMoneyRequest sets SKIP_CONFIRMATION = true in Onyx
    2. The transaction draft gets isFromFloatingActionButton: true
    3. After the receipt is scanned, handleMoneyRequestStepScanParticipants runs with iouType=SUBMIT
    4. Before the PR: !isFromGlobalCreate(true) && !isArchived(true) && iouType !== CREATE(true) → TRUE → enters the "from report" block, auto-assigns participants, and either creates the transaction or navigates to confirmation
    5. After the PR: !isFromGlobalCreate(true) && !isFromFloatingActionButton(false) → FALSE → skips the "from report" block entirely
    6. Falls through to shouldUseDefaultExpensePolicy(SUBMIT, ...) → returns false (requires iouType=CREATE)
    7. Falls through to navigateToParticipantPage() → participant page renders with skipConfirmation=true → shows the error message (IOURequestStepParticipants.tsx:447-454)

    What changes do you think we should make in order to solve the problem?

    Remove !initialTransaction?.isFromFloatingActionButton from the condition at MoneyRequest.ts:368, reverting it to:

    if (!initialTransaction?.isFromGlobalCreate && !isArchivedExpenseReport && iouType !== CONST.IOU.TYPE.CREATE) {

    This check is redundant for the green receipt FAB flow (which already has iouType=CREATE), and harmful for the quick action flow (which needs the "from report" path to auto-assign participants and skip confirmation).

    The telemetry additions from PR #84552 (Sentry spans, useScanShortcutSpan, the startSpan calls, and storing isFromFloatingActionButton/iouRequestType on the transaction draft) can remain — only the routing condition needs to revert.

    What alternative solutions did you explore? (Optional)

    An alternative would be to only apply the isFromFloatingActionButton exclusion when skipConfirmation is false (i.e., !initialTransaction?.isFromFloatingActionButton || shouldSkipConfirmation), but this is more complex and the simpler revert is cleaner since the existing iouType !== CREATE check already handles the green receipt FAB case.


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  6. self-assigned this
    on Mar 12, 2026
  7. 3 remaining items

  8. cristipaval commented on Mar 12, 2026

    @cristipaval
    Contributor

    Thank you! Closing

  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 12, 2026
  10. changed the title [-]Expense - Scan expense from QAB does not redirect to confirm page[/-] [+][Due for payment 2026-03-19] Expense - Scan expense from QAB does not redirect to confirm page[/+] on Mar 12, 2026
  11. melvin-bot commented on Mar 12, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Mar 12, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.36-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-03-19. 🎊

  13. melvin-bot commented on Mar 12, 2026

    @melvin-bot

    @cristipaval The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. melvin-bot commented on Mar 12, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions