You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-03-19] Expense - Scan expense from QAB does not redirect to confirm page #84961
Version Number: 9.3.36-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#84552 Email or phone of affected tester (no customers):sdoisjdnosjiodisoj22@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Money Requests
Action Performed:
Go to staging.new.expensify.com
Create a new Gmail account.
Complete onboarding with Something else as intent.
Create a workspace.
Open FAB > click Scan receipt from Quick action.
Upload a receipt.
Expected Result:
After uploading a receipt, RHP will open confirm page with the new workspace as destination.
Actual Result:
After uploading a receipt, RHP opens recipient list and says "You no longer have access to your previous quick action destination."
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
After creating a new workspace, clicking Scan receipt from the Quick Action Button (QAB) in the FAB menu, and uploading a receipt, the user sees the recipient list with "You no longer have access to your previous quick action destination" instead of being taken to the confirmation page.
The intent was to prevent the green receipt FAB button from auto-assigning participants. However, the green receipt FAB already uses iouType=CREATE, which makes this condition FALSE via iouType !== CONST.IOU.TYPE.CREATE — so the new check is redundant for that flow.
The unintended side effect is on the Quick Action flow. When the user clicks "Scan receipt" from the QAB menu, navigateToQuickAction (QuickActionNavigation.ts:52) calls startMoneyRequest(CONST.IOU.TYPE.SUBMIT, ...) with isFromFloatingActionButton=true and skipConfirmation=true. The flow then:
clearMoneyRequest sets SKIP_CONFIRMATION = true in Onyx
The transaction draft gets isFromFloatingActionButton: true
After the receipt is scanned, handleMoneyRequestStepScanParticipants runs with iouType=SUBMIT
Before the PR: !isFromGlobalCreate(true) && !isArchived(true) && iouType !== CREATE(true) → TRUE → enters the "from report" block, auto-assigns participants, and either creates the transaction or navigates to confirmation
After the PR: !isFromGlobalCreate(true) && !isFromFloatingActionButton(false) → FALSE → skips the "from report" block entirely
Falls through to shouldUseDefaultExpensePolicy(SUBMIT, ...) → returns false (requires iouType=CREATE)
Falls through to navigateToParticipantPage() → participant page renders with skipConfirmation=true → shows the error message (IOURequestStepParticipants.tsx:447-454)
What changes do you think we should make in order to solve the problem?
Remove !initialTransaction?.isFromFloatingActionButton from the condition at MoneyRequest.ts:368, reverting it to:
This check is redundant for the green receipt FAB flow (which already has iouType=CREATE), and harmful for the quick action flow (which needs the "from report" path to auto-assign participants and skip confirmation).
The telemetry additions from PR #84552 (Sentry spans, useScanShortcutSpan, the startSpan calls, and storing isFromFloatingActionButton/iouRequestType on the transaction draft) can remain — only the routing condition needs to revert.
What alternative solutions did you explore? (Optional)
An alternative would be to only apply the isFromFloatingActionButton exclusion when skipConfirmation is false (i.e., !initialTransaction?.isFromFloatingActionButton || shouldSkipConfirmation), but this is more complex and the simpler revert is cleaner since the existing iouType !== CREATE check already handles the green receipt FAB case.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
changed the title [-]Expense - Scan expense from QAB does not redirect to confirm page[/-][+][Due for payment 2026-03-19] Expense - Scan expense from QAB does not redirect to confirm page[/+]on Mar 12, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.36-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@cristipaval The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Mar 11, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #84552
melvin-bot commentedon Mar 11, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Mar 11, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Mar 11, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
After creating a new workspace, clicking Scan receipt from the Quick Action Button (QAB) in the FAB menu, and uploading a receipt, the user sees the recipient list with "You no longer have access to your previous quick action destination" instead of being taken to the confirmation page.
What is the root cause of that problem?
PR #84552 added
!initialTransaction?.isFromFloatingActionButtonto the condition inhandleMoneyRequestStepScanParticipantsatsrc/libs/actions/IOU/MoneyRequest.ts:368:The intent was to prevent the green receipt FAB button from auto-assigning participants. However, the green receipt FAB already uses
iouType=CREATE, which makes this condition FALSE viaiouType !== CONST.IOU.TYPE.CREATE— so the new check is redundant for that flow.The unintended side effect is on the Quick Action flow. When the user clicks "Scan receipt" from the QAB menu,
navigateToQuickAction(QuickActionNavigation.ts:52) callsstartMoneyRequest(CONST.IOU.TYPE.SUBMIT, ...)withisFromFloatingActionButton=trueandskipConfirmation=true. The flow then:clearMoneyRequestsetsSKIP_CONFIRMATION = truein OnyxisFromFloatingActionButton: truehandleMoneyRequestStepScanParticipantsruns withiouType=SUBMIT!isFromGlobalCreate(true) && !isArchived(true) && iouType !== CREATE(true)→ TRUE → enters the "from report" block, auto-assigns participants, and either creates the transaction or navigates to confirmation!isFromGlobalCreate(true) && !isFromFloatingActionButton(false)→ FALSE → skips the "from report" block entirelyshouldUseDefaultExpensePolicy(SUBMIT, ...)→ returnsfalse(requiresiouType=CREATE)navigateToParticipantPage()→ participant page renders withskipConfirmation=true→ shows the error message (IOURequestStepParticipants.tsx:447-454)What changes do you think we should make in order to solve the problem?
Remove
!initialTransaction?.isFromFloatingActionButtonfrom the condition atMoneyRequest.ts:368, reverting it to:This check is redundant for the green receipt FAB flow (which already has
iouType=CREATE), and harmful for the quick action flow (which needs the "from report" path to auto-assign participants and skip confirmation).The telemetry additions from PR #84552 (Sentry spans,
useScanShortcutSpan, thestartSpancalls, and storingisFromFloatingActionButton/iouRequestTypeon the transaction draft) can remain — only the routing condition needs to revert.What alternative solutions did you explore? (Optional)
An alternative would be to only apply the
isFromFloatingActionButtonexclusion whenskipConfirmationis false (i.e.,!initialTransaction?.isFromFloatingActionButton || shouldSkipConfirmation), but this is more complex and the simpler revert is cleaner since the existingiouType !== CREATEcheck already handles the green receipt FAB case.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.3 remaining items
cristipaval commentedon Mar 12, 2026
Thank you! Closing
[-]Expense - Scan expense from QAB does not redirect to confirm page[/-][+][Due for payment 2026-03-19] Expense - Scan expense from QAB does not redirect to confirm page[/+]melvin-bot commentedon Mar 12, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 12, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.36-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-03-19. 🎊
melvin-bot commentedon Mar 12, 2026
@cristipaval The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Mar 12, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)