Skip to content

[Due for payment 2026-03-30] [$125] Use valid loading indicator in WorkspacesListPage.tsx #84990

Closed

Description

@Julesssss

Details

As part of the loading indicator standardization, we are preparing to enable shouldUseGoBackButton by default in FullscreenLoadingIndicator. Before that, we need to migrate components where FullscreenLoadingIndicator is used alongside visible navigation to use ActivityIndicator instead, otherwise users would see two back controls (the header back button AND the Go Back button from the loader).

WorkspacesListPage.tsx renders TopBar and NavigationTabBar alongside FullscreenLoadingIndicator. When shouldShowLoadingIndicator is true, the TopBar breadcrumb and the tab bar are always visible, so the user can already navigate away. FullscreenLoadingIndicator is unnecessary here and should be replaced with a plain ActivityIndicator.

Solution

Replace FullscreenLoadingIndicator with ActivityIndicator in src/pages/workspace/WorkspacesListPage.tsx. The loading state must be pixel-perfect identical after the change, same background color, same opacity, same centered large spinner in the content area below the TopBar.

Before making any changes, read the FullscreenLoadingIndicator component source to understand what styles it applies internally, and make sure the replacement reproduces them exactly. ActivityIndicator is a raw spinner with no layout or background styling, so it should not be used on its own as a fullscreen loading state, the codebase convention is to wrap it in a parent View that provides the layout and background styling.

Parent issue: #69850, summary comment

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. self-assigned this
    on Mar 11, 2026
  2. MelvinBot commented on Mar 11, 2026

    @MelvinBot
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    WorkspacesListPage.tsx uses FullScreenLoadingIndicator alongside visible navigation controls (TopBar and NavigationTabBar). As part of enabling shouldUseGoBackButton by default in FullScreenLoadingIndicator (parent issue #69850), this would cause users to see two back controls — the header back button and the Go Back button from the loader. We need to replace FullScreenLoadingIndicator with a plain ActivityIndicator to avoid this conflict.

    What is the root cause of that problem?

    FullScreenLoadingIndicator is designed as an overlay component (uses StyleSheet.absoluteFillObject, fullScreenLoading styles with backgroundColor, opacity: 0.8, zIndex: 10) and will soon include a "Go Back" button by default. In WorkspacesListPage.tsx (lines 742–745), the TopBar and NavigationTabBar are always visible during loading, so the user can already navigate away — making the overlay and its upcoming Go Back button redundant and visually conflicting.

    What changes do you think we should make in order to solve the problem?

    In src/pages/workspace/WorkspacesListPage.tsx, replace the current loading block (lines 742–745):

    <View style={[styles.flex1]}>
        <FullScreenLoadingIndicator style={[styles.flex1, styles.pRelative]} />
    </View>

    With:

    <View style={[styles.flex1, styles.fullScreenLoading]}>
        <ActivityIndicator size={CONST.ACTIVITY_INDICATOR_SIZE.LARGE} />
    </View>

    This reproduces the same visual result — a large centered spinner with componentBG background at 0.8 opacity filling the content area below the TopBar — but uses a plain ActivityIndicator that won't gain a Go Back button.

    Update imports accordingly: remove FullScreenLoadingIndicator, add ActivityIndicator and ensure CONST is imported (it already is).

    This follows the established pattern used in HelpContent.tsx (line 128–131) where fullScreenLoading styles are applied to a wrapper View with an ActivityIndicator inside, without the absolute overlay behavior.

    What alternative solutions did you explore? (Optional)

    The simplest alternative would be a bare ActivityIndicator with style={[styles.flex1]} (no wrapping View), which is the most common pattern in workspace pages like WorkspaceTaxesPage.tsx. However, this would lose the componentBG background and 0.8 opacity that the current implementation has, so the loading state would not be pixel-perfect identical. Using the fullScreenLoading style on a wrapper View preserves the exact visual appearance as required by the issue.


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  3. situchan commented on Mar 11, 2026

    @situchan
    Contributor

    👋

  4. changed the title [-]Use valid loading indicator in `WorkspacesListPage.tsx`[/-] [+][$125] Use valid loading indicator in `WorkspacesListPage.tsx`[/+] on Mar 11, 2026
  5. melvin-bot commented on Mar 11, 2026

    @melvin-bot

    ⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

  6. added
    InternalRequires API changes or must be handled by Expensify staff
    on Mar 16, 2026
  7. 9 remaining items

  8. changed the title [-][$125] Use valid loading indicator in `WorkspacesListPage.tsx`[/-] [+][Due for payment 2026-03-30] [$125] Use valid loading indicator in `WorkspacesListPage.tsx`[/+] on Mar 23, 2026
  9. melvin-bot commented on Mar 23, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  10. melvin-bot commented on Mar 23, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.41-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-03-30. 🎊

    For reference, here are some details about the assignees on this issue:

  11. melvin-bot commented on Mar 23, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  12. Julesssss commented on Mar 24, 2026

    @Julesssss
    ContributorAuthor

    Lets group payments here to make things simpler

  13. melvin-bot commented on Mar 30, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @mateuuszzzzz does not require payment (Contractor)
    • ROLE: @situchan paid $(AMOUNT) via Upwork (LINK)

    BugZero Checklist (@mallenexpensify)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringImprovementItem broken or needs improvement.InternalRequires API changes or must be handled by Expensify staffMelvin TriageAutomatic AI Analysis of an issueTask

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions