You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-03-30] [$125] Use valid loading indicator in WorkspacesListPage.tsx #84990
As part of the loading indicator standardization, we are preparing to enable shouldUseGoBackButton by default in FullscreenLoadingIndicator. Before that, we need to migrate components where FullscreenLoadingIndicator is used alongside visible navigation to use ActivityIndicator instead, otherwise users would see two back controls (the header back button AND the Go Back button from the loader).
WorkspacesListPage.tsx renders TopBar and NavigationTabBar alongside FullscreenLoadingIndicator. When shouldShowLoadingIndicator is true, the TopBar breadcrumb and the tab bar are always visible, so the user can already navigate away. FullscreenLoadingIndicator is unnecessary here and should be replaced with a plain ActivityIndicator.
Solution
Replace FullscreenLoadingIndicator with ActivityIndicator in src/pages/workspace/WorkspacesListPage.tsx. The loading state must be pixel-perfect identical after the change, same background color, same opacity, same centered large spinner in the content area below the TopBar.
Before making any changes, read the FullscreenLoadingIndicator component source to understand what styles it applies internally, and make sure the replacement reproduces them exactly. ActivityIndicator is a raw spinner with no layout or background styling, so it should not be used on its own as a fullscreen loading state, the codebase convention is to wrap it in a parent View that provides the layout and background styling.
Please re-state the problem that we are trying to solve in this issue.
WorkspacesListPage.tsx uses FullScreenLoadingIndicator alongside visible navigation controls (TopBar and NavigationTabBar). As part of enabling shouldUseGoBackButton by default in FullScreenLoadingIndicator (parent issue #69850), this would cause users to see two back controls — the header back button and the Go Back button from the loader. We need to replace FullScreenLoadingIndicator with a plain ActivityIndicator to avoid this conflict.
What is the root cause of that problem?
FullScreenLoadingIndicator is designed as an overlay component (uses StyleSheet.absoluteFillObject, fullScreenLoading styles with backgroundColor, opacity: 0.8, zIndex: 10) and will soon include a "Go Back" button by default. In WorkspacesListPage.tsx (lines 742–745), the TopBar and NavigationTabBar are always visible during loading, so the user can already navigate away — making the overlay and its upcoming Go Back button redundant and visually conflicting.
What changes do you think we should make in order to solve the problem?
In src/pages/workspace/WorkspacesListPage.tsx, replace the current loading block (lines 742–745):
This reproduces the same visual result — a large centered spinner with componentBG background at 0.8 opacity filling the content area below the TopBar — but uses a plain ActivityIndicator that won't gain a Go Back button.
Update imports accordingly: remove FullScreenLoadingIndicator, add ActivityIndicator and ensure CONST is imported (it already is).
This follows the established pattern used in HelpContent.tsx (line 128–131) where fullScreenLoading styles are applied to a wrapper View with an ActivityIndicator inside, without the absolute overlay behavior.
What alternative solutions did you explore? (Optional)
The simplest alternative would be a bare ActivityIndicator with style={[styles.flex1]} (no wrapping View), which is the most common pattern in workspace pages like WorkspaceTaxesPage.tsx. However, this would lose the componentBG background and 0.8 opacity that the current implementation has, so the loading state would not be pixel-perfect identical. Using the fullScreenLoading style on a wrapper View preserves the exact visual appearance as required by the issue.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
changed the title [-]Use valid loading indicator in `WorkspacesListPage.tsx`[/-][+][$125] Use valid loading indicator in `WorkspacesListPage.tsx`[/+]on Mar 11, 2026
changed the title [-][$125] Use valid loading indicator in `WorkspacesListPage.tsx`[/-][+][Due for payment 2026-03-30] [$125] Use valid loading indicator in `WorkspacesListPage.tsx`[/+]on Mar 23, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.41-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Activity
MelvinBot commentedon Mar 11, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
WorkspacesListPage.tsxusesFullScreenLoadingIndicatoralongside visible navigation controls (TopBarandNavigationTabBar). As part of enablingshouldUseGoBackButtonby default inFullScreenLoadingIndicator(parent issue #69850), this would cause users to see two back controls — the header back button and the Go Back button from the loader. We need to replaceFullScreenLoadingIndicatorwith a plainActivityIndicatorto avoid this conflict.What is the root cause of that problem?
FullScreenLoadingIndicatoris designed as an overlay component (usesStyleSheet.absoluteFillObject,fullScreenLoadingstyles withbackgroundColor,opacity: 0.8,zIndex: 10) and will soon include a "Go Back" button by default. InWorkspacesListPage.tsx(lines 742–745), theTopBarandNavigationTabBarare always visible during loading, so the user can already navigate away — making the overlay and its upcoming Go Back button redundant and visually conflicting.What changes do you think we should make in order to solve the problem?
In
src/pages/workspace/WorkspacesListPage.tsx, replace the current loading block (lines 742–745):With:
This reproduces the same visual result — a large centered spinner with
componentBGbackground at0.8opacity filling the content area below theTopBar— but uses a plainActivityIndicatorthat won't gain a Go Back button.Update imports accordingly: remove
FullScreenLoadingIndicator, addActivityIndicatorand ensureCONSTis imported (it already is).This follows the established pattern used in
HelpContent.tsx(line 128–131) wherefullScreenLoadingstyles are applied to a wrapperViewwith anActivityIndicatorinside, without the absolute overlay behavior.What alternative solutions did you explore? (Optional)
The simplest alternative would be a bare
ActivityIndicatorwithstyle={[styles.flex1]}(no wrapping View), which is the most common pattern in workspace pages likeWorkspaceTaxesPage.tsx. However, this would lose thecomponentBGbackground and0.8opacity that the current implementation has, so the loading state would not be pixel-perfect identical. Using thefullScreenLoadingstyle on a wrapperViewpreserves the exact visual appearance as required by the issue.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.situchan commentedon Mar 11, 2026
👋
[-]Use valid loading indicator in `WorkspacesListPage.tsx`[/-][+][$125] Use valid loading indicator in `WorkspacesListPage.tsx`[/+]melvin-bot commentedon Mar 11, 2026
9 remaining items
[-][$125] Use valid loading indicator in `WorkspacesListPage.tsx`[/-][+][Due for payment 2026-03-30] [$125] Use valid loading indicator in `WorkspacesListPage.tsx`[/+]melvin-bot commentedon Mar 23, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 23, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.41-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-03-30. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 23, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)Julesssss commentedon Mar 24, 2026
Lets group payments here to make things simpler
melvin-bot commentedon Mar 30, 2026
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)