You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-03-19] Contact method - Blank page opens when deleting a contact method #85017
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
After deleting a contact method in staging (v9.3.36-0), a blank page is shown instead of redirecting back to the Contact Methods list. This works correctly in production.
What is the root cause of that problem?
PR #82510 ("fix: Screen Reader: Many Pages: There is no dialog role and title announced") introduced useDialogTitleFocus in Header.tsx. The web implementation of this hook (src/hooks/useDialogTitleFocus/index.ts) unconditionally calls useNavigation().
The deletion flow in ContactMethodDetailsPage.tsx uses useConfirmModal() to show a confirmation dialog. This modal is rendered by ModalProvider (src/components/Modal/Global/ModalContext.tsx), which sits aboveNavigationContainer in the component tree (App.tsx). The rendering chain is: ConfirmModalWrapper -> ConfirmModal -> ConfirmContent -> Header -> useDialogTitleFocus -> useNavigation().
Since the modal is rendered outside the NavigationContainer, useNavigation() throws a "Couldn't find a navigation object" error, crashing the component and producing a blank page. The deleteContactMethod action (which calls Navigation.goBack() in src/libs/actions/User.ts:283) never executes because the confirmation modal itself fails to render.
This same root cause explains the cluster of similar "blank page" deploy blockers: #84957 (clear cache), #84966 (delete expense), #84972 (disable approvals) — all involve actions that trigger useConfirmModal or Header rendering in contexts affected by this PR.
The staging build 9.3.36-0 was published on 2026-03-11 at 20:02 UTC. The revert of PR #82510 (#84967) was merged on 2026-03-12 at 02:03 UTC — after the staging tag was cut — so the revert is not included in the tested build.
What changes do you think we should make in order to solve the problem?
The revert PR #84967 has already been merged and should resolve this issue once included in the next staging build. No additional code changes are needed — a new staging deploy that includes the revert should fix this and the related blank-page deploy blockers.
If PR #82510 is to be re-landed in the future, useDialogTitleFocus needs to handle being rendered outside a NavigationContainer (e.g., guard the useNavigation() call or use useNavigation only when a navigation context is available via try/catch or a context check).
What alternative solutions did you explore? (Optional)
An alternative would be to wrap the useNavigation() call in useDialogTitleFocus with a try/catch or conditionally skip it when no navigation context exists (e.g., checking NavigationContainerRefContext). However, since the revert is already merged, deploying a new staging build is the simplest path forward.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
changed the title [-]Contact method - Blank page opens when deleting a contact method[/-][+][Due for payment 2026-03-19] Contact method - Blank page opens when deleting a contact method[/+]on Mar 12, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.36-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@amyevans The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Mar 12, 2026
Triggered auto assignment to @marcochavezf (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Mar 12, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Mar 12, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Mar 12, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
After deleting a contact method in staging (v9.3.36-0), a blank page is shown instead of redirecting back to the Contact Methods list. This works correctly in production.
What is the root cause of that problem?
PR #82510 ("fix: Screen Reader: Many Pages: There is no dialog role and title announced") introduced
useDialogTitleFocusinHeader.tsx. The web implementation of this hook (src/hooks/useDialogTitleFocus/index.ts) unconditionally callsuseNavigation().The deletion flow in
ContactMethodDetailsPage.tsxusesuseConfirmModal()to show a confirmation dialog. This modal is rendered byModalProvider(src/components/Modal/Global/ModalContext.tsx), which sits aboveNavigationContainerin the component tree (App.tsx). The rendering chain is:ConfirmModalWrapper->ConfirmModal->ConfirmContent->Header->useDialogTitleFocus->useNavigation().Since the modal is rendered outside the
NavigationContainer,useNavigation()throws a "Couldn't find a navigation object" error, crashing the component and producing a blank page. ThedeleteContactMethodaction (which callsNavigation.goBack()insrc/libs/actions/User.ts:283) never executes because the confirmation modal itself fails to render.This same root cause explains the cluster of similar "blank page" deploy blockers: #84957 (clear cache), #84966 (delete expense), #84972 (disable approvals) — all involve actions that trigger
useConfirmModalor Header rendering in contexts affected by this PR.The staging build
9.3.36-0was published on 2026-03-11 at 20:02 UTC. The revert of PR #82510 (#84967) was merged on 2026-03-12 at 02:03 UTC — after the staging tag was cut — so the revert is not included in the tested build.What changes do you think we should make in order to solve the problem?
The revert PR #84967 has already been merged and should resolve this issue once included in the next staging build. No additional code changes are needed — a new staging deploy that includes the revert should fix this and the related blank-page deploy blockers.
If PR #82510 is to be re-landed in the future,
useDialogTitleFocusneeds to handle being rendered outside aNavigationContainer(e.g., guard theuseNavigation()call or useuseNavigationonly when a navigation context is available viatry/catchor a context check).What alternative solutions did you explore? (Optional)
An alternative would be to wrap the
useNavigation()call inuseDialogTitleFocuswith a try/catch or conditionally skip it when no navigation context exists (e.g., checkingNavigationContainerRefContext). However, since the revert is already merged, deploying a new staging build is the simplest path forward.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.9 remaining items
melvin-bot commentedon Mar 12, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Mar 12, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Mar 12, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Mar 12, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
[-]Contact method - Blank page opens when deleting a contact method[/-][+][Due for payment 2026-03-19] Contact method - Blank page opens when deleting a contact method[/+]melvin-bot commentedon Mar 12, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 12, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.36-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-03-19. 🎊
melvin-bot commentedon Mar 12, 2026
@amyevans The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Mar 12, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)