Skip to content

[Due for payment 2026-03-19] Contact method - Blank page opens when deleting a contact method #85017

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.3.36-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-8437/folder/13176687/41236654/1244460423?sort=%2Bidentifier
Email or phone of affected tester (no customers): n/a
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Mac 15.4.1 Safari/Chrome
App Component: User Settings

Action Performed:

Precondition: The user has a secondary contact method

  1. Go to https://staging.new.expensify.com
  2. Navigate to account settings > Profile
  3. Click on "Contact Method"
  4. Click an existing or pending contact method
  5. Click the 3-dot menu
  6. Click Remove

Expected Result:

After deleting a contact method, the user is redirected to the Contact methods RHP

Actual Result:

Blank page opens when deleting a contact method

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7100472_1773266596162!console.rtf

Bug7100472_1773266596153.Recording__1771.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Mar 12, 2026
  2. melvin-bot commented on Mar 12, 2026

    @melvin-bot

    Triggered auto assignment to @marcochavezf (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Mar 12, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on Mar 12, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. MelvinBot commented on Mar 12, 2026

    @MelvinBot
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    After deleting a contact method in staging (v9.3.36-0), a blank page is shown instead of redirecting back to the Contact Methods list. This works correctly in production.

    What is the root cause of that problem?

    PR #82510 ("fix: Screen Reader: Many Pages: There is no dialog role and title announced") introduced useDialogTitleFocus in Header.tsx. The web implementation of this hook (src/hooks/useDialogTitleFocus/index.ts) unconditionally calls useNavigation().

    The deletion flow in ContactMethodDetailsPage.tsx uses useConfirmModal() to show a confirmation dialog. This modal is rendered by ModalProvider (src/components/Modal/Global/ModalContext.tsx), which sits above NavigationContainer in the component tree (App.tsx). The rendering chain is: ConfirmModalWrapper -> ConfirmModal -> ConfirmContent -> Header -> useDialogTitleFocus -> useNavigation().

    Since the modal is rendered outside the NavigationContainer, useNavigation() throws a "Couldn't find a navigation object" error, crashing the component and producing a blank page. The deleteContactMethod action (which calls Navigation.goBack() in src/libs/actions/User.ts:283) never executes because the confirmation modal itself fails to render.

    This same root cause explains the cluster of similar "blank page" deploy blockers: #84957 (clear cache), #84966 (delete expense), #84972 (disable approvals) — all involve actions that trigger useConfirmModal or Header rendering in contexts affected by this PR.

    The staging build 9.3.36-0 was published on 2026-03-11 at 20:02 UTC. The revert of PR #82510 (#84967) was merged on 2026-03-12 at 02:03 UTC — after the staging tag was cut — so the revert is not included in the tested build.

    What changes do you think we should make in order to solve the problem?

    The revert PR #84967 has already been merged and should resolve this issue once included in the next staging build. No additional code changes are needed — a new staging deploy that includes the revert should fix this and the related blank-page deploy blockers.

    If PR #82510 is to be re-landed in the future, useDialogTitleFocus needs to handle being rendered outside a NavigationContainer (e.g., guard the useNavigation() call or use useNavigation only when a navigation context is available via try/catch or a context check).

    What alternative solutions did you explore? (Optional)

    An alternative would be to wrap the useNavigation() call in useDialogTitleFocus with a try/catch or conditionally skip it when no navigation context exists (e.g., checking NavigationContainerRefContext). However, since the revert is already merged, deploying a new staging build is the simplest path forward.


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  6. 9 remaining items

  7. melvin-bot commented on Mar 12, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  8. melvin-bot commented on Mar 12, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  9. melvin-bot commented on Mar 12, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  10. melvin-bot commented on Mar 12, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  11. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 12, 2026
  12. changed the title [-]Contact method - Blank page opens when deleting a contact method[/-] [+][Due for payment 2026-03-19] Contact method - Blank page opens when deleting a contact method[/+] on Mar 12, 2026
  13. melvin-bot commented on Mar 12, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Mar 12, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.36-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-03-19. 🎊

  15. melvin-bot commented on Mar 12, 2026

    @melvin-bot

    @amyevans The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  16. melvin-bot commented on Mar 12, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions