You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Wallet - Partially setup bank account get deleted in Wallet pags after deleting workspace #85065
Version Number: v9.3.36-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:#84828 Email or phone of affected tester (no customers):kiatest.78+ck31126@gmail.com & applausetester+ck31126@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: Windows 11/Chrome, Pixel 8a/Android 16 App Component: User Settings
Action Performed:
Navigate to staging.new.expensify.com
Create a workspace
Go to workspace settings >> workflows >> Add bank account >> Create a partially added BA until name screen
Delete workspace
Go to Wallet page
Expected Result:
Bank account still shows up as partially setup in the wallet page
Actual Result:
Partially setup bank account get deleted in Wallet pags after deleting workspace
Please re-state the problem that we are trying to solve in this issue.
When a user creates a workspace, partially sets up a bank account (stops at the name screen), and then deletes the workspace, the partially-setup bank account disappears from the Wallet page. It should persist independently in the Wallet page regardless of whether the associated workspace still exists.
What is the root cause of that problem?
PR #84828 ("Fix deleteWorkspace optimistic update to handle policyIDs bank account association") removed the client-side optimistic handling of BANK_ACCOUNT_LIST from the deleteWorkspace function in src/libs/actions/Policy/Policy.ts. Previously, the client-side code filtered bank accounts out of BANK_ACCOUNT_LIST optimistically during workspace deletion. PR #84828 removed this because the backend was updated to no longer delete bank accounts on workspace deletion — it was supposed to only disassociate them (removing the policyID from additionalData).
However, the backend behavior appears to differ for partially-setup bank accounts (those in SETUP, VERIFYING, or PENDING states as defined in src/libs/BankAccountUtils.ts:14-16). When a workspace is deleted, the backend either:
Actually deletes the partially-setup bank account entirely (not just disassociating it), or
Disassociates the policyID, but then the OpenPaymentsPage API (called when the Wallet page mounts at src/pages/settings/Wallet/WalletPage/index.tsx:343-348 with includePartiallySetupBankAccounts=true) no longer returns the account because it filters partially-setup accounts by whether their linked policy still exists.
Either way, the partially-setup bank account vanishes from ONYXKEYS.BANK_ACCOUNT_LIST after workspace deletion, and since the Wallet page reads directly from that key (src/pages/settings/Wallet/WalletPage/index.tsx:63) with no client-side preservation logic, the account disappears from the UI.
The current deleteWorkspace function (src/libs/actions/Policy/Policy.ts:422-432) only touches ONYXKEYS.REIMBURSEMENT_ACCOUNT (the setup flow singleton) to clear errors — it does nothing to preserve bank account entries in BANK_ACCOUNT_LIST.
What changes do you think we should make in order to solve the problem?
The fix needs to happen on the backend side. When processing DeleteWorkspace, the backend should treat partially-setup bank accounts the same way it treats fully-setup ones — disassociate the policyID from additionalData but not delete the bank account. The OpenPaymentsPage API should continue returning partially-setup bank accounts even if their previously-linked policy has been deleted, since the bank account itself is still valid and belongs to the user.
If a backend-only fix isn't feasible, a frontend alternative would be to add optimistic data in deleteWorkspace (src/libs/actions/Policy/Policy.ts) that removes only the policyID association from the bank account's additionalData (and accountData.policyIDs array) rather than allowing the entire bank account entry to be removed. This would preserve the bank account in BANK_ACCOUNT_LIST client-side until the backend responds. Additionally, the Wallet page navigation logic (src/pages/settings/Wallet/WalletPage/index.tsx:173) should handle the case where additionalData.policyID points to a deleted workspace — it should allow the user to resume setup with a new workspace or navigate to a general bank account setup flow.
What alternative solutions did you explore? (Optional)
An alternative would be to re-introduce client-side filtering in deleteWorkspace that only removes the policyID from the bank account's additionalData (using Onyx.METHOD.MERGE) rather than removing the bank account entry entirely. This preserves the bank account in the Wallet while still cleaning up the workspace association. However, this only masks the issue if the backend is actually deleting the bank account — the root fix should ensure the backend preserves partially-setup bank accounts on workspace deletion.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
changed the title [-]Wallet - Partially setup bank account get deleted in Wallet pags after deleting workspace[/-][+][$250] Wallet - Partially setup bank account get deleted in Wallet pags after deleting workspace[/+]on Mar 12, 2026
Please re-state the problem that we are trying to solve in this issue.
When a user partially sets up a bank account through the workspace reimbursement flow and then deletes the workspace, the partially-setup bank account disappears from the Wallet page. The bank account should survive workspace deletion because it belongs to the user, not the workspace.
What is the root cause of that problem?
When DeleteWorkspace is executed, the server deletes the partially-setup bank account that was created in the context of that workspace. The server response then returns an updated bankAccountList without that entry, which Onyx merges — making the bank account vanish from the Wallet page. On the client side, the deleteWorkspace action in Policy.ts does not include any Onyx handling for BANK_ACCOUNT_LIST or REIMBURSEMENT_ACCOUNT that would preserve the partial setup state. The achData stored in REIMBURSEMENT_ACCOUNT (which holds the in-progress bank account data including policyID, bankAccountID, routing/account numbers, etc.) also gets orphaned since there is no cleanup when the associated workspace is deleted.
What changes do you think we should make in order to solve the problem?
The deleteWorkspace action needs to pass reimbursementAccount as a parameter (in addition to the existing reimbursementAccountError) and use its achData to determine if the in-progress bank account belongs to the workspace being deleted. If achData.policyID === policyID, the action should add REIMBURSEMENT_ACCOUNT to the optimistic data with DEFAULT_DATA (clearing the stale in-progress state), and also preserve the bankAccountList entry in successData so it survives the server response. The bankAccountList item should be kept with its policyIDs field cleared of the deleted policy ID rather than being removed entirely, which allows the user to continue setup from the Wallet page.
The DeleteWorkspaceActionParams type and the callers in WorkspaceOverviewPage.tsx and WorkspacesListPage.tsx need to supply the new bankAccountList and reimbursementAccount parameters.
type DeleteWorkspaceActionParams = {
policies: OnyxCollection<Policy>;
policyID: string;
personalPolicyID: string | undefined;
activePolicyID: string | undefined;
policyName: string;
lastAccessedWorkspacePolicyID: string | undefined;
policyCardFeeds: CardFeeds | undefined;
reportsToArchive: Report[];
transactionViolations: OnyxCollection<TransactionViolations> | undefined;
reimbursementAccountError: Errors | undefined;
+ reimbursementAccount: ReimbursementAccount | undefined;+ bankAccountList: BankAccountList | undefined;
lastUsedPaymentMethods?: LastPaymentMethod;
localeCompare: LocaleContextProps['localeCompare'];
};
function deleteWorkspace(params: DeleteWorkspaceActionParams) {
const {
policies,
policyID,
...
reimbursementAccountError,
+ reimbursementAccount,+ bankAccountList,
lastUsedPaymentMethods,
localeCompare,
personalPolicyID,
} = params;
+ // Find the partially-setup bank account associated with this workspace+ const partialBankAccountEntry = Object.entries(bankAccountList ?? {}).find(+ ([, account]) => account.accountData?.policyIDs?.includes(policyID),+ );+ const isReimbursementAccountForThisPolicy = reimbursementAccount?.achData?.policyID === policyID;
// existing optimisticData ...
+ // If a bank account was being set up for this workspace, clear the in-progress reimbursement account state+ if (isReimbursementAccountForThisPolicy) {+ optimisticData.push({+ onyxMethod: Onyx.METHOD.SET,+ key: ONYXKEYS.REIMBURSEMENT_ACCOUNT,+ value: CONST.REIMBURSEMENT_ACCOUNT.DEFAULT_DATA,+ });+ failureData.push({+ onyxMethod: Onyx.METHOD.MERGE,+ key: ONYXKEYS.REIMBURSEMENT_ACCOUNT,+ value: reimbursementAccount,+ });+ }+ // Preserve the partially-setup bank account in the wallet even if the server removes it,+ // but disassociate it from the deleted workspace so the user can continue setup independently+ if (partialBankAccountEntry) {+ const [bankAccountID, bankAccount] = partialBankAccountEntry;+ const remainingPolicyIDs = (bankAccount.accountData?.policyIDs ?? []).filter((id) => id !== policyID);+ successData.push({+ onyxMethod: Onyx.METHOD.MERGE,+ key: ONYXKEYS.BANK_ACCOUNT_LIST,+ value: {+ [bankAccountID]: {+ ...bankAccount,+ accountData: {+ ...bankAccount.accountData,+ policyIDs: remainingPolicyIDs,+ },+ },+ },+ });+ }
The callers in WorkspaceOverviewPage.tsx and WorkspacesListPage.tsx would also need to read reimbursementAccount and bankAccountList from Onyx and pass them through to deleteWorkspace.
What alternative solutions did you explore? (Optional)
An alternative would be a server-side fix to not delete the partially-setup bank account when its workspace is removed. This is the cleaner long-term solution, but a client-side approach using successData to restore the bank account entry is a reliable way to guarantee the correct behavior regardless of what the server returns.
Please re-state the problem that we are trying to solve in this issue.
When a user partially sets up a bank account for a workspace (stopping at the name screen, for example) and then deletes that workspace, the bank account vanishes from the Wallet page. It should still show up — the bank account belongs to the user regardless of whether the workspace exists.
What is the root cause of that problem?
This is a regression from PR #84828 (commit 0ee879221ce, merged ~2 days ago). That PR removed all client-side handling of BANK_ACCOUNT_LIST from the deleteWorkspace function in src/libs/actions/Policy/Policy.ts (lines 374-633). The reasoning was that the backend no longer deletes bank accounts on workspace deletion — it just disassociates them.
That assumption holds for fully-setup (OPEN) bank accounts, but breaks for partially-setup ones (SETUP/VERIFYING/PENDING states, as defined in BankAccountUtils.ts:14-16). After the backend processes the workspace deletion, partially-setup bank accounts disappear from ONYXKEYS.BANK_ACCOUNT_LIST. The Wallet page reads directly from that key (WalletPage/index.tsx:63), so the account is gone from the UI.
The old code used Onyx.METHOD.SET to replace the entire BANK_ACCOUNT_LIST, filtering out all associated accounts — which was also wrong because it removed them entirely. PR #84828 removed that, but didn't replace it with the correct behavior: disassociating the policyID while preserving the bank account.
What changes do you think we should make in order to solve the problem?
In deleteWorkspace (Policy.ts), add bankAccountList back as a parameter. Find bank accounts linked to the deleted policyID (via accountData.policyIDs array and accountData.additionalData.policyID), then add optimistic data using Onyx.METHOD.MERGE that removes the policyID from the policyIDs array and clears additionalData.policyID — but keeps the bank account entry itself. Add failure data to restore the original associations if the API call fails. The callers in WorkspacesListPage.tsx and WorkspaceOverviewPage.tsx need to re-add useOnyx(ONYXKEYS.BANK_ACCOUNT_LIST) and pass it through.
This follows the exact pattern already used in setWorkspaceReimbursement (Policy.ts:1098-1145), which does the same policyID removal from a bank account's policyIDs array via Onyx.METHOD.MERGE.
There's also a secondary issue in WalletPage/index.tsx:172 — onBankAccountRowPressed navigates using additionalData.policyID without checking if that workspace still exists. If there's stale data between the optimistic update and backend response, this could send the user to a non-existent workspace page. A quick guard using the already-available allPolicies (line 68) fixes this — if the workspace is gone, fall through to the bankAccountID-based navigation path at line 184.
What alternative solutions did you explore? (Optional)
A backend-only fix would be cleaner long-term, but contributors can't modify the backend, and it wouldn't handle the UI flash between deletion and server response anyway. Restoring the old Onyx.METHOD.SET approach that PR #84828 removed is also worse — it still removes bank accounts entirely rather than disassociating. The optimistic disassociation via MERGE is the middle ground that PR #84828 should have landed on.
I think this was expected because the backend PR needed for this change this was just deployed 5 minutes ago. I just tested on staging and it's now working. Closing as we're all set here 👍
@joekaufmanexpensify, unrelated question: How do I obtain the test credentials for adding a bank account? Is there any documentation? Appreciate any pointers
📣 @vigneshTheDev! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
Activity
MelvinBot commentedon Mar 12, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When a user creates a workspace, partially sets up a bank account (stops at the name screen), and then deletes the workspace, the partially-setup bank account disappears from the Wallet page. It should persist independently in the Wallet page regardless of whether the associated workspace still exists.
What is the root cause of that problem?
PR #84828 ("Fix deleteWorkspace optimistic update to handle policyIDs bank account association") removed the client-side optimistic handling of
BANK_ACCOUNT_LISTfrom thedeleteWorkspacefunction insrc/libs/actions/Policy/Policy.ts. Previously, the client-side code filtered bank accounts out ofBANK_ACCOUNT_LISToptimistically during workspace deletion. PR #84828 removed this because the backend was updated to no longer delete bank accounts on workspace deletion — it was supposed to only disassociate them (removing thepolicyIDfromadditionalData).However, the backend behavior appears to differ for partially-setup bank accounts (those in
SETUP,VERIFYING, orPENDINGstates as defined insrc/libs/BankAccountUtils.ts:14-16). When a workspace is deleted, the backend either:policyID, but then theOpenPaymentsPageAPI (called when the Wallet page mounts atsrc/pages/settings/Wallet/WalletPage/index.tsx:343-348withincludePartiallySetupBankAccounts=true) no longer returns the account because it filters partially-setup accounts by whether their linked policy still exists.Either way, the partially-setup bank account vanishes from
ONYXKEYS.BANK_ACCOUNT_LISTafter workspace deletion, and since the Wallet page reads directly from that key (src/pages/settings/Wallet/WalletPage/index.tsx:63) with no client-side preservation logic, the account disappears from the UI.The current
deleteWorkspacefunction (src/libs/actions/Policy/Policy.ts:422-432) only touchesONYXKEYS.REIMBURSEMENT_ACCOUNT(the setup flow singleton) to clear errors — it does nothing to preserve bank account entries inBANK_ACCOUNT_LIST.What changes do you think we should make in order to solve the problem?
The fix needs to happen on the backend side. When processing
DeleteWorkspace, the backend should treat partially-setup bank accounts the same way it treats fully-setup ones — disassociate thepolicyIDfromadditionalDatabut not delete the bank account. TheOpenPaymentsPageAPI should continue returning partially-setup bank accounts even if their previously-linked policy has been deleted, since the bank account itself is still valid and belongs to the user.If a backend-only fix isn't feasible, a frontend alternative would be to add optimistic data in
deleteWorkspace(src/libs/actions/Policy/Policy.ts) that removes only thepolicyIDassociation from the bank account'sadditionalData(andaccountData.policyIDsarray) rather than allowing the entire bank account entry to be removed. This would preserve the bank account inBANK_ACCOUNT_LISTclient-side until the backend responds. Additionally, the Wallet page navigation logic (src/pages/settings/Wallet/WalletPage/index.tsx:173) should handle the case whereadditionalData.policyIDpoints to a deleted workspace — it should allow the user to resume setup with a new workspace or navigate to a general bank account setup flow.What alternative solutions did you explore? (Optional)
An alternative would be to re-introduce client-side filtering in
deleteWorkspacethat only removes thepolicyIDfrom the bank account'sadditionalData(usingOnyx.METHOD.MERGE) rather than removing the bank account entry entirely. This preserves the bank account in the Wallet while still cleaning up the workspace association. However, this only masks the issue if the backend is actually deleting the bank account — the root fix should ensure the backend preserves partially-setup bank accounts on workspace deletion.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.melvin-bot commentedon Mar 12, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (
External)[-]Wallet - Partially setup bank account get deleted in Wallet pags after deleting workspace[/-][+][$250] Wallet - Partially setup bank account get deleted in Wallet pags after deleting workspace[/+]melvin-bot commentedon Mar 12, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022032067354024274155
MobileMage commentedon Mar 12, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When a user partially sets up a bank account through the workspace reimbursement flow and then deletes the workspace, the partially-setup bank account disappears from the Wallet page. The bank account should survive workspace deletion because it belongs to the user, not the workspace.
What is the root cause of that problem?
When
DeleteWorkspaceis executed, the server deletes the partially-setup bank account that was created in the context of that workspace. The server response then returns an updatedbankAccountListwithout that entry, which Onyx merges — making the bank account vanish from the Wallet page. On the client side, thedeleteWorkspaceaction inPolicy.tsdoes not include any Onyx handling forBANK_ACCOUNT_LISTorREIMBURSEMENT_ACCOUNTthat would preserve the partial setup state. TheachDatastored inREIMBURSEMENT_ACCOUNT(which holds the in-progress bank account data includingpolicyID,bankAccountID, routing/account numbers, etc.) also gets orphaned since there is no cleanup when the associated workspace is deleted.App/src/libs/actions/Policy/Policy.ts
Lines 394 to 432 in d49f9b0
What changes do you think we should make in order to solve the problem?
The
deleteWorkspaceaction needs to passreimbursementAccountas a parameter (in addition to the existingreimbursementAccountError) and use itsachDatato determine if the in-progress bank account belongs to the workspace being deleted. IfachData.policyID === policyID, the action should addREIMBURSEMENT_ACCOUNTto the optimistic data withDEFAULT_DATA(clearing the stale in-progress state), and also preserve thebankAccountListentry insuccessDataso it survives the server response. ThebankAccountListitem should be kept with itspolicyIDsfield cleared of the deleted policy ID rather than being removed entirely, which allows the user to continue setup from the Wallet page.The
DeleteWorkspaceActionParamstype and the callers inWorkspaceOverviewPage.tsxandWorkspacesListPage.tsxneed to supply the newbankAccountListandreimbursementAccountparameters.type DeleteWorkspaceActionParams = { policies: OnyxCollection<Policy>; policyID: string; personalPolicyID: string | undefined; activePolicyID: string | undefined; policyName: string; lastAccessedWorkspacePolicyID: string | undefined; policyCardFeeds: CardFeeds | undefined; reportsToArchive: Report[]; transactionViolations: OnyxCollection<TransactionViolations> | undefined; reimbursementAccountError: Errors | undefined; + reimbursementAccount: ReimbursementAccount | undefined; + bankAccountList: BankAccountList | undefined; lastUsedPaymentMethods?: LastPaymentMethod; localeCompare: LocaleContextProps['localeCompare']; }; function deleteWorkspace(params: DeleteWorkspaceActionParams) { const { policies, policyID, ... reimbursementAccountError, + reimbursementAccount, + bankAccountList, lastUsedPaymentMethods, localeCompare, personalPolicyID, } = params; + // Find the partially-setup bank account associated with this workspace + const partialBankAccountEntry = Object.entries(bankAccountList ?? {}).find( + ([, account]) => account.accountData?.policyIDs?.includes(policyID), + ); + const isReimbursementAccountForThisPolicy = reimbursementAccount?.achData?.policyID === policyID; // existing optimisticData ... + // If a bank account was being set up for this workspace, clear the in-progress reimbursement account state + if (isReimbursementAccountForThisPolicy) { + optimisticData.push({ + onyxMethod: Onyx.METHOD.SET, + key: ONYXKEYS.REIMBURSEMENT_ACCOUNT, + value: CONST.REIMBURSEMENT_ACCOUNT.DEFAULT_DATA, + }); + failureData.push({ + onyxMethod: Onyx.METHOD.MERGE, + key: ONYXKEYS.REIMBURSEMENT_ACCOUNT, + value: reimbursementAccount, + }); + } + // Preserve the partially-setup bank account in the wallet even if the server removes it, + // but disassociate it from the deleted workspace so the user can continue setup independently + if (partialBankAccountEntry) { + const [bankAccountID, bankAccount] = partialBankAccountEntry; + const remainingPolicyIDs = (bankAccount.accountData?.policyIDs ?? []).filter((id) => id !== policyID); + successData.push({ + onyxMethod: Onyx.METHOD.MERGE, + key: ONYXKEYS.BANK_ACCOUNT_LIST, + value: { + [bankAccountID]: { + ...bankAccount, + accountData: { + ...bankAccount.accountData, + policyIDs: remainingPolicyIDs, + }, + }, + }, + }); + }The callers in
WorkspaceOverviewPage.tsxandWorkspacesListPage.tsxwould also need to readreimbursementAccountandbankAccountListfrom Onyx and pass them through todeleteWorkspace.App/src/pages/workspace/WorkspaceOverviewPage.tsx
Lines 250 to 263 in d49f9b0
What alternative solutions did you explore? (Optional)
An alternative would be a server-side fix to not delete the partially-setup bank account when its workspace is removed. This is the cleaner long-term solution, but a client-side approach using
successDatato restore the bank account entry is a reliable way to guarantee the correct behavior regardless of what the server returns.shivang-goliyan commentedon Mar 12, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When a user partially sets up a bank account for a workspace (stopping at the name screen, for example) and then deletes that workspace, the bank account vanishes from the Wallet page. It should still show up — the bank account belongs to the user regardless of whether the workspace exists.
What is the root cause of that problem?
This is a regression from PR #84828 (commit
0ee879221ce, merged ~2 days ago). That PR removed all client-side handling ofBANK_ACCOUNT_LISTfrom thedeleteWorkspacefunction insrc/libs/actions/Policy/Policy.ts(lines 374-633). The reasoning was that the backend no longer deletes bank accounts on workspace deletion — it just disassociates them.That assumption holds for fully-setup (OPEN) bank accounts, but breaks for partially-setup ones (SETUP/VERIFYING/PENDING states, as defined in
BankAccountUtils.ts:14-16). After the backend processes the workspace deletion, partially-setup bank accounts disappear fromONYXKEYS.BANK_ACCOUNT_LIST. The Wallet page reads directly from that key (WalletPage/index.tsx:63), so the account is gone from the UI.The old code used
Onyx.METHOD.SETto replace the entireBANK_ACCOUNT_LIST, filtering out all associated accounts — which was also wrong because it removed them entirely. PR #84828 removed that, but didn't replace it with the correct behavior: disassociating the policyID while preserving the bank account.What changes do you think we should make in order to solve the problem?
In
deleteWorkspace(Policy.ts), addbankAccountListback as a parameter. Find bank accounts linked to the deleted policyID (viaaccountData.policyIDsarray andaccountData.additionalData.policyID), then add optimistic data usingOnyx.METHOD.MERGEthat removes the policyID from thepolicyIDsarray and clearsadditionalData.policyID— but keeps the bank account entry itself. Add failure data to restore the original associations if the API call fails. The callers inWorkspacesListPage.tsxandWorkspaceOverviewPage.tsxneed to re-adduseOnyx(ONYXKEYS.BANK_ACCOUNT_LIST)and pass it through.This follows the exact pattern already used in
setWorkspaceReimbursement(Policy.ts:1098-1145), which does the same policyID removal from a bank account'spolicyIDsarray viaOnyx.METHOD.MERGE.There's also a secondary issue in
WalletPage/index.tsx:172—onBankAccountRowPressednavigates usingadditionalData.policyIDwithout checking if that workspace still exists. If there's stale data between the optimistic update and backend response, this could send the user to a non-existent workspace page. A quick guard using the already-availableallPolicies(line 68) fixes this — if the workspace is gone, fall through to thebankAccountID-based navigation path at line 184.What alternative solutions did you explore? (Optional)
A backend-only fix would be cleaner long-term, but contributors can't modify the backend, and it wouldn't handle the UI flash between deletion and server response anyway. Restoring the old
Onyx.METHOD.SETapproach that PR #84828 removed is also worse — it still removes bank accounts entirely rather than disassociating. The optimistic disassociation viaMERGEis the middle ground that PR #84828 should have landed on.joekaufmanexpensify commentedon Mar 12, 2026
I think this was expected because the backend PR needed for this change this was just deployed 5 minutes ago. I just tested on staging and it's now working. Closing as we're all set here 👍
vigneshTheDev commentedon Mar 12, 2026
@joekaufmanexpensify, unrelated question: How do I obtain the test credentials for adding a bank account? Is there any documentation? Appreciate any pointers
melvin-bot commentedon Mar 12, 2026
📣 @vigneshTheDev! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format: