You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-03-24] Onboarding - Test Drive modal appears when selecting "Manage my team's..." option #85162
Version Number: v9.3.37-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#83750 Email or phone of affected tester (no customers): n/a Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: Mac 15.4.1 Safari/Chrome App Component: Other
The TestDrive modal does not appear after onboarding.
User lands on the Home page and the Concierge RHP should not be opened.
Actual Result:
The TestDrive modal appear after onboarding when selecting "Manage my team's expenses" option .
User lands on the Workspace Overview page and the Concierge RHP is opened.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #83750 - "Remove TestDrive from sign-up flow" by @abbasifaizan70 (High confidence) Related Issues: None
Recommendation: ROLL FORWARD
PR #83750 incompletely removed the TestDrive modal flow. While it removed the TestDriveModalGuard and updated most onboarding pages, it missed the RHPVariantTest component that still navigates to the TestDrive modal for users in the RHP (Right Hand Panel) experiment.
A quick fix is needed to update /src/components/SidePanel/RHPVariantTest/index.ts line 51 to navigate to ROUTES.TEST_DRIVE_DEMO_ROOT instead of ROUTES.TEST_DRIVE_MODAL_ROOT.route. Rolling forward is preferable to reverting because:
The PR made extensive changes across many files
A simple one-line fix can resolve the issue
Reverting would bring back the entire TestDrive modal infrastructure that was intentionally removed
Labels: No label changes made (both DeployBlockerCash and DeployBlocker remain as this is a frontend bug reproducible only on staging)
📋 Detailed Analysis
Evidence
PR #83750 removed the TestDrive modal from the onboarding flow by:
Deleting TestDriveModalGuard.ts (the navigation guard)
Removing testDriveModalDismissed flag setting from onboarding completion
Updating all onboarding pages to remove the shouldSkipTestDriveModal parameter
Changing Tour.ts to always navigate to TEST_DRIVE_DEMO_ROOT
However, the PR did NOT update the RHPVariantTest component, which was introduced in PR #79122 (merged 2026-01-13). This component handles a special navigation flow for micro companies in an A/B test.
changed the title [-]Onboarding - Test Drive modal appears when selecting "Manage my team's..." option[/-][+][Due for payment 2026-03-24] Onboarding - Test Drive modal appears when selecting "Manage my team's..." option[/+]on Mar 17, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.38-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@Valforte The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Mar 13, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #83750
melvin-bot commentedon Mar 13, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Mar 13, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
mitarachim commentedon Mar 13, 2026
Issue partially reproduce In Production.
TestDrive modal appear and User lands on the Home page and the Concierge RHP is opened.
Recording.1787.mp4
OSBotify commentedon Mar 13, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #83750 - "Remove TestDrive from sign-up flow" by @abbasifaizan70 (High confidence)
Related Issues: None
Recommendation: ROLL FORWARD
PR #83750 incompletely removed the TestDrive modal flow. While it removed the
TestDriveModalGuardand updated most onboarding pages, it missed theRHPVariantTestcomponent that still navigates to the TestDrive modal for users in the RHP (Right Hand Panel) experiment.A quick fix is needed to update
/src/components/SidePanel/RHPVariantTest/index.tsline 51 to navigate toROUTES.TEST_DRIVE_DEMO_ROOTinstead ofROUTES.TEST_DRIVE_MODAL_ROOT.route. Rolling forward is preferable to reverting because:Labels: No label changes made (both DeployBlockerCash and DeployBlocker remain as this is a frontend bug reproducible only on staging)
📋 Detailed Analysis
Evidence
PR #83750 removed the TestDrive modal from the onboarding flow by:
TestDriveModalGuard.ts(the navigation guard)testDriveModalDismissedflag setting from onboarding completionshouldSkipTestDriveModalparameterTour.tsto always navigate toTEST_DRIVE_DEMO_ROOTHowever, the PR did NOT update the RHPVariantTest component, which was introduced in PR #79122 (merged 2026-01-13). This component handles a special navigation flow for micro companies in an A/B test.
Verification
Affected file:
/src/components/SidePanel/RHPVariantTest/index.tsNavigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT.route);shouldOpenRHPVariant()returns true (line 56 ofnavigateAfterOnboarding.ts)The RHPVariantTest file was NOT modified by PR #83750, as confirmed by checking the PR file list.
Root Cause
When users select "Manage my team's expenses" during onboarding:
shouldOpenRHPVariant()returns truehandleRHPVariantNavigation()is called (line 57 of navigateAfterOnboarding.ts)Proposed Fix
Update line 51 in
/src/components/SidePanel/RHPVariantTest/index.ts:Or alternatively, remove the entire navigation call on line 50-52 if opening the side panel is sufficient for the RHP variant.
6 remaining items
m-natarajan commentedon Mar 13, 2026
User lands in Home but redirected to workspace overview and concierge RHP open, Test drive modal not displayed.
Win 11/Chrome, v9.3.37-8
Recording.2533.mp4
Recording.2532.mp4
Valforte commentedon Mar 13, 2026
That confirms the fix, 1-10 size company are in testing a different landing flow, landing in the Workspace page with the Concierge RHP open
[-]Onboarding - Test Drive modal appears when selecting "Manage my team's..." option[/-][+][Due for payment 2026-03-24] Onboarding - Test Drive modal appears when selecting "Manage my team's..." option[/+]melvin-bot commentedon Mar 17, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 17, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.38-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-03-24. 🎊
melvin-bot commentedon Mar 17, 2026
@Valforte The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Mar 17, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)