You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Camera jank caused by unnecessary Onyx re-renders on the scan screen #85583
When using the scan screen, ~15 Onyx keys are subscribed to on every mount regardless of which scan flow is active. Global Onyx events like new chat messages or report updates trigger re-renders while the camera is active, causing camera jank for the most common scan paths (from report, edit receipt, global create).
Solution
Decompose the monolithic scan screen into 4 focused components (ScanEditReceipt, ScanFromReport, ScanGlobalCreate, ScanSkipConfirmation), each subscribing only to the Onyx data it actually needs.
The three most common paths drop from ~15 subscriptions to 3-4
Global Onyx events no longer trigger re-renders in the camera for those flows
The skip-confirmation path keeps its subscriptions but no longer penalizes everyone else
@rinej is finishing up the blueprint PR and keeping it up to date. we'll wrap up measurements and provide a plan for splitting it down into smaller PRs soon.
Activity
melvin-bot commentedon Mar 20, 2026
@adhorodyski Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Mar 20, 2026
@adhorodyski Whoops! This issue is 2 days overdue. Let's get this updated quick!
marcaaron commentedon Mar 21, 2026
These are being worked on
melvin-bot commentedon Mar 24, 2026
@adhorodyski Still overdue 6 days?! Let's take care of this!
marcaaron commentedon Mar 25, 2026
PR is in progress: #85571
adhorodyski commentedon Mar 25, 2026
yess thank you for updating
adhorodyski commentedon Mar 27, 2026
@rinej is finishing up the blueprint PR and keeping it up to date. we'll wrap up measurements and provide a plan for splitting it down into smaller PRs soon.
melvin-bot commentedon Mar 30, 2026
@adhorodyski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
52 remaining items
cristipaval commentedon May 4, 2026
Making this Weekly since we now work on subissues
rinej commentedon May 4, 2026
Thanks for splitting it, it will make our life much easier! I will share the PRs for next steps soon
cristipaval commentedon May 14, 2026
Update
PR for the 3rd step from the decomposition plan is in review
cristipaval commentedon May 25, 2026
The 3rd PR from the decomposition plan is close to getting merged
rinej commentedon Jun 2, 2026
Also we merged the last one with the cleanup -> #91855
cristipaval commentedon Jun 11, 2026
@rinej could you please look into #89386?
cristipaval commentedon Jun 17, 2026
All good here