You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-04-01] [Due for payment 2026-03-30] Tax - Tax field is blank when expense is created offline #85730
Version Number: 9.3.40-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#78472 Email or phone of affected tester (no customers):sdnodisjosijdoisj@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Enable Taxes in workspace.
Go to staging.new.expensify.com
Go to workspace chat.
Go offline.
Create an expense with any tax rate.
Open the expense.
Expected Result:
Tax field will show the selected rate.
Actual Result:
Tax field is blank when expense is created offline.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
When an expense is created offline with a tax rate, opening the expense shows the Tax field as blank instead of displaying the selected tax rate.
What is the root cause of that problem?
PR #78472 introduced a hasTaxValueChanged check in MoneyRequestView.tsx that doesn't account for offline-created transactions.
When an expense is created offline, buildOptimisticTransaction() (src/libs/TransactionUtils/index.ts:535-564) sets taxCode and taxAmount but does not set taxName or taxValue (the percentage string like "20%") — those are only populated when the server responds.
The new display logic at src/components/ReportActionItem/MoneyRequestView.tsx:311-317,601 does:
Destructures {taxCode, taxValue} from the transaction — taxCode is set, but taxValue is undefined
Computes hasTaxValueChanged = getTaxValue(policy, ..., taxCode) !== baseTransaction?.taxValue — this evaluates to "20%" !== undefined = true
Uses taxRateValue = hasTaxValueChanged ? taxValue : (...) — since hasTaxValueChanged is true, it uses taxValue which is undefined
The tax field renders blank
Before PR #78472, the code simply called getTaxName() to look up the display name from the policy, which worked correctly for offline transactions since the policy data is persisted locally.
What changes do you think we should make in order to solve the problem?
In src/components/ReportActionItem/MoneyRequestView.tsx, the hasTaxValueChanged computation should guard against baseTransaction?.taxValue being undefined. When taxValue is undefined (as with offline-created transactions), hasTaxValueChanged should be false so the code falls through to the normal display path that uses getTaxName().
Change the condition to: only consider the tax value as "changed" when both getTaxValue() returns a value AND baseTransaction?.taxValue is defined. Something like:
This ensures that offline-created transactions (where taxValue is undefined) skip the "changed" path and fall through to getTaxName() which correctly looks up the tax rate name from the locally-persisted policy data.
What alternative solutions did you explore? (Optional)
An alternative would be to include taxValue (the percentage string) in the optimistic transaction built by buildOptimisticTransaction(). However, this would require threading the tax value string through all callers and is a larger change. The guard on hasTaxValueChanged is more targeted and directly addresses the regression.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
changed the title [-]Tax - Tax field is blank when expense is created offline[/-][+][Due for payment 2026-03-30] Tax - Tax field is blank when expense is created offline[/+]on Mar 23, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.41-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@huult / @thesahindia The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
changed the title [-][Due for payment 2026-03-30] Tax - Tax field is blank when expense is created offline[/-][+][Due for payment 2026-04-01] [Due for payment 2026-03-30] Tax - Tax field is blank when expense is created offline[/+]on Mar 25, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.43-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@huult / @thesahindia@mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Mar 19, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #78472
melvin-bot commentedon Mar 19, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Mar 19, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Mar 19, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When an expense is created offline with a tax rate, opening the expense shows the Tax field as blank instead of displaying the selected tax rate.
What is the root cause of that problem?
PR #78472 introduced a
hasTaxValueChangedcheck inMoneyRequestView.tsxthat doesn't account for offline-created transactions.When an expense is created offline,
buildOptimisticTransaction()(src/libs/TransactionUtils/index.ts:535-564) setstaxCodeandtaxAmountbut does not settaxNameortaxValue(the percentage string like "20%") — those are only populated when the server responds.The new display logic at
src/components/ReportActionItem/MoneyRequestView.tsx:311-317,601does:{taxCode, taxValue}from the transaction —taxCodeis set, buttaxValueisundefinedhasTaxValueChanged = getTaxValue(policy, ..., taxCode) !== baseTransaction?.taxValue— this evaluates to"20%" !== undefined= truetaxRateValue = hasTaxValueChanged ? taxValue : (...)— sincehasTaxValueChangedis true, it usestaxValuewhich isundefinedBefore PR #78472, the code simply called
getTaxName()to look up the display name from the policy, which worked correctly for offline transactions since the policy data is persisted locally.What changes do you think we should make in order to solve the problem?
In
src/components/ReportActionItem/MoneyRequestView.tsx, thehasTaxValueChangedcomputation should guard againstbaseTransaction?.taxValuebeing undefined. WhentaxValueis undefined (as with offline-created transactions),hasTaxValueChangedshould befalseso the code falls through to the normal display path that usesgetTaxName().Change the condition to: only consider the tax value as "changed" when both
getTaxValue()returns a value ANDbaseTransaction?.taxValueis defined. Something like:This ensures that offline-created transactions (where
taxValueis undefined) skip the "changed" path and fall through togetTaxName()which correctly looks up the tax rate name from the locally-persisted policy data.What alternative solutions did you explore? (Optional)
An alternative would be to include
taxValue(the percentage string) in the optimistic transaction built bybuildOptimisticTransaction(). However, this would require threading the tax value string through all callers and is a larger change. The guard onhasTaxValueChangedis more targeted and directly addresses the regression.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.7 remaining items
[-]Tax - Tax field is blank when expense is created offline[/-][+][Due for payment 2026-03-30] Tax - Tax field is blank when expense is created offline[/+]melvin-bot commentedon Mar 23, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 23, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.41-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-03-30. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 23, 2026
@huult / @thesahindia The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Mar 23, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)[-][Due for payment 2026-03-30] Tax - Tax field is blank when expense is created offline[/-][+][Due for payment 2026-04-01] [Due for payment 2026-03-30] Tax - Tax field is blank when expense is created offline[/+]melvin-bot commentedon Mar 25, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.43-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-04-01. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 25, 2026
@huult / @thesahindia @mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]