You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] [Due for payment 2026-04-30] Expense - Not here page opens after moving IOU report to workspace #85753
Version Number: 9.3.40-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#85192 Email or phone of affected tester (no customers):sosjodijsodjoisjidojs@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Have at least one workspace.
User has received IOU expense from another user.
Go to staging.new.expensify.com
Open 1:1 DM where IOU expense is received.
Open the expense.
Click More > Change workspace.
Select workspace.
Close the RHP.
Expected Result:
Central pane will change to 1:1 DM after moving IOU report to workspace.
Actual Result:
Central pane opens not here page after moving IOU report to workspace.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #85192 - "feat: deep link to report preview or message that caused GBR/RBR" by @aimane-chnaif (High confidence) Related Issues: None
Recommendation: REVERT
PR #85192 should be reverted. This PR introduced deep linking to specific report actions when clicking LHN rows, which is causing navigation issues when moving IOU reports to workspaces.
Labels: Keeping DeployBlockerCash (this blocks the App deploy as it is a frontend bug affecting navigation)
📋 Detailed Analysis
Evidence
PR #85192 was merged on 2026-03-18 and introduced the ability to deep link to specific report actions from the LHN. The issue is reproducible on staging but NOT on production, which aligns with the PR having a production gate (isProduction check on line 76 of SidebarLinks.tsx that disables the feature in production).
The PR adds an actionTargetReportActionID parameter to navigation when clicking LHN rows, which changes the navigation behavior.
Simultaneously, moveIOUReportToPolicy changes the IOU report's chatReportID from the DM to the workspace expense chat (line 6211 of Report/index.ts)
The navigation attempts to return to the previous context, but the report has been moved to a different chat
This results in a "Not here" (FullPageNotFoundView) page being displayed
The PR #85192 introduced changes to the navigation flow that don't properly handle the case where a report's parent chat changes during the navigation sequence. The actionTargetReportActionID parameter adds complexity to the navigation that breaks when the underlying report structure changes.
Why it works in production but not staging: The PR author intentionally gated this feature with isProduction ? undefined : option.actionTargetReportActionID to prevent issues in production, which is why the bug only manifests on staging.
Please re-state the problem that we are trying to solve in this issue.
After moving an IOU expense to a workspace via "More > Change workspace" in a 1:1 DM, the central pane shows a "not here" page instead of the 1:1 DM. This only reproduces on staging, not production.
What is the root cause of that problem?
PR #85192 introduced a staging-only deep-link feature (gated by isProduction in SidebarLinks.tsx:76) that includes an actionTargetReportActionID in the navigation URL when clicking an LHN row with a GBR/RBR badge. On staging, clicking the 1:1 DM in the LHN navigates to r/{dmReportID}/{reportPreviewActionID} — deep-linking to the REPORT_PREVIEW action that has the outstanding IOU.
When the user then changes the IOU's workspace, convertIOUReportToExpenseReport optimistically removes the REPORT_PREVIEW action from the DM by setting it to null via Onyx.METHOD.MERGE:
The central pane URL still has the stale reportActionIDFromRoute. In ReportScreen, the cleanup logic at lines 897-914 only handles the case where linkedAction exists but is marked as deleted (isLinkedActionDeleted = true). When the action is completely removed from Onyx (linkedAction becomes null), isLinkedActionDeleted returns false (line 467: if (!linkedAction) return false), so the stale reportActionIDFromRoute is never cleared. The stale reportActionIDFromRoute causes ReportScreen to show the "not here" page via the shouldShowNotFoundLinkedAction check at lines 497-504.
This only happens on staging because in production, isProduction is true, and actionTargetReportActionID is passed as undefined to the navigation route — so reportActionIDFromRoute is never set, and there's nothing to go stale.
What changes do you think we should make in order to solve the problem?
In ReportScreen.tsx, the useEffect at lines 897-914 should also handle the case where linkedAction is null but reportActionIDFromRoute is still set. When the action has been completely removed from Onyx (not just marked as deleted), the stale reportActionIDFromRoute should be cleared by calling Navigation.setParams({reportActionID: ''}).
Specifically, add a condition: if !linkedAction && !!reportActionIDFromRoute && !reportMetadata?.isLoadingInitialReportActions, clear the route params. This ensures the central pane falls back to rendering the DM normally when the deep-linked action no longer exists.
What alternative solutions did you explore? (Optional)
Clear the route params in ReportChangeWorkspacePage.selectPolicy — when the workspace change is triggered, proactively clear the reportActionID from the navigation route. This is less robust since other operations could also remove the linked action.
Make isLinkedActionDeleted return true when linkedAction is null and reportActionIDFromRoute is set — this would let the existing cleanup logic handle the case. However, changing this semantic could have unintended side effects elsewhere.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot to refine this analysis, or explain why you are rejecting Melvin's proposal.
changed the title [-][Due for payment 2026-04-30] Expense - Not here page opens after moving IOU report to workspace[/-][+][$250] [Due for payment 2026-04-30] Expense - Not here page opens after moving IOU report to workspace[/+]on May 1, 2026
@aimane-chnaif this looks like it was a regression from your PR here
and the issue was created during the regression period. So this shouldn't be due payment, correct?
If so, I'll need to get a refund, I paid you before reviewing here.
Activity
melvin-bot commentedon Mar 19, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #85192
melvin-bot commentedon Mar 19, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Mar 19, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Mar 19, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #85192 - "feat: deep link to report preview or message that caused GBR/RBR" by @aimane-chnaif (High confidence)
Related Issues: None
Recommendation: REVERT
PR #85192 should be reverted. This PR introduced deep linking to specific report actions when clicking LHN rows, which is causing navigation issues when moving IOU reports to workspaces.
Labels: Keeping
DeployBlockerCash(this blocks the App deploy as it is a frontend bug affecting navigation)📋 Detailed Analysis
Evidence
PR #85192 was merged on 2026-03-18 and introduced the ability to deep link to specific report actions from the LHN. The issue is reproducible on staging but NOT on production, which aligns with the PR having a production gate (
isProductioncheck on line 76 of SidebarLinks.tsx that disables the feature in production).The PR adds an
actionTargetReportActionIDparameter to navigation when clicking LHN rows, which changes the navigation behavior.Verification
Files affected by the bug:
/home/runner/_work/App/App/src/pages/ReportChangeWorkspacePage.tsx- Handles workspace change flow/home/runner/_work/App/App/src/pages/inbox/sidebar/SidebarLinks.tsx- Modified by PR feat: deep link to report preview or message that caused GBR/RBR #85192 to add deep linkingConfirmed PR #85192 modifies these areas:
src/pages/inbox/sidebar/SidebarLinks.tsx(addsactionTargetReportActionIDto navigation)src/libs/ReportUtils.ts(addsactionTargetReportActionIDto OptionData type)src/libs/SidebarUtils.ts(propagatesactionTargetReportActionID)src/components/LHNOptionsList/OptionRowLHNData.tsx(consumesactionTargetReportActionID)Root Cause
When a user moves an IOU report from a 1:1 DM to a workspace:
ReportChangeWorkspacePage.tsxcallsNavigation.goBack(backTo)(line 89)moveIOUReportToPolicychanges the IOU report'schatReportIDfrom the DM to the workspace expense chat (line 6211 ofReport/index.ts)The PR #85192 introduced changes to the navigation flow that don't properly handle the case where a report's parent chat changes during the navigation sequence. The
actionTargetReportActionIDparameter adds complexity to the navigation that breaks when the underlying report structure changes.Why it works in production but not staging: The PR author intentionally gated this feature with
isProduction ? undefined : option.actionTargetReportActionIDto prevent issues in production, which is why the bug only manifests on staging.aimane-chnaif commentedon Mar 19, 2026
The feature is only available in staging. We can demote this
cristipaval commentedon Mar 19, 2026
what do you mean by this, @aimane-chnaif ? Is it behind a beta?
aimane-chnaif commentedon Mar 19, 2026
prevents deep link on production
App/src/pages/inbox/sidebar/SidebarLinks.tsx
Line 76 in ced001b
MelvinBot commentedon Mar 19, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
After moving an IOU expense to a workspace via "More > Change workspace" in a 1:1 DM, the central pane shows a "not here" page instead of the 1:1 DM. This only reproduces on staging, not production.
What is the root cause of that problem?
PR #85192 introduced a staging-only deep-link feature (gated by
isProductioninSidebarLinks.tsx:76) that includes anactionTargetReportActionIDin the navigation URL when clicking an LHN row with a GBR/RBR badge. On staging, clicking the 1:1 DM in the LHN navigates tor/{dmReportID}/{reportPreviewActionID}— deep-linking to the REPORT_PREVIEW action that has the outstanding IOU.When the user then changes the IOU's workspace,
convertIOUReportToExpenseReportoptimistically removes the REPORT_PREVIEW action from the DM by setting it tonullviaOnyx.METHOD.MERGE:The central pane URL still has the stale
reportActionIDFromRoute. In ReportScreen, the cleanup logic at lines 897-914 only handles the case wherelinkedActionexists but is marked as deleted (isLinkedActionDeleted = true). When the action is completely removed from Onyx (linkedActionbecomesnull),isLinkedActionDeletedreturnsfalse(line 467:if (!linkedAction) return false), so the stalereportActionIDFromRouteis never cleared. The stalereportActionIDFromRoutecausesReportScreento show the "not here" page via theshouldShowNotFoundLinkedActioncheck at lines 497-504.This only happens on staging because in production,
isProductionistrue, andactionTargetReportActionIDis passed asundefinedto the navigation route — soreportActionIDFromRouteis never set, and there's nothing to go stale.What changes do you think we should make in order to solve the problem?
In
ReportScreen.tsx, the useEffect at lines 897-914 should also handle the case wherelinkedActionisnullbutreportActionIDFromRouteis still set. When the action has been completely removed from Onyx (not just marked as deleted), the stalereportActionIDFromRouteshould be cleared by callingNavigation.setParams({reportActionID: ''}).Specifically, add a condition: if
!linkedAction && !!reportActionIDFromRoute && !reportMetadata?.isLoadingInitialReportActions, clear the route params. This ensures the central pane falls back to rendering the DM normally when the deep-linked action no longer exists.What alternative solutions did you explore? (Optional)
ReportChangeWorkspacePage.selectPolicy— when the workspace change is triggered, proactively clear thereportActionIDfrom the navigation route. This is less robust since other operations could also remove the linked action.isLinkedActionDeletedreturntruewhenlinkedActionis null andreportActionIDFromRouteis set — this would let the existing cleanup logic handle the case. However, changing this semantic could have unintended side effects elsewhere.Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot to refine this analysis, or explain why you are rejecting Melvin's proposal.
42 remaining items
melvin-bot commentedon May 1, 2026
Current assignees @hoangzinh and @aimane-chnaif are eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon May 1, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022050326150003164540
[-][Due for payment 2026-04-30] Expense - Not here page opens after moving IOU report to workspace[/-][+][$250] [Due for payment 2026-04-30] Expense - Not here page opens after moving IOU report to workspace[/+]mallenexpensify commentedon May 1, 2026
@aimane-chnaif can you please accept the job below? Please reply here and tag me once you have.
https://www.upwork.com/jobs/~022050326150003164540
aimane-chnaif commentedon May 4, 2026
@mallenexpensify accepted offer
mallenexpensify commentedon May 4, 2026
@aimane-chnaif this looks like it was a regression from your PR here
and the issue was created during the regression period. So this shouldn't be due payment, correct?
If so, I'll need to get a refund, I paid you before reviewing here.
aimane-chnaif commentedon May 4, 2026
@mallenexpensify here's evidence - #85753 (comment)
mallenexpensify commentedon May 4, 2026
Payment Summary
Contributor+: @aimane-chnaif paid $250 via Upwork
thx @aimane-chnaif . If anyone disagrees that isn't a regression issue, plz comment.