You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Chat - Skeleton loader appears when refreshing app #85867
Version Number: 9.3.41-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack: N/A Email or phone of affected tester (no customers):sijnisojnsiojdosjjo2@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Chat Report View
Action Performed:
Go to staging.new.expensify.com
Go to any chat.
Refresh the page.
Expected Result:
App will load instantly without skeleton loader when refreshing the app.
Actual Result:
Skeleton loader appears in LHN and central pane when refreshing app.
Report header shows the report name, while the rest is skeleton loader.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
On staging v9.3.41-0, refreshing the app shows a skeleton loader in the LHN and central pane. The report header shows the report name correctly, but the body and LHN show skeleton loaders. This does not happen on production.
What is the root cause of that problem?
The root cause is PR #84673 which removed REPORT_VIOLATIONS from ONYXKEYS.COLLECTION in ONYXKEYS.ts, but the reportAttributes derived value config still references it as a dependency (added by the earlier PR #85199).
This creates an undefined entry in the reportAttributes dependency array at reportAttributes.ts:74. During derived value initialization in OnyxDerived/index.ts:86-132, the system tries to connect to undefined as an Onyx key via Onyx.connectWithoutView({ key: undefined }). This connection either errors out or never fires its callback, preventing connectionsEstablishedCount from reaching totalConnections (12). As a result, areAllConnectionsSet is never true, and the guard at line 71-74 causes recomputeDerivedValue to always return early — the reportAttributes derived value is never recomputed after startup.
This breaks the data pipeline for the LHN:
reportAttributes is never updated after initial cache restoration from IndexedDB
useSidebarOrderedReports depends on reportAttributes for filtering and sorting LHN items
With stale or absent reportAttributes, orderedReports may stay empty or take longer to populate
Meanwhile, isLoadingReportData defaults to true (via const [isLoadingReportData = true] = useOnyx(...) at SidebarLinks.tsx:42) because IS_LOADING_REPORT_DATA is not in Onyx's initialKeyStates and loads asynchronously from IndexedDB
Both conditions for the skeleton are met: isLoadingReportData === true && optionListItems?.length === 0 at SidebarLinks.tsx:102
For the central pane skeleton: useOnyx returns undefined for reportMetadata before Onyx hydrates from storage, causing the destructuring default (isLoadingInitialReportActions: true, hasOnceLoadedReportActions: false) to apply at ReportScreen.tsx:127-135, which triggers the skeleton at ReportScreen.tsx:992-994.
Note: A revert of #84673 was already merged to main via PR #85863, but it is not yet deployed to staging.
What changes do you think we should make in order to solve the problem?
Cherry-pick or deploy PR #85863 (the revert of #84673) to the staging branch. This restores ONYXKEYS.COLLECTION.REPORT_VIOLATIONS so the reportAttributes derived value's dependency array no longer contains undefined, allowing all 12 connections to initialize and areAllConnectionsSet to become true.
What alternative solutions did you explore? (Optional)
Add defensive handling in OnyxDerived/index.ts to skip undefined dependencies during init (e.g., if (!dependencyOnyxKey) { checkAndMarkConnectionInitialized(dependencyIndex); continue; }). This would make the derived value system resilient to missing dependencies but doesn't address the underlying issue of the removed Onyx key.
Remove ONYXKEYS.COLLECTION.REPORT_VIOLATIONS from the reportAttributes dependency list in reportAttributes.ts. However, this would lose the field violation detection added by PR follow up: GBR appears when there is report field error #85199, which is needed for correct brick road indicators.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
Activity
melvin-bot commentedon Mar 19, 2026
Triggered auto assignment to @stitesExpensify (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Mar 19, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Mar 19, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Mar 19, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
On staging v9.3.41-0, refreshing the app shows a skeleton loader in the LHN and central pane. The report header shows the report name correctly, but the body and LHN show skeleton loaders. This does not happen on production.
What is the root cause of that problem?
The root cause is PR #84673 which removed
REPORT_VIOLATIONSfromONYXKEYS.COLLECTIONinONYXKEYS.ts, but thereportAttributesderived value config still references it as a dependency (added by the earlier PR #85199).This creates an
undefinedentry in thereportAttributesdependency array atreportAttributes.ts:74. During derived value initialization inOnyxDerived/index.ts:86-132, the system tries to connect toundefinedas an Onyx key viaOnyx.connectWithoutView({ key: undefined }). This connection either errors out or never fires its callback, preventingconnectionsEstablishedCountfrom reachingtotalConnections(12). As a result,areAllConnectionsSetis nevertrue, and the guard at line 71-74 causesrecomputeDerivedValueto always return early — thereportAttributesderived value is never recomputed after startup.This breaks the data pipeline for the LHN:
reportAttributesis never updated after initial cache restoration from IndexedDBuseSidebarOrderedReportsdepends onreportAttributesfor filtering and sorting LHN itemsreportAttributes,orderedReportsmay stay empty or take longer to populateisLoadingReportDatadefaults totrue(viaconst [isLoadingReportData = true] = useOnyx(...)atSidebarLinks.tsx:42) becauseIS_LOADING_REPORT_DATAis not in Onyx'sinitialKeyStatesand loads asynchronously from IndexedDBisLoadingReportData === true && optionListItems?.length === 0atSidebarLinks.tsx:102For the central pane skeleton:
useOnyxreturnsundefinedforreportMetadatabefore Onyx hydrates from storage, causing the destructuring default (isLoadingInitialReportActions: true, hasOnceLoadedReportActions: false) to apply atReportScreen.tsx:127-135, which triggers the skeleton atReportScreen.tsx:992-994.Note: A revert of #84673 was already merged to
mainvia PR #85863, but it is not yet deployed to staging.What changes do you think we should make in order to solve the problem?
Cherry-pick or deploy PR #85863 (the revert of #84673) to the staging branch. This restores
ONYXKEYS.COLLECTION.REPORT_VIOLATIONSso thereportAttributesderived value's dependency array no longer containsundefined, allowing all 12 connections to initialize andareAllConnectionsSetto becometrue.What alternative solutions did you explore? (Optional)
Add defensive handling in
OnyxDerived/index.tsto skipundefineddependencies during init (e.g.,if (!dependencyOnyxKey) { checkAndMarkConnectionInitialized(dependencyIndex); continue; }). This would make the derived value system resilient to missing dependencies but doesn't address the underlying issue of the removed Onyx key.Remove
ONYXKEYS.COLLECTION.REPORT_VIOLATIONSfrom thereportAttributesdependency list inreportAttributes.ts. However, this would lose the field violation detection added by PR follow up: GBR appears when there is report field error #85199, which is needed for correct brick road indicators.Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
vincdargento commentedon Mar 19, 2026
This issue was not reproducible in any snapshot build from the PR checklist (#85862), PR culprit was not found
stitesExpensify commentedon Mar 19, 2026
The offending PR was reverted about an hour ago #85863