You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-03-31] [Due for payment 2026-03-30] Expense - App crashed when tap on "Try it out" button #85926
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
After completing onboarding (Track and budget expenses), tapping "Create expense" then tapping either the "Try it out" or "No thanks" button on the scan test tooltip causes an iOS app crash (EXC_BAD_ACCESS / SIGSEGV at address 0xa). Reproducible in staging (9.3.41-0) but not production.
What is the root cause of that problem?
PR #85409 ("[NO QA] Track when we show the scan test tooltip", merged March 18) added GoogleTagManager.publishEvent() calls to both the onConfirm and onDismiss callbacks for the SCAN_TEST_TOOLTIP in IOURequestStartPage.tsx:267-277.
Both button handlers call GoogleTagManager.publishEvent(), which internally calls logEvent(analytics, ...) from @react-native-firebase/analytics in GoogleTagManager/index.native.ts:10. This logEvent dispatches to the native TurboModule queue (com.meta.react.turbomodulemanager.queue), where Hermes crashes with a null pointer dereference (address 0xa = nil + 10 byte offset).
The crash affects both buttons because GoogleTagManager.publishEvent() is the only code common to both onConfirm and onDismiss callbacks that was added by PR #85409. The tooltip itself is gated behind the NEWDOT_MANAGER_MCTEST beta (IOURequestStartPage.tsx:265), which explains why it only crashes in staging (beta enabled) and not production.
Additionally, this staging release includes the React Native 0.81.4 → 0.83.1 upgrade (PR #79962), which may have introduced a regression in how Firebase Analytics TurboModule calls are dispatched from Portal-rendered content (the tooltip buttons render inside a @gorhom/portal via BaseGenericTooltip/index.native.tsx).
What changes do you think we should make in order to solve the problem?
Immediate fix (deploy blocker): Revert PR #85409 to remove the GoogleTagManager.publishEvent() calls from the tooltip button handlers. This restores the previous working behavior where the tooltip buttons function without triggering Firebase Analytics native module calls.
Alternative targeted fix: Wrap the logEvent call in GoogleTagManager/index.native.ts with a try/catch to prevent unhandled native crashes:
What alternative solutions did you explore? (Optional)
Investigated whether the RN 0.83 upgrade alone is the root cause — while the upgrade may contribute (17 deploy blockers in this release), PR [NO QA] Track when we show the scan test tooltip #85409 is the direct trigger since it added the crashing publishEvent calls
Considered whether the Portal rendering context is the issue — the buttons render inside @gorhom/portal, which may affect TurboModule dispatch, but the simplest fix is to remove/protect the crashing call rather than fix the Portal interaction
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot to refine this analysis, or explain why you are rejecting Melvin's proposal.
changed the title [-]Expense - App crashed when tap on "Try it out" button[/-][+][Due for payment 2026-03-30] Expense - App crashed when tap on "Try it out" button[/+]on Mar 23, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.41-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.42-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
changed the title [-][Due for payment 2026-03-30] Expense - App crashed when tap on "Try it out" button[/-][+][Due for payment 2026-03-31] [Due for payment 2026-03-30] Expense - App crashed when tap on "Try it out" button[/+]on Mar 24, 2026
@JS00001@mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Mar 20, 2026
Triggered auto assignment to @srikarparsi (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Mar 20, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Mar 20, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Mar 20, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
After completing onboarding (Track and budget expenses), tapping "Create expense" then tapping either the "Try it out" or "No thanks" button on the scan test tooltip causes an iOS app crash (EXC_BAD_ACCESS / SIGSEGV at address 0xa). Reproducible in staging (9.3.41-0) but not production.
What is the root cause of that problem?
PR #85409 ("[NO QA] Track when we show the scan test tooltip", merged March 18) added
GoogleTagManager.publishEvent()calls to both theonConfirmandonDismisscallbacks for theSCAN_TEST_TOOLTIPinIOURequestStartPage.tsx:267-277.Both button handlers call
GoogleTagManager.publishEvent(), which internally callslogEvent(analytics, ...)from@react-native-firebase/analyticsinGoogleTagManager/index.native.ts:10. ThislogEventdispatches to the native TurboModule queue (com.meta.react.turbomodulemanager.queue), where Hermes crashes with a null pointer dereference (address 0xa = nil + 10 byte offset).The crash affects both buttons because
GoogleTagManager.publishEvent()is the only code common to bothonConfirmandonDismisscallbacks that was added by PR #85409. The tooltip itself is gated behind theNEWDOT_MANAGER_MCTESTbeta (IOURequestStartPage.tsx:265), which explains why it only crashes in staging (beta enabled) and not production.Additionally, this staging release includes the React Native 0.81.4 → 0.83.1 upgrade (PR #79962), which may have introduced a regression in how Firebase Analytics TurboModule calls are dispatched from Portal-rendered content (the tooltip buttons render inside a
@gorhom/portalviaBaseGenericTooltip/index.native.tsx).What changes do you think we should make in order to solve the problem?
Immediate fix (deploy blocker): Revert PR #85409 to remove the
GoogleTagManager.publishEvent()calls from the tooltip button handlers. This restores the previous working behavior where the tooltip buttons function without triggering Firebase Analytics native module calls.Alternative targeted fix: Wrap the
logEventcall inGoogleTagManager/index.native.tswith a try/catch to prevent unhandled native crashes:What alternative solutions did you explore? (Optional)
publishEventcalls@gorhom/portal, which may affect TurboModule dispatch, but the simplest fix is to remove/protect the crashing call rather than fix the Portal interactionNext Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot to refine this analysis, or explain why you are rejecting Melvin's proposal.
7 remaining items
[-]Expense - App crashed when tap on "Try it out" button[/-][+][Due for payment 2026-03-30] Expense - App crashed when tap on "Try it out" button[/+]melvin-bot commentedon Mar 23, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 23, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.41-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-03-30. 🎊
melvin-bot commentedon Mar 23, 2026
@JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Mar 23, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Mar 24, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.42-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-03-31. 🎊
[-][Due for payment 2026-03-30] Expense - App crashed when tap on "Try it out" button[/-][+][Due for payment 2026-03-31] [Due for payment 2026-03-30] Expense - App crashed when tap on "Try it out" button[/+]melvin-bot commentedon Mar 24, 2026
@JS00001 @mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
mallenexpensify commentedon Mar 30, 2026
If the regression penalty applies, comment on the issue linked to the PR that introduced the regression. Thx