You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-04-07] Report - Inconsistent size of "Review duplicates" and "More" options while resolving duplicates #86363
Version Number: 9.3.47.0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:https://test-management.browserstack.com/projects/2219752/test-runs/TR-13048/folder/13176704/41236823/1280344322 Email or phone of affected tester (no customers):ibellicotest+2250@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Motorola MotoG60 / Android 12 (Hybrid app) App Component: Money Requests
Action Performed:
Prerequisite: Account has at least one workspace.
Open the Expensify app.
Open any workspace chat.
Create two similar manual expenses.
Create another report and add an expense similar to the previous ones.
Open the report with two expenses.
Note that "Review Duplicates" button is bigger than "More" button.
Open any of both expenses.
Note that now, both buttons are almost equal on size. "Review Duplicates" button is smaller, and "More" button is bigger,
Navigate to the report created on step 4.
Note that once again, "Review Duplicates" button is displayed bigger than "More" button.
Expected Result:
The size of "Review duplicates" and "More" buttons, should be the same when opening a report with more than one expense and when opening a report with a single expense.
Actual Result:
The size of "Review Duplicates" and "More" buttons, is different on a report with more than one expense and when opening a report with a single expense.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #85530 - "Extract MoneyRequestHeaderActions to reduce re-renders" by @TMisiukiewicz (High confidence) Related Issues: None
Recommendation: REVERT
PR #85530 refactored the MoneyRequestHeader component by extracting button actions into separate components. During this refactor, the flex styling logic for button sizing was changed in a way that causes inconsistent sizing behavior. The PR introduced a logic issue where the variable name isNarrow is semantically inverted from what it represents, and the flex growth styling is now applied differently than in the original implementation.
Labels: No label changes needed. This issue is correctly labeled as DeployBlockerCash since it is a frontend bug reproducible in staging but not in production, and caused by an App PR.
Details of Analysis
Evidence
The bug is reproducible in staging (v9.3.47.0) but not in production
In MoneyRequestHeaderPrimaryAction.tsx (line 168-172):
constisNarrow=!shouldUseNarrowLayout||(wideRHPRouteKeys.length>0&&!isSmallScreenWidth);if(isNarrow){returnbutton;// No wrapper}return<Viewstyle={[styles.flexGrow4]}>{button}</View>;
In MoneyRequestHeaderSecondaryActions.tsx (line 502):
Semantic inversion: The variable isNarrow is FALSE on mobile (narrow) devices because shouldUseNarrowLayout = true makes isNarrow = !true = false
Changed logic: Both buttons now get flexGrow4 based on the same isNarrow condition, rather than being mutually exclusive
Rendering context: The buttons may render in different contexts (report view vs expense detail view), causing the isNarrow calculation or component mounting to behave inconsistently
This results in the buttons having inconsistent sizes depending on the screen/context, as described in the bug report.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.50-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
Activity
melvin-bot commentedon Mar 25, 2026
Triggered auto assignment to @mjasikowski (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Mar 25, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Mar 25, 2026
💬 A slack conversation has been started in #expensify-open-source
OSBotify commentedon Mar 25, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #85530 - "Extract MoneyRequestHeaderActions to reduce re-renders" by @TMisiukiewicz (High confidence)
Related Issues: None
Recommendation: REVERT
PR #85530 refactored the MoneyRequestHeader component by extracting button actions into separate components. During this refactor, the flex styling logic for button sizing was changed in a way that causes inconsistent sizing behavior. The PR introduced a logic issue where the variable name
isNarrowis semantically inverted from what it represents, and the flex growth styling is now applied differently than in the original implementation.Labels: No label changes needed. This issue is correctly labeled as
DeployBlockerCashsince it is a frontend bug reproducible in staging but not in production, and caused by an App PR.Details of Analysis
Evidence
Verification
I confirmed that PR #85530 modifies the following files that directly control the button rendering and sizing:
src/components/MoneyRequestHeader.tsx(major refactor, 601 deletions)src/components/MoneyRequestHeaderActions.tsx(new file, wraps both buttons)src/components/MoneyRequestHeaderPrimaryAction.tsx(new file, "Review Duplicates" button)src/components/MoneyRequestHeaderSecondaryActions.tsx(new file, "More" button)Root Cause
Original behavior (before PR #85530):
flexGrow4when it existsflexGrow4ONLY when there is NO primary actionThis ensured one button takes full width when alone, or both share space proportionally.
New behavior (after PR #85530):
In
MoneyRequestHeaderPrimaryAction.tsx(line 168-172):In
MoneyRequestHeaderSecondaryActions.tsx(line 502):The issue is threefold:
isNarrowis FALSE on mobile (narrow) devices becauseshouldUseNarrowLayout = truemakesisNarrow = !true = falseflexGrow4based on the sameisNarrowcondition, rather than being mutually exclusiveisNarrowcalculation or component mounting to behave inconsistentlyThis results in the buttons having inconsistent sizes depending on the screen/context, as described in the bug report.
mjasikowski commentedon Mar 26, 2026
Minor UI issue, not a blocker
12 remaining items
melvin-bot commentedon Mar 31, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 31, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.50-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-04-07. 🎊
melvin-bot commentedon Mar 31, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Apr 7, 2026
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
mallenexpensify commentedon May 18, 2026
Payment Summary
Contributor+: @parasharrajat due $250 via NewDot
parasharrajat commentedon May 20, 2026
Payment requested as per #86363 (comment)
garrettmknight commentedon May 21, 2026
$250 approved for @parasharrajat