Skip to content

[HOLD] [$250] Android - remove "(archived)" that shows up in the DM row after deleting a workspace member #8643

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


We found this issue when executing #8437

Action Performed:

  1. Launch the app
  2. Create a new workspace from an account that's on the policyExpenseChat beta (e.g @expensifail.com)
  3. Add a new member to the workspace via Manage Members > Invite
  4. Log-in as the member and send a couple of messages in the member's workspace chat
  5. Log back in again to the admin account and remove the member from the workspace via Manage Members > Remove
  6. Go back to LHN

Expected Result:

Chat in the LHN displayed without "Archived" after deleting a member. We compared with the PR #8437 screenshot attached

Actual Result:

Chat in the LHN displayed with "Archived" after deleting a member

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.55.0
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5532932_LHN

Upwork job link: https://www.upwork.com/jobs/~01696c42f472066bd6
Issue reported by:
Slack conversation:

View all open jobs on GitHub

Activity

  1. melvin-bot commented on Apr 14, 2022

    @melvin-bot

    Triggered auto assignment to @timszot (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  2. removed their assignment
    on Apr 14, 2022
  3. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 14, 2022
  4. melvin-bot commented on Apr 14, 2022

    @melvin-bot

    Triggered auto assignment to @michaelhaxhiu (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  5. changed the title [-]Android- Chat in the LHN displayed with "Archived" after deleting a member[/-] [+]Android - remove "(archived)" that shows up in the DM row after deleting a workspace member[/+] on Apr 15, 2022
  6. michaelhaxhiu commented on Apr 19, 2022

    @michaelhaxhiu
    Contributor

    Sorry for delay! Upwork job is posted - https://www.upwork.com/jobs/~01696c42f472066bd6

  7. 7 remaining items

  8. changed the title [-]Android - remove "(archived)" that shows up in the DM row after deleting a workspace member[/-] [+][$250] Android - remove "(archived)" that shows up in the DM row after deleting a workspace member[/+] on Apr 21, 2022
  9. rushatgabhane commented on Apr 24, 2022

    @rushatgabhane
    Member

    Sorry, I can't help here. I'm gonna unassign myself because I have school stuff going on 📚

  10. removed their assignment
    on Apr 24, 2022
  11. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 25, 2022
  12. Beamanator commented on Apr 25, 2022

    @Beamanator
    Contributor

    Removing Help Wanted for now b/c I believe this behavior is expected, when looking at the PR that added (archived) here: #8447

  13. Beamanator commented on Apr 25, 2022

    @Beamanator
    Contributor

    @kavimuru can you please mention who reported this issue in the OP? Also in the screenshots you posted, it would be nice if you could clarify that the first one is from the QA steps in this PR: #8437 and the second screenshot is what you're actually seeing :D

  14. changed the title [-][$250] Android - remove "(archived)" that shows up in the DM row after deleting a workspace member[/-] [+][HOLD] [$250] Android - remove "(archived)" that shows up in the DM row after deleting a workspace member[/+] on Apr 25, 2022
  15. Beamanator commented on Apr 25, 2022

    @Beamanator
    Contributor

    Putting on hold to confirm if this is a bug or not

  16. TomatoToaster commented on Apr 25, 2022

    @TomatoToaster
    Contributor

    Cross posting here in this issue from here to confirm, but yes this is not a bug and is intended behavior.

    If this ever happens for a non-workspace chat, it is definitely a bug.

  17. michaelhaxhiu commented on Apr 25, 2022

    @michaelhaxhiu
    Contributor

    @Beamanator @TomatoToaster So do we want to make this a feature request (since it's not a bug), or close it?

  18. TomatoToaster commented on Apr 25, 2022

    @TomatoToaster
    Contributor

    Oh yes sorry let's close it. I'm realizing I didn't close with comment.

  19. TomatoToaster commented on Apr 25, 2022

    @TomatoToaster
    Contributor

    This behavior should be fixed and universal (work same on iOS and android) with this PR: #8751. If that's not the case when this PR is being QA'ed, then we could reopen this to make sure it works the same in iOS and android.

  20. michaelhaxhiu commented on Apr 25, 2022

    @michaelhaxhiu
    Contributor

    I'll check back on this on Friday. Let's leave closed till then

  21. Beamanator commented on Apr 25, 2022

    @Beamanator
    Contributor

    Awesome thanks for closing this out and confirming it's expected @TomatoToaster 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions