You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-04-14] Reports - Non functional View button is shown instead of Undelete button #86796
Version Number: 9.3.51-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#85818 Email or phone of affected tester (no customers): Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Search
Action Performed:
Go to staging.new.expensify.com
Go to workspace chat.
Create an expense.
Delete the expense.
Go to Reports > Expenses.
On the search field, enter group-by:from status:undelete and search.
Click Columns.
Select Action and click Apply.
Expand the table.
Click View button.
Expected Result:
Undelete button should be displayed instead of View button because deleted expense cannot be viewed.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #85818 - "Deleted transactions on search" by @jnowakow (High confidence) Related Issues: None
Recommendation: ROLL FORWARD
A revert would remove the entire deleted transactions feature, which is working correctly in most contexts. The fix is simple and surgical - just need to exclude UNDELETE from the isChildListItem override in ActionCell.
Labels: Keeping DeployBlockerCash (Frontend bug - App deploy is blocked)
When isChildListItem is true (which happens when viewing transactions in the expanded table), the ActionCell component ignores the actual action and always shows "View" instead of respecting the UNDELETE action.
The flow:
getActions() in SearchUIUtils correctly returns [CONST.SEARCH.ACTION_TYPES.UNDELETE] for deleted transactions
The action is passed to ActionCell via TransactionItemRow
However, ActionCell has a hardcoded override: if isChildListItem is true, it always shows "View"
This causes deleted transactions to show a non-functional "View" button instead of "Undelete"
The PR added UNDELETE to shouldUseViewAction check would be wrong (line 42), but the real issue is that UNDELETE should be excluded from the isChildListItem override logic entirely, similar to how PAY is handled separately.
Fix Strategy
The fix should add special handling for UNDELETE action in ActionCell to prevent it from being overridden by the isChildListItem check. This is a small, targeted change that wont affect other functionality.
…short-circuits to always render a "View" button when isChildListItem is true. When transactions are displayed inside an expanded group (group-by:from), TransactionGroupListExpanded passes isReportItemChild which flows as isChildListItem={true} to ActionCell. This overrides the actual action value — even though getActions() in SearchUIUtils.ts correctly returns UNDELETE for deleted transactions (line ~1948-1950), the isChildListItem check ignores it.
2. onUndelete callback is not wired through grouped item components.
TransactionGroupListExpanded hardcodes onButtonPress to openReportInRHP(transaction) (line ~232-234), bypassing handleActionButtonPress which contains the UNDELETE case handler. Neither TransactionGroupListItem nor TransactionGroupListExpanded accept or pass an onUndelete callback.
In contrast, the non-grouped view works correctly: TransactionListItem renders TransactionItemRow without isReportItemChild, and properly threads onUndelete through handleActionButtonPress.
What changes do you think we should make in order to solve the problem?
Fix ActionCell/index.tsx: Modify the condition at line 44 so that isChildListItem does not override action types that require a specific button (like UNDELETE). The UNDELETE action should be checked before the isChildListItem short-circuit, so it renders the "Undelete" button even for child items.
Thread onUndelete through the grouped item components: Pass the onUndelete callback from SearchList/index.tsx through TransactionGroupListItem → TransactionGroupListExpanded → TransactionItemRow, so that when the "Undelete" button is pressed for a child item in a group, it calls handleActionButtonPress with the UNDELETE action (which triggers onUndelete), rather than calling openReportInRHP.
What alternative solutions did you explore? (Optional)
An alternative would be to modify TransactionGroupListExpanded to not pass isReportItemChild for deleted transactions. However, this would be a less clean approach because isReportItemChild affects other styling/behavior beyond just the action button, and conditionally removing it could cause visual inconsistencies.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
changed the title [-]Reports - Non functional View button is shown instead of Undelete button[/-][+][Due for payment 2026-04-14] Reports - Non functional View button is shown instead of Undelete button[/+]on Apr 7, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.52-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@luacmartins@mhawryluk The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Mar 31, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #85818
melvin-bot commentedon Mar 31, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Mar 31, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Mar 31, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #85818 - "Deleted transactions on search" by @jnowakow (High confidence)
Related Issues: None
Recommendation: ROLL FORWARD
A revert would remove the entire deleted transactions feature, which is working correctly in most contexts. The fix is simple and surgical - just need to exclude UNDELETE from the isChildListItem override in ActionCell.
Labels: Keeping
DeployBlockerCash(Frontend bug - App deploy is blocked)Detailed Analysis
Evidence
Verification
The PR modifies these key files related to the affected functionality:
src/components/Search/SearchList/ListItem/ActionCell/index.tsx- Renders the action buttonsrc/libs/SearchUIUtils.ts- Determines which action to show (getActions()function)src/libs/TransactionUtils/index.ts- AddedisDeletedTransaction()helpersrc/components/TransactionItemRow/index.tsx- Renders the table row with ActionCellRoot Cause
The bug is in
/home/runner/_work/App/App/src/components/Search/SearchList/ListItem/ActionCell/index.tsxat line 44:When
isChildListItemistrue(which happens when viewing transactions in the expanded table), the ActionCell component ignores the actual action and always shows "View" instead of respecting the UNDELETE action.The flow:
getActions()in SearchUIUtils correctly returns[CONST.SEARCH.ACTION_TYPES.UNDELETE]for deleted transactionsisChildListItemis true, it always shows "View"The PR added UNDELETE to
shouldUseViewActioncheck would be wrong (line 42), but the real issue is that UNDELETE should be excluded from theisChildListItemoverride logic entirely, similar to how PAY is handled separately.Fix Strategy
The fix should add special handling for UNDELETE action in ActionCell to prevent it from being overridden by the
isChildListItemcheck. This is a small, targeted change that wont affect other functionality.MelvinBot commentedon Mar 31, 2026
Proposal
What is the root cause of that problem?
There are two related bugs that cause the non-functional "View" button to appear instead of "Undelete" when using
group-by:from status:undelete:1.
ActionCellalways renders "View" for child list items, ignoring the actual action.In
ActionCell/index.tsx:44, the condition:…short-circuits to always render a "View" button when
isChildListItemistrue. When transactions are displayed inside an expanded group (group-by:from),TransactionGroupListExpandedpassesisReportItemChildwhich flows asisChildListItem={true}toActionCell. This overrides the actualactionvalue — even thoughgetActions()inSearchUIUtils.tscorrectly returnsUNDELETEfor deleted transactions (line ~1948-1950), theisChildListItemcheck ignores it.2.
onUndeletecallback is not wired through grouped item components.TransactionGroupListExpandedhardcodesonButtonPresstoopenReportInRHP(transaction)(line ~232-234), bypassinghandleActionButtonPresswhich contains theUNDELETEcase handler. NeitherTransactionGroupListItemnorTransactionGroupListExpandedaccept or pass anonUndeletecallback.In contrast, the non-grouped view works correctly:
TransactionListItemrendersTransactionItemRowwithoutisReportItemChild, and properly threadsonUndeletethroughhandleActionButtonPress.What changes do you think we should make in order to solve the problem?
Fix
ActionCell/index.tsx: Modify the condition at line 44 so thatisChildListItemdoes not override action types that require a specific button (likeUNDELETE). TheUNDELETEaction should be checked before theisChildListItemshort-circuit, so it renders the "Undelete" button even for child items.Thread
onUndeletethrough the grouped item components: Pass theonUndeletecallback fromSearchList/index.tsxthroughTransactionGroupListItem→TransactionGroupListExpanded→TransactionItemRow, so that when the "Undelete" button is pressed for a child item in a group, it callshandleActionButtonPresswith theUNDELETEaction (which triggersonUndelete), rather than callingopenReportInRHP.What alternative solutions did you explore? (Optional)
An alternative would be to modify
TransactionGroupListExpandedto not passisReportItemChildfor deleted transactions. However, this would be a less clean approach becauseisReportItemChildaffects other styling/behavior beyond just the action button, and conditionally removing it could cause visual inconsistencies.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.3 remaining items
[-]Reports - Non functional View button is shown instead of Undelete button[/-][+][Due for payment 2026-04-14] Reports - Non functional View button is shown instead of Undelete button[/+]melvin-bot commentedon Apr 7, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 7, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.52-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-04-14. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 7, 2026
@luacmartins @mhawryluk The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Apr 7, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)