Skip to content

Account - Right click on Help site button does not show Copy URL to clipboard modal #86801

Closed

Description

@nlemma

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.51-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #86187
Email or phone of affected tester (no customers): soidnjsojdiosjiosdjo@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Other

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Account > Help.
  3. Right click on Help site.

Expected Result:

Copy URL to clipboard modal will open.

Actual Result:

Copy URL to clipboard modal does not open.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7118383_1774988266177.14.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 31, 2026
  2. melvin-bot commented on Mar 31, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #86187

  3. melvin-bot commented on Mar 31, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on Mar 31, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. OSBotify commented on Mar 31, 2026

    @OSBotify
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: #86187 - "feat: Created in-product Help landing page and updated Settings navigation" by @Pujan92 (High confidence)
    Related Issues: #85991

    Recommendation: REVERT

    PR #86187 removed the context menu functionality for the Help Site button. The fix would require adding a link property to the menu item in the new HelpPage.tsx, but reverting is cleaner since this is a complete feature change that broke existing functionality.

    Labels: Keeping DeployBlockerCash - This is a frontend bug that requires an App PR revert. No label changes needed.

    📋 Detailed Analysis

    Evidence

    PR #86187 created a new Help landing page and changed the Help menu item behavior. The issue occurs on the new Help page when right-clicking the "Help site" button.

    Root Cause Analysis

    Before PR #86187 (in InitialSettingsPage.tsx):

    {
        translationKey: 'initialSettingsPage.help',
        icon: icons.QuestionMark,
        iconRight: icons.NewWindow,
        shouldShowRightIcon: true,
        sentryLabel: CONST.SENTRY_LABEL.SETTINGS_GENERAL.HELP,
        link: CONST.NEWHELP_URL,  // ← This property enabled right-click context menu
        action: () => {
            openExternalLink(CONST.NEWHELP_URL);
        },
    }

    After PR #86187 (in HelpPage.tsx, lines 24-35):

    {
        key: 'initialSettingsPage.helpPage.helpSite',
        title: translate('initialSettingsPage.helpPage.helpSite'),
        icon: icons.Monitor,
        iconRight: icons.NewWindow,
        onPress: () => openExternalLink(CONST.NEWHELP_URL),  // ← Only onPress, no link property
        shouldShowRightIcon: true,
        wrapperStyle: [styles.sectionMenuItemTopDescription],
        sentryLabel: CONST.SENTRY_LABEL.SETTINGS_HELP.HELP_DOCS,
    }

    Technical Explanation:
    The MenuItemList component (lines 100-101) only sets up the onSecondaryInteraction handler (which enables right-click context menu) when a link property is provided:

    onSecondaryInteraction={menuItemProps.link !== undefined ? (e) => secondaryInteraction(menuItemProps.link, e) : undefined}
    shouldShowContextMenuHint={menuItemProps.shouldShowContextMenuHint ?? menuItemProps.link !== undefined}

    Since the new Help Site menu item in HelpPage.tsx doesn't include the link property, the right-click context menu functionality is not enabled.

    Verification

  6. FitseTLT commented on Mar 31, 2026

    @FitseTLT
    Contributor

    @Pujan92 U can raise a follow up pr on this

  7. MelvinBot commented on Mar 31, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    PR #86187 created a new HelpPage screen and moved the "Help site" link into it. However, the menu item definition in HelpPage.tsx:24-35 is missing the link property that was present on the old Help item in InitialSettingsPage.

    Without the link property, MenuItemList.tsx:100 does not wire up onSecondaryInteraction for the menu item:

    onSecondaryInteraction={menuItemProps.link !== undefined ? (e) => secondaryInteraction(menuItemProps.link, e) : undefined}
    

    Since onSecondaryInteraction is undefined, right-clicking the "Help site" item shows the browser's default context menu for a <div> element (which has no URL-related options) instead of Expensify's custom context menu popover with the "Copy URL to clipboard" option.

    What changes do you think we should make in order to solve the problem?

    Add the missing link property to the Help site menu item in HelpPage.tsx:

    link: CONST.NEWHELP_URL,
    

    This will cause MenuItemList to wire up onSecondaryInteraction, which triggers showContextMenu with CONTEXT_MENU_TYPES.LINK — restoring the "Copy URL to clipboard" popover on right-click, matching the behavior the old InitialSettingsPage Help item had.

    What alternative solutions did you explore? (Optional)

    Could render the MenuItem as a native <a> tag (via React Native Web's href prop) for full native browser context menu support. However, this would be inconsistent with how all other external link MenuItems work in the app (e.g., AboutPage, AppDownloadLinks), which all use the custom context menu approach via onSecondaryInteraction.


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  8. Pujan92 commented on Apr 1, 2026

    @Pujan92
    Contributor

    This can be demoted and will be handled in PR #86576

  9. 2 remaining items

  10. Valforte commented on Apr 1, 2026

    @Valforte
    Contributor

    NAB

  11. melvin-bot commented on Apr 6, 2026

    @melvin-bot

    @Valforte Eep! 4 days overdue now. Issues have feelings too...

  12. Valforte commented on Apr 7, 2026

    @Valforte
    Contributor

    Ongoing

  13. melvin-bot commented on Apr 10, 2026

    @melvin-bot

    @Valforte Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  14. melvin-bot commented on Apr 14, 2026

    @melvin-bot

    @Valforte this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  15. melvin-bot commented on Apr 14, 2026

    @melvin-bot

    @Valforte 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  16. melvin-bot commented on Apr 16, 2026

    @melvin-bot

    @Valforte Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

  17. melvin-bot commented on Apr 20, 2026

    @melvin-bot

    @Valforte 12 days overdue now... This issue's end is nigh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions