You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Account - Right click on Help site button does not show Copy URL to clipboard modal #86801
Version Number: 9.3.51-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#86187 Email or phone of affected tester (no customers):soidnjsojdiosjiosdjo@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Other
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #86187 - "feat: Created in-product Help landing page and updated Settings navigation" by @Pujan92 (High confidence) Related Issues: #85991
Recommendation: REVERT
PR #86187 removed the context menu functionality for the Help Site button. The fix would require adding a link property to the menu item in the new HelpPage.tsx, but reverting is cleaner since this is a complete feature change that broke existing functionality.
Labels: Keeping DeployBlockerCash - This is a frontend bug that requires an App PR revert. No label changes needed.
📋 Detailed Analysis
Evidence
PR #86187 created a new Help landing page and changed the Help menu item behavior. The issue occurs on the new Help page when right-clicking the "Help site" button.
{key: 'initialSettingsPage.helpPage.helpSite',title: translate('initialSettingsPage.helpPage.helpSite'),icon: icons.Monitor,iconRight: icons.NewWindow,onPress: ()=>openExternalLink(CONST.NEWHELP_URL),// ← Only onPress, no link propertyshouldShowRightIcon: true,wrapperStyle: [styles.sectionMenuItemTopDescription],sentryLabel: CONST.SENTRY_LABEL.SETTINGS_HELP.HELP_DOCS,}
Technical Explanation:
The MenuItemList component (lines 100-101) only sets up the onSecondaryInteraction handler (which enables right-click context menu) when a link property is provided:
PR #86187 created a new HelpPage screen and moved the "Help site" link into it. However, the menu item definition in HelpPage.tsx:24-35 is missing the link property that was present on the old Help item in InitialSettingsPage.
Without the link property, MenuItemList.tsx:100 does not wire up onSecondaryInteraction for the menu item:
Since onSecondaryInteraction is undefined, right-clicking the "Help site" item shows the browser's default context menu for a <div> element (which has no URL-related options) instead of Expensify's custom context menu popover with the "Copy URL to clipboard" option.
What changes do you think we should make in order to solve the problem?
Add the missing link property to the Help site menu item in HelpPage.tsx:
link: CONST.NEWHELP_URL,
This will cause MenuItemList to wire up onSecondaryInteraction, which triggers showContextMenu with CONTEXT_MENU_TYPES.LINK — restoring the "Copy URL to clipboard" popover on right-click, matching the behavior the old InitialSettingsPage Help item had.
What alternative solutions did you explore? (Optional)
Could render the MenuItem as a native <a> tag (via React Native Web's href prop) for full native browser context menu support. However, this would be inconsistent with how all other external link MenuItems work in the app (e.g., AboutPage, AppDownloadLinks), which all use the custom context menu approach via onSecondaryInteraction.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
@Valforte this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
Activity
melvin-bot commentedon Mar 31, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #86187
melvin-bot commentedon Mar 31, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Mar 31, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Mar 31, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #86187 - "feat: Created in-product Help landing page and updated Settings navigation" by @Pujan92 (High confidence)
Related Issues: #85991
Recommendation: REVERT
PR #86187 removed the context menu functionality for the Help Site button. The fix would require adding a
linkproperty to the menu item in the new HelpPage.tsx, but reverting is cleaner since this is a complete feature change that broke existing functionality.Labels: Keeping
DeployBlockerCash- This is a frontend bug that requires an App PR revert. No label changes needed.📋 Detailed Analysis
Evidence
PR #86187 created a new Help landing page and changed the Help menu item behavior. The issue occurs on the new Help page when right-clicking the "Help site" button.
Root Cause Analysis
Before PR #86187 (in InitialSettingsPage.tsx):
After PR #86187 (in HelpPage.tsx, lines 24-35):
Technical Explanation:
The
MenuItemListcomponent (lines 100-101) only sets up theonSecondaryInteractionhandler (which enables right-click context menu) when alinkproperty is provided:Since the new Help Site menu item in HelpPage.tsx doesn't include the
linkproperty, the right-click context menu functionality is not enabled.Verification
FitseTLT commentedon Mar 31, 2026
@Pujan92 U can raise a follow up pr on this
MelvinBot commentedon Mar 31, 2026
Proposal
What is the root cause of that problem?
PR #86187 created a new
HelpPagescreen and moved the "Help site" link into it. However, the menu item definition inHelpPage.tsx:24-35is missing thelinkproperty that was present on the old Help item inInitialSettingsPage.Without the
linkproperty,MenuItemList.tsx:100does not wire uponSecondaryInteractionfor the menu item:Since
onSecondaryInteractionisundefined, right-clicking the "Help site" item shows the browser's default context menu for a<div>element (which has no URL-related options) instead of Expensify's custom context menu popover with the "Copy URL to clipboard" option.What changes do you think we should make in order to solve the problem?
Add the missing
linkproperty to the Help site menu item inHelpPage.tsx:This will cause
MenuItemListto wire uponSecondaryInteraction, which triggersshowContextMenuwithCONTEXT_MENU_TYPES.LINK— restoring the "Copy URL to clipboard" popover on right-click, matching the behavior the oldInitialSettingsPageHelp item had.What alternative solutions did you explore? (Optional)
Could render the MenuItem as a native
<a>tag (via React Native Web'shrefprop) for full native browser context menu support. However, this would be inconsistent with how all other external link MenuItems work in the app (e.g., AboutPage, AppDownloadLinks), which all use the custom context menu approach viaonSecondaryInteraction.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.Pujan92 commentedon Apr 1, 2026
This can be demoted and will be handled in PR #86576
2 remaining items
Valforte commentedon Apr 1, 2026
NAB
melvin-bot commentedon Apr 6, 2026
@Valforte Eep! 4 days overdue now. Issues have feelings too...
Valforte commentedon Apr 7, 2026
Ongoing
melvin-bot commentedon Apr 10, 2026
@Valforte Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Apr 14, 2026
@Valforte this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
melvin-bot commentedon Apr 14, 2026
@Valforte 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
melvin-bot commentedon Apr 16, 2026
@Valforte Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!
melvin-bot commentedon Apr 20, 2026
@Valforte 12 days overdue now... This issue's end is nigh!