Skip to content

[Due for payment 2026-05-18] [$250] Expense - Unable to create expense in the report after Concierge joins the report #86898

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.51-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-14589/folder/22315296/56016282/1295549084?sort=-identifier
Email or phone of affected tester (no customers): jsodinjsodjoisnjonsj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create an expense.
  4. Open the report.
  5. Click +.
    → Create expense and Track distance option are available.
  6. Send "Create an expense" message in the report.
  7. Wait for Concierge message to show up.
  8. After Concierge replies, click +.
  9. Click More menu > Add expense > Create expense.

Expected Result:

After Concierge replies, + menu will show Create expense and Track distance option. Create expense button will open expense creation page.

Actual Result:

After Concierge replies, + menu is missing Create expense and Track distance option. Create expense button opens not here page.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7119114_1775059456769.27.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mallenexpensify
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022043625199019032314
  • Upwork Job ID: 2043625199019032314
  • Last Price Increase: 2026-05-04

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed on Apr 13, 2026
  2. MelvinBot commented on Apr 13, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    When Concierge replies in a report, the server adds Concierge to the report's participants. The + menu options are determined by getMoneyRequestOptions, which checks whether any EXPENSIFY_ACCOUNT_IDS are among the report's participants. Since Concierge is in EXPENSIFY_ACCOUNT_IDS, the function returns [] — removing all expense options ("Create expense", "Track distance") from the menu.

    The "not here" page occurs for the same reason: canCreateRequest delegates to getMoneyRequestOptions, which returns empty, so AccessOrNotFoundWrapper renders NotFoundPage.

    The participant list is built at ReportActionCompose.tsx:267-273 from all report.participants keys — it only filters out the current user, not hidden/system participants like Concierge.

    What changes do you think we should make in order to solve the problem?

    Filter out EXPENSIFY_ACCOUNT_IDS from reportParticipantIDs in ReportActionCompose.tsx before passing them to getMoneyRequestOptions. This way, Concierge being added as a participant won't trigger the Expensify-account check that blocks all expense options.

    Alternatively, the filter could be applied inside getMoneyRequestOptions itself — only consider non-system-account participants when deciding whether to block expense creation. The Expensify-account check at ReportUtils.ts:10022 would then use a filtered list that excludes participants with notificationPreference: 'hidden', since system accounts added by the server (like Concierge) typically have this preference.

    What alternative solutions did you explore? (Optional)

    Removing Concierge from EXPENSIFY_ACCOUNT_IDS is not viable — that constant is used for other legitimate checks. The fix should be scoped to the participant filtering for expense option determination.


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  3. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 13, 2026
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 13, 2026
  5. melvin-bot commented on Apr 13, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

  6. changed the title [-]Expense - Unable to create expense in the report after Concierge joins the report[/-] [+][$250] Expense - Unable to create expense in the report after Concierge joins the report[/+] on Apr 13, 2026
  7. 49 remaining items

  8. thesahindia commented on May 19, 2026

    @thesahindia
    Member

    @MelvinBot, was this a regression? If so, identify the responsible PR.

  9. MelvinBot commented on May 19, 2026

    @MelvinBot
    Contributor

    Not a regression — this was a long-standing gap in getMoneyRequestOptions.

    The Expensify-account exclusion check never had carve-outs for policy expense chats or expense reports. The history:

    The gap existed since the check was first written. It likely became more noticeable as Concierge participation in expense report chats became more common.

  10. thesahindia commented on May 19, 2026

    @thesahindia
    Member

    No checklist needed. Test steps are below:

    1. Go to workspace chat
    2. Create an expense
    3. Open the report
    4. Click '+'
    5. Verify 'Create expense' and 'Track distance' options are available
    6. Type "Create an expense" in composer and send
    7. Wait for Concierge message to show up.
    8. After Concierge message, click '+'
    9. Verify 'Create expense' and 'Track distance' options are available
  11. mallenexpensify commented on May 19, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @paulnjs due $250 via Upwork
    Contributor+: @thesahindia due $250 via NewDot

    @paulnjs can you please accept the job below? Please reply here and tag me once you have.

    ^ Test case created. Thx

    @paulnjs in a dedicated post, can you enter your Upwork details? I'm hoping they'll be saved to send you auto-offers in the future. Thx

    Contributor details
    Your Expensify account email: email@email.com
    Upwork Profile Link: upwork.com/freelancers/~xxxxx

  12. paulnjs commented on May 20, 2026

    @paulnjs
    Contributor

    @mallenexpensify I accepted the job. Thanks.

    in a dedicated post, can you enter your Upwork details? I'm hoping they'll be saved to send you auto-offers in the future. Thx

    Okay, I will add it when post the next proposal

  13. mallenexpensify commented on May 20, 2026

    @mallenexpensify
    Contributor

    @paulnjs paid, summary updated above. Thx.

    Can you add the contributor details to this issue to see if they save? And, in a separate post on this closed issue, tag me to let me know you have? Thx

  14. paulnjs commented on May 21, 2026

    @paulnjs
    Contributor

    Contributor details
    Your Expensify account email: paulqn45@outlook.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~01b14cc7311ec91efa

  15. melvin-bot commented on May 21, 2026

    @melvin-bot

    ⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

  16. paulnjs commented on May 21, 2026

    @paulnjs
    Contributor

    @mallenexpensify I've already posted one here #91136 (comment)

  17. mallenexpensify commented on May 21, 2026

    @mallenexpensify
    Contributor

    Thanks @paulnjs it was helpful cuz the response wasn't what I expected.

  18. garrettmknight commented on Jul 28, 2026

    @garrettmknight
    Contributor

    $250 approved for @thesahindia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions