You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-05-18] [$250] Expense - Unable to create expense in the report after Concierge joins the report #86898
When Concierge replies in a report, the server adds Concierge to the report's participants. The + menu options are determined by getMoneyRequestOptions, which checks whether any EXPENSIFY_ACCOUNT_IDS are among the report's participants. Since Concierge is in EXPENSIFY_ACCOUNT_IDS, the function returns [] — removing all expense options ("Create expense", "Track distance") from the menu.
The "not here" page occurs for the same reason: canCreateRequest delegates to getMoneyRequestOptions, which returns empty, so AccessOrNotFoundWrapper renders NotFoundPage.
The participant list is built at ReportActionCompose.tsx:267-273 from all report.participants keys — it only filters out the current user, not hidden/system participants like Concierge.
What changes do you think we should make in order to solve the problem?
Filter out EXPENSIFY_ACCOUNT_IDS from reportParticipantIDs in ReportActionCompose.tsx before passing them to getMoneyRequestOptions. This way, Concierge being added as a participant won't trigger the Expensify-account check that blocks all expense options.
Alternatively, the filter could be applied inside getMoneyRequestOptions itself — only consider non-system-account participants when deciding whether to block expense creation. The Expensify-account check at ReportUtils.ts:10022 would then use a filtered list that excludes participants with notificationPreference: 'hidden', since system accounts added by the server (like Concierge) typically have this preference.
What alternative solutions did you explore? (Optional)
Removing Concierge from EXPENSIFY_ACCOUNT_IDS is not viable — that constant is used for other legitimate checks. The fix should be scoped to the participant filtering for expense option determination.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
changed the title [-]Expense - Unable to create expense in the report after Concierge joins the report[/-][+][$250] Expense - Unable to create expense in the report after Concierge joins the report[/+]on Apr 13, 2026
The gap existed since the check was first written. It likely became more noticeable as Concierge participation in expense report chats became more common.
Can you add the contributor details to this issue to see if they save? And, in a separate post on this closed issue, tag me to let me know you have? Thx
Activity
MelvinBot commentedon Apr 13, 2026
Proposal
What is the root cause of that problem?
When Concierge replies in a report, the server adds Concierge to the report's
participants. The+menu options are determined bygetMoneyRequestOptions, which checks whether anyEXPENSIFY_ACCOUNT_IDSare among the report's participants. Since Concierge is inEXPENSIFY_ACCOUNT_IDS, the function returns[]— removing all expense options ("Create expense", "Track distance") from the menu.The "not here" page occurs for the same reason:
canCreateRequestdelegates togetMoneyRequestOptions, which returns empty, soAccessOrNotFoundWrapperrendersNotFoundPage.The participant list is built at
ReportActionCompose.tsx:267-273from allreport.participantskeys — it only filters out the current user, not hidden/system participants like Concierge.What changes do you think we should make in order to solve the problem?
Filter out
EXPENSIFY_ACCOUNT_IDSfromreportParticipantIDsinReportActionCompose.tsxbefore passing them togetMoneyRequestOptions. This way, Concierge being added as a participant won't trigger the Expensify-account check that blocks all expense options.Alternatively, the filter could be applied inside
getMoneyRequestOptionsitself — only consider non-system-account participants when deciding whether to block expense creation. The Expensify-account check atReportUtils.ts:10022would then use a filtered list that excludes participants withnotificationPreference: 'hidden', since system accounts added by the server (like Concierge) typically have this preference.What alternative solutions did you explore? (Optional)
Removing Concierge from
EXPENSIFY_ACCOUNT_IDSis not viable — that constant is used for other legitimate checks. The fix should be scoped to the participant filtering for expense option determination.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.melvin-bot commentedon Apr 13, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (
External)[-]Expense - Unable to create expense in the report after Concierge joins the report[/-][+][$250] Expense - Unable to create expense in the report after Concierge joins the report[/+]49 remaining items
thesahindia commentedon May 19, 2026
@MelvinBot, was this a regression? If so, identify the responsible PR.
MelvinBot commentedon May 19, 2026
Not a regression — this was a long-standing gap in
getMoneyRequestOptions.The Expensify-account exclusion check never had carve-outs for policy expense chats or expense reports. The history:
[]fromgetMoneyRequestOptionsdoParticipantsIncludeExpensifyAccountsand added a policy-owner exception, but still no exclusion forisPolicyExpenseChatorisExpenseReportThe gap existed since the check was first written. It likely became more noticeable as Concierge participation in expense report chats became more common.
thesahindia commentedon May 19, 2026
No checklist needed. Test steps are below:
mallenexpensify commentedon May 19, 2026
Payment Summary
Contributor: @paulnjs due $250 via Upwork
Contributor+: @thesahindia due $250 via NewDot
@paulnjs can you please accept the job below? Please reply here and tag me once you have.
^ Test case created. Thx
@paulnjs in a dedicated post, can you enter your Upwork details? I'm hoping they'll be saved to send you auto-offers in the future. Thx
paulnjs commentedon May 20, 2026
@mallenexpensify I accepted the job. Thanks.
Okay, I will add it when post the next proposal
mallenexpensify commentedon May 20, 2026
@paulnjs paid, summary updated above. Thx.
Can you add the contributor details to this issue to see if they save? And, in a separate post on this closed issue, tag me to let me know you have? Thx
paulnjs commentedon May 21, 2026
Contributor details
Your Expensify account email: paulqn45@outlook.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01b14cc7311ec91efa
melvin-bot commentedon May 21, 2026
paulnjs commentedon May 21, 2026
@mallenexpensify I've already posted one here #91136 (comment)
mallenexpensify commentedon May 21, 2026
Thanks @paulnjs it was helpful cuz the response wasn't what I expected.
garrettmknight commentedon Jul 28, 2026
$250 approved for @thesahindia