You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-04-14] [Due for payment 2026-04-14] Reports - Clicking on disabled Submit button opens the expense report when offline #87002
Version Number: 9.3.52-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#86731 Email or phone of affected tester (no customers):jsdjosidjiojisojio3@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Search
Action Performed:
Go to staging.new.expensify.com
Go to workspace chat.
Create an expense.
Go to Reports > Reports.
Go offline.
Click on the disabled Submit button.
Expected Result:
Submit button is disabled. Clicking on it should do nothing.
Actual Result:
Clicking on disabled Submit button opens the expense report when offline.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
When the Submit button is disabled (offline), clicking it still propagates the click event to the parent row pressable, which navigates to the report.
The Button component (src/components/Button/index.tsx:492-494) correctly blocks its own onPress when disabled. However, it does NOT stop event propagation. The underlying GenericPressable (src/components/Pressable/GenericPressable/implementation/BaseGenericPressable.tsx:180) passes disabled={fullDisabled} to the native Pressable, and fullDisabled defaults to false — so the DOM element remains interactive and click events bubble up.
The parent BaseListItem (src/components/SelectionList/ListItem/BaseListItem.tsx:157-165) wraps each row in a PressableWithFeedback that calls onSelectRow(item) on press. When the disabled Submit button swallows the press but doesn't stop propagation, the parent row catches it and navigates to the report.
What changes do you think we should make in order to solve the problem?
In the Button component's onPress handler (src/components/Button/index.tsx:492-494), add e.stopPropagation() before the early return when isDisabled || isLoading is true. This prevents the click from bubbling to the parent row pressable.
What alternative solutions did you explore? (Optional)
Add pointerEventsNone style to ActionCell when offline — rejected because that would make clicks pass through to the parent row, causing the same navigation.
Set fullDisabled={true} on GenericPressable when disabled — this would work but has broader impact across all pressables, with higher risk of unintended side effects.
Add an offline check in BaseListItem's onPress — rejected because BaseListItem is generic and shouldn't know about offline state.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
🤖 Cannot proceed:truph01 does not have write access to the target repository (Expensify/App). MelvinBot will not create branches or PRs on repos that the requesting user cannot access themselves.
changed the title [-]Reports - Clicking on disabled Submit button opens the expense report when offline[/-][+][Due for payment 2026-04-14] Reports - Clicking on disabled Submit button opens the expense report when offline[/+]on Apr 7, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.52-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@luacmartins The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
changed the title [-][Due for payment 2026-04-14] Reports - Clicking on disabled Submit button opens the expense report when offline[/-][+][Due for payment 2026-04-14] [Due for payment 2026-04-14] Reports - Clicking on disabled Submit button opens the expense report when offline[/+]on Apr 7, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.53-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@luacmartins@mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Apr 2, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #86738
melvin-bot commentedon Apr 2, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 2, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Apr 2, 2026
Proposal
What is the root cause of that problem?
When the Submit button is disabled (offline), clicking it still propagates the click event to the parent row pressable, which navigates to the report.
The Button component (
src/components/Button/index.tsx:492-494) correctly blocks its ownonPresswhen disabled. However, it does NOT stop event propagation. The underlyingGenericPressable(src/components/Pressable/GenericPressable/implementation/BaseGenericPressable.tsx:180) passesdisabled={fullDisabled}to the native Pressable, andfullDisableddefaults tofalse— so the DOM element remains interactive and click events bubble up.The parent
BaseListItem(src/components/SelectionList/ListItem/BaseListItem.tsx:157-165) wraps each row in aPressableWithFeedbackthat callsonSelectRow(item)on press. When the disabled Submit button swallows the press but doesn't stop propagation, the parent row catches it and navigates to the report.What changes do you think we should make in order to solve the problem?
In the Button component's
onPresshandler (src/components/Button/index.tsx:492-494), adde.stopPropagation()before the early return whenisDisabled || isLoadingis true. This prevents the click from bubbling to the parent row pressable.What alternative solutions did you explore? (Optional)
pointerEventsNonestyle to ActionCell when offline — rejected because that would make clicks pass through to the parent row, causing the same navigation.fullDisabled={true}on GenericPressable when disabled — this would work but has broader impact across all pressables, with higher risk of unintended side effects.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.truph01 commentedon Apr 3, 2026
@MelvinBot Create PR to revert #86731
MelvinBot commentedon Apr 3, 2026
🤖 Cannot proceed:
truph01does not have write access to the target repository (Expensify/App). MelvinBot will not create branches or PRs on repos that the requesting user cannot access themselves.truph01 commentedon Apr 3, 2026
I raised a revert PR #87062
3 remaining items
luacmartins commentedon Apr 6, 2026
Thanks for handling this!
[-]Reports - Clicking on disabled Submit button opens the expense report when offline[/-][+][Due for payment 2026-04-14] Reports - Clicking on disabled Submit button opens the expense report when offline[/+]melvin-bot commentedon Apr 7, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.52-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-04-14. 🎊
melvin-bot commentedon Apr 7, 2026
@luacmartins The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Apr 7, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)[-][Due for payment 2026-04-14] Reports - Clicking on disabled Submit button opens the expense report when offline[/-][+][Due for payment 2026-04-14] [Due for payment 2026-04-14] Reports - Clicking on disabled Submit button opens the expense report when offline[/+]melvin-bot commentedon Apr 7, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.53-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-04-14. 🎊
melvin-bot commentedon Apr 7, 2026
@luacmartins @mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]