You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Expense - Attendees field does not update to custom avatar #87005
Version Number: 9.3.52-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#85332 Email or phone of affected tester (no customers):jsoidjniosdjoisnjdisoj@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Rules are enabled.
Attendee tracking is enabled in Rules.
Account does not have custom avatar.
Go to staging.new.expensify.com
Go to workspace chat.
Create two expenses.
Go to Account > Profile.
Upload a custom avatar.
Go to Inbox.
Open the expense report from Step 3.
Expected Result:
Attendees field will show the custom avatar.
Actual Result:
Attendees field still shows default avatar after uploading custom avatar.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
When attendees are added to an expense, their avatar URL is captured as a snapshot and stored in transaction.comment.attendees[].avatarUrl (see TransactionUtils/index.ts:1180). When the user later uploads a custom avatar, personalDetails in Onyx updates but the stored attendee data in the transaction does not.
AttendeesCell.tsx:33 resolves avatars as:
attendee.avatarUrl || getDefaultAvatar(...)
So it uses the stale stored URL (which was the default avatar at creation time) instead of the user's current avatar from personalDetails.
What changes do you think we should make in order to solve the problem?
In AttendeesCell.tsx, when building attendeeIcons, prefer the live avatar from personalDetails (already fetched on line 42) over the stale attendee.avatarUrl stored in the transaction.
When an attendee.accountID is available and matches an entry in personalDetails, use personalDetails[accountID].avatar (or avatarThumbnail) instead of attendee.avatarUrl. Fall back to attendee.avatarUrl only when the attendee has no matching personal details entry (e.g., external attendees without an Expensify account).
Investigation details
Data flow:
getReportOwnerAsAttendee() (TransactionUtils/index.ts:1155-1185) captures creatorDetails.avatarThumbnail ?? creatorDetails.avatar at expense creation time and stores it in avatarUrl
getAttendees() (TransactionUtils/index.ts:1207-1216) returns stored attendees from transaction.comment.attendees — these contain the stale avatarUrl
TransactionItemRow (line 277) passes these to AttendeesCell
AttendeesCell (line 33) uses the stale avatarUrl first, only falling back to getDefaultAvatar() if it's empty
Why getDefaultAvatar fallback doesn't help: If the user had a default SVG avatar (no uploaded photo), the stored avatarUrl would be an empty string, and getDefaultAvatar would generate the correct colored default. But once a user uploads an avatar and the transaction already has attendees stored, the stored avatarUrl still points to the old value.
Note:personalDetails is already available in AttendeesCell (line 42) — it's used for sorting but not for avatar resolution.
What alternative solutions did you explore?
An alternative would be to update the stored avatarUrl in all transactions whenever a user changes their avatar (via an Onyx subscriber or API-side). This would be more complex and less efficient since it requires updating potentially many transactions, whereas the rendering-layer fix is simple and always shows the latest data.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
@justinpersaud this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
Activity
melvin-bot commentedon Apr 2, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #85332
melvin-bot commentedon Apr 2, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 2, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Apr 2, 2026
Proposal
What is the root cause of that problem?
When attendees are added to an expense, their avatar URL is captured as a snapshot and stored in
transaction.comment.attendees[].avatarUrl(seeTransactionUtils/index.ts:1180). When the user later uploads a custom avatar,personalDetailsin Onyx updates but the stored attendee data in the transaction does not.AttendeesCell.tsx:33resolves avatars as:So it uses the stale stored URL (which was the default avatar at creation time) instead of the user's current avatar from
personalDetails.What changes do you think we should make in order to solve the problem?
In
AttendeesCell.tsx, when buildingattendeeIcons, prefer the live avatar frompersonalDetails(already fetched on line 42) over the staleattendee.avatarUrlstored in the transaction.When an
attendee.accountIDis available and matches an entry inpersonalDetails, usepersonalDetails[accountID].avatar(oravatarThumbnail) instead ofattendee.avatarUrl. Fall back toattendee.avatarUrlonly when the attendee has no matching personal details entry (e.g., external attendees without an Expensify account).Investigation details
Data flow:
getReportOwnerAsAttendee()(TransactionUtils/index.ts:1155-1185) capturescreatorDetails.avatarThumbnail ?? creatorDetails.avatarat expense creation time and stores it inavatarUrlgetAttendees()(TransactionUtils/index.ts:1207-1216) returns stored attendees fromtransaction.comment.attendees— these contain the staleavatarUrlTransactionItemRow(line 277) passes these toAttendeesCellAttendeesCell(line 33) uses the staleavatarUrlfirst, only falling back togetDefaultAvatar()if it's emptyWhy
getDefaultAvatarfallback doesn't help: If the user had a default SVG avatar (no uploaded photo), the storedavatarUrlwould be an empty string, andgetDefaultAvatarwould generate the correct colored default. But once a user uploads an avatar and the transaction already has attendees stored, the storedavatarUrlstill points to the old value.Note:
personalDetailsis already available inAttendeesCell(line 42) — it's used for sorting but not for avatar resolution.What alternative solutions did you explore?
An alternative would be to update the stored
avatarUrlin all transactions whenever a user changes their avatar (via an Onyx subscriber or API-side). This would be more complex and less efficient since it requires updating potentially many transactions, whereas the rendering-layer fix is simple and always shows the latest data.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.nkdengineer commentedon Apr 3, 2026
@justinpersaud We can demote this, we discussed about this in the PR and it's a backend issue.
justinpersaud commentedon Apr 3, 2026
Demoting. I will get someone to work on this in the backend.
melvin-bot commentedon Apr 16, 2026
@justinpersaud this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
justinpersaud commentedon Apr 20, 2026
No update yet
justinpersaud commentedon Apr 24, 2026
@NicolasBonet would you be interesting in working on this one?
The issue stems from a new feature added here #85332
Here is a video of the issue #85332 (comment)
NicolasBonet commentedon Apr 24, 2026
I have a few issues already, let me circle back as soon as finish the ones I've assigned as part of the onboarding 🙏
justinpersaud commentedon May 4, 2026
No update
justinpersaud commentedon May 8, 2026
Turns out this was already fixed in
#87705