Skip to content

Expense - Attendees field does not update to custom avatar #87005

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.52-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #85332
Email or phone of affected tester (no customers): jsoidjniosdjoisnjdisoj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Rules are enabled.
  • Attendee tracking is enabled in Rules.
  • Account does not have custom avatar.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create two expenses.
  4. Go to Account > Profile.
  5. Upload a custom avatar.
  6. Go to Inbox.
  7. Open the expense report from Step 3.

Expected Result:

Attendees field will show the custom avatar.

Actual Result:

Attendees field still shows default avatar after uploading custom avatar.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Video.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 2, 2026
  2. melvin-bot commented on Apr 2, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #85332

  3. melvin-bot commented on Apr 2, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on Apr 2, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. MelvinBot commented on Apr 2, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    When attendees are added to an expense, their avatar URL is captured as a snapshot and stored in transaction.comment.attendees[].avatarUrl (see TransactionUtils/index.ts:1180). When the user later uploads a custom avatar, personalDetails in Onyx updates but the stored attendee data in the transaction does not.

    AttendeesCell.tsx:33 resolves avatars as:

    attendee.avatarUrl || getDefaultAvatar(...)
    

    So it uses the stale stored URL (which was the default avatar at creation time) instead of the user's current avatar from personalDetails.

    What changes do you think we should make in order to solve the problem?

    In AttendeesCell.tsx, when building attendeeIcons, prefer the live avatar from personalDetails (already fetched on line 42) over the stale attendee.avatarUrl stored in the transaction.

    When an attendee.accountID is available and matches an entry in personalDetails, use personalDetails[accountID].avatar (or avatarThumbnail) instead of attendee.avatarUrl. Fall back to attendee.avatarUrl only when the attendee has no matching personal details entry (e.g., external attendees without an Expensify account).

    Investigation details

    Data flow:

    1. getReportOwnerAsAttendee() (TransactionUtils/index.ts:1155-1185) captures creatorDetails.avatarThumbnail ?? creatorDetails.avatar at expense creation time and stores it in avatarUrl
    2. getAttendees() (TransactionUtils/index.ts:1207-1216) returns stored attendees from transaction.comment.attendees — these contain the stale avatarUrl
    3. TransactionItemRow (line 277) passes these to AttendeesCell
    4. AttendeesCell (line 33) uses the stale avatarUrl first, only falling back to getDefaultAvatar() if it's empty

    Why getDefaultAvatar fallback doesn't help: If the user had a default SVG avatar (no uploaded photo), the stored avatarUrl would be an empty string, and getDefaultAvatar would generate the correct colored default. But once a user uploads an avatar and the transaction already has attendees stored, the stored avatarUrl still points to the old value.

    Note: personalDetails is already available in AttendeesCell (line 42) — it's used for sorting but not for avatar resolution.

    What alternative solutions did you explore?

    An alternative would be to update the stored avatarUrl in all transactions whenever a user changes their avatar (via an Onyx subscriber or API-side). This would be more complex and less efficient since it requires updating potentially many transactions, whereas the rendering-layer fix is simple and always shows the latest data.


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  6. nkdengineer commented on Apr 3, 2026

    @nkdengineer
    Contributor

    @justinpersaud We can demote this, we discussed about this in the PR and it's a backend issue.

  7. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 3, 2026
  8. justinpersaud commented on Apr 3, 2026

    @justinpersaud
    Contributor

    Demoting. I will get someone to work on this in the backend.

  9. melvin-bot commented on Apr 16, 2026

    @melvin-bot

    @justinpersaud this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  10. justinpersaud commented on Apr 20, 2026

    @justinpersaud
    Contributor

    No update yet

  11. justinpersaud commented on Apr 24, 2026

    @justinpersaud
    Contributor

    @NicolasBonet would you be interesting in working on this one?

    The issue stems from a new feature added here #85332

    Here is a video of the issue #85332 (comment)

  12. NicolasBonet commented on Apr 24, 2026

    @NicolasBonet
    Contributor

    @NicolasBonet would you be interesting in working on this one?

    The issue stems from a new feature added here #85332

    Here is a video of the issue #85332 (comment)

    I have a few issues already, let me circle back as soon as finish the ones I've assigned as part of the onboarding 🙏

  13. justinpersaud commented on May 4, 2026

    @justinpersaud
    Contributor

    No update

  14. justinpersaud commented on May 8, 2026

    @justinpersaud
    Contributor

    Turns out this was already fixed in

    #87705

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions