You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-04-14] Expense - Per attendee amount on the table does not show negative sign #87006
Version Number: 9.3.52-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#85332 Email or phone of affected tester (no customers):sdiodjoisjnodisj@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Rules are enabled.
Attendee tracking is enabled in Rules.
Go to staging.new.expensify.com
Go to workspace chat.
Create two expenses with negative amount and at least two attendees.
Open the expense report.
Expected Result:
Per attendee amount on the table will show negative sign.
Actual Result:
Per attendee amount on the table does not show negative sign.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
The main total column correctly preserves the sign because it calls isExpenseReport(transactionItem.report) (e.g., line 591), but the per-attendee calculation at line 283 omits this.
What changes do you think we should make in order to solve the problem?
Pass the isFromExpenseReport flag when calling getAmount in the totalPerAttendee calculation at TransactionItemRow/index.tsx:283:
Change getAmount(transactionItem) to getAmount(transactionItem, isExpenseReport(transactionItem.report)).
isExpenseReport is already imported and used elsewhere in the same file, so no new imports are needed.
What alternative solutions did you explore? (Optional)
Could use the allowNegative parameter instead (getAmount(transactionItem, false, false, true)), but passing isFromExpenseReport is more correct — it mirrors how the total amount column handles this and ensures proper sign handling for expense reports specifically.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.53-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@justinpersaud The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
Activity
melvin-bot commentedon Apr 2, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #85332
melvin-bot commentedon Apr 2, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 2, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Apr 2, 2026
Proposal
What is the root cause of that problem?
In
src/components/TransactionItemRow/index.tsx:283,getAmount(transactionItem)is called without passingisFromExpenseReport, so it defaults tofalse. This causesgetAmountinTransactionUtils/index.ts:956-962to hit theMath.abs()branch, which strips the negative sign from the amount before dividing by attendee count.The main total column correctly preserves the sign because it calls
isExpenseReport(transactionItem.report)(e.g., line 591), but the per-attendee calculation at line 283 omits this.What changes do you think we should make in order to solve the problem?
Pass the
isFromExpenseReportflag when callinggetAmountin thetotalPerAttendeecalculation atTransactionItemRow/index.tsx:283:Change
getAmount(transactionItem)togetAmount(transactionItem, isExpenseReport(transactionItem.report)).isExpenseReportis already imported and used elsewhere in the same file, so no new imports are needed.What alternative solutions did you explore? (Optional)
Could use the
allowNegativeparameter instead (getAmount(transactionItem, false, false, true)), but passingisFromExpenseReportis more correct — it mirrors how the total amount column handles this and ensures proper sign handling for expense reports specifically.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.justinpersaud commentedon Apr 2, 2026
@MelvinBot is it normal to allow negative expenses?
justinpersaud commentedon Apr 2, 2026
I am demoting this because this is a newer feature
17 remaining items
melvin-bot commentedon Apr 7, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 7, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.53-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-04-14. 🎊
melvin-bot commentedon Apr 7, 2026
@justinpersaud The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Apr 7, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Apr 14, 2026
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
mallenexpensify commentedon Apr 16, 2026
Checking here if it's a regression
nkdengineer commentedon Apr 16, 2026
@mallenexpensify It's regression. We can close this out.