Skip to content

[Due for payment 2026-04-16] Reports - Custom range error message is not visible without scrolling #87019

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.3.52-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #85313
Email or phone of affected tester (no customers): n/a
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Mac 15.4.1 Safari
App Component: Search

Action Performed:

  1. Go to https://staging.new.expensify.com
  2. Navigate to Reports > Filters options from top bar
  3. Click on any date filter (Date, Approved, Paid, Submitted, Withdrawn, Posted, Exported)
  4. Click on the "Custom Range" option from the menu
  5. Click Save without selecting dates

Expected Result:

The error message should be visible without scrolling.

Actual Result:

The error message appears in the bottom and the user needs to scroll down to see

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7120198_1775163078729.Recording__1936.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Apr 2, 2026
  2. melvin-bot commented on Apr 2, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #85313

  3. melvin-bot commented on Apr 2, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on Apr 2, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. MelvinBot commented on Apr 2, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    In DateFilterBase.tsx, the layout places DatePresetFilterBase (which contains the RangeDatePicker with two vertically-stacked calendars AND the error message) inside a ScrollView, while the Save/Reset buttons sit outside it. When Save is pressed without selecting dates, validate() sets shouldShowRangeError=true, which renders a FormHelpMessage after both calendar pickers inside the ScrollView (RangeDatePicker.tsx:80-86). The two vertically-stacked calendars (forced by forceVerticalCalendars at DateFilterBase.tsx:216) consume all visible vertical space, so the error is pushed below the fold with no auto-scroll.

    Key code references
    • src/components/Search/FilterComponents/DateFilterBase.tsx:202-224 — ScrollView wrapping DatePresetFilterBase
    • src/components/Search/FilterComponents/RangeDatePicker.tsx:80-86 — FormHelpMessage rendered after both CalendarPickers
    • src/components/Search/FilterComponents/DateFilterBase.tsx:169-177 — save() calls validate() but never scrolls to error
    • src/components/Search/FilterComponents/DateFilterBase.tsx:216 — forceVerticalCalendars forces both calendars to stack vertically

    What changes do you think we should make in order to solve the problem?

    Move the error display from inside the ScrollView (in RangeDatePicker) to the FormAlertWithSubmitButton that already sits outside the ScrollView in DateFilterBase.tsx:233-238. This component already supports an isAlertVisible prop — pass shouldShowRangeError to it and add the error message. Then remove the FormHelpMessage from RangeDatePicker since the error will be shown next to the Save button where it's always visible.

    What alternative solutions did you explore?

    1. Auto-scroll to error — Add a scrollToEnd call when validation fails. This works but is a worse UX pattern; showing the error next to the action button is more intuitive.
    2. Move error above calendars — Would be visible but unconventional placement and disconnected from the Save action.

    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  6. neil-marcellini commented on Apr 2, 2026

    @neil-marcellini
    Contributor

    I think this probably doesn't need to be a blocker, but I'm asking the deployer what they think for a second optinion.

    @btkcodedev FYI

    @MelvinBot pls implement this

  7. 15 remaining items

  8. melvin-bot commented on Apr 9, 2026

    @melvin-bot

    @neil-marcellini The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  9. melvin-bot commented on Apr 9, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  10. neil-marcellini commented on Apr 15, 2026

    @neil-marcellini
    Contributor

    Not overdue. Payment needed. I don't think we need a bug zero checklist because this was related to a new feature.

  11. melvin-bot commented on Apr 16, 2026

    @melvin-bot

    Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

  12. mallenexpensify commented on Apr 17, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @brunovjk due $250 via NewDot
    Contributor+: @parasharrajat due $250 via NewDot

  13. laurenreidexpensify commented on Apr 20, 2026

    @laurenreidexpensify
    Contributor

    @brunovjk $250 approved in New Expensify

  14. parasharrajat commented on Jul 5, 2026

    @parasharrajat
    Member

    Payment requested as per #87019 (comment)

  15. garrettmknight commented on Jul 6, 2026

    @garrettmknight
    Contributor

    $250 approved for @parasharrajat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions