You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-04-16] Reports - Custom range error message is not visible without scrolling #87019
Version Number: v9.3.52-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#85313 Email or phone of affected tester (no customers): n/a Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: Mac 15.4.1 Safari App Component: Search
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
In DateFilterBase.tsx, the layout places DatePresetFilterBase (which contains the RangeDatePicker with two vertically-stacked calendars AND the error message) inside a ScrollView, while the Save/Reset buttons sit outside it. When Save is pressed without selecting dates, validate() sets shouldShowRangeError=true, which renders a FormHelpMessageafter both calendar pickers inside the ScrollView (RangeDatePicker.tsx:80-86). The two vertically-stacked calendars (forced by forceVerticalCalendars at DateFilterBase.tsx:216) consume all visible vertical space, so the error is pushed below the fold with no auto-scroll.
src/components/Search/FilterComponents/RangeDatePicker.tsx:80-86 — FormHelpMessage rendered after both CalendarPickers
src/components/Search/FilterComponents/DateFilterBase.tsx:169-177 — save() calls validate() but never scrolls to error
src/components/Search/FilterComponents/DateFilterBase.tsx:216 — forceVerticalCalendars forces both calendars to stack vertically
What changes do you think we should make in order to solve the problem?
Move the error display from inside the ScrollView (in RangeDatePicker) to the FormAlertWithSubmitButton that already sits outside the ScrollView in DateFilterBase.tsx:233-238. This component already supports an isAlertVisible prop — pass shouldShowRangeError to it and add the error message. Then remove the FormHelpMessage from RangeDatePicker since the error will be shown next to the Save button where it's always visible.
What alternative solutions did you explore?
Auto-scroll to error — Add a scrollToEnd call when validation fails. This works but is a worse UX pattern; showing the error next to the action button is more intuitive.
Move error above calendars — Would be visible but unconventional placement and disconnected from the Save action.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
@neil-marcellini The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
Activity
melvin-bot commentedon Apr 2, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #85313
melvin-bot commentedon Apr 2, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 2, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Apr 2, 2026
Proposal
What is the root cause of that problem?
In
DateFilterBase.tsx, the layout placesDatePresetFilterBase(which contains theRangeDatePickerwith two vertically-stacked calendars AND the error message) inside aScrollView, while the Save/Reset buttons sit outside it. When Save is pressed without selecting dates,validate()setsshouldShowRangeError=true, which renders aFormHelpMessageafter both calendar pickers inside theScrollView(RangeDatePicker.tsx:80-86). The two vertically-stacked calendars (forced byforceVerticalCalendarsatDateFilterBase.tsx:216) consume all visible vertical space, so the error is pushed below the fold with no auto-scroll.Key code references
src/components/Search/FilterComponents/DateFilterBase.tsx:202-224— ScrollView wrapping DatePresetFilterBasesrc/components/Search/FilterComponents/RangeDatePicker.tsx:80-86— FormHelpMessage rendered after both CalendarPickerssrc/components/Search/FilterComponents/DateFilterBase.tsx:169-177—save()callsvalidate()but never scrolls to errorsrc/components/Search/FilterComponents/DateFilterBase.tsx:216—forceVerticalCalendarsforces both calendars to stack verticallyWhat changes do you think we should make in order to solve the problem?
Move the error display from inside the
ScrollView(inRangeDatePicker) to theFormAlertWithSubmitButtonthat already sits outside theScrollViewinDateFilterBase.tsx:233-238. This component already supports anisAlertVisibleprop — passshouldShowRangeErrorto it and add the error message. Then remove theFormHelpMessagefromRangeDatePickersince the error will be shown next to the Save button where it's always visible.What alternative solutions did you explore?
scrollToEndcall when validation fails. This works but is a worse UX pattern; showing the error next to the action button is more intuitive.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.neil-marcellini commentedon Apr 2, 2026
I think this probably doesn't need to be a blocker, but I'm asking the deployer what they think for a second optinion.
@btkcodedev FYI
@MelvinBot pls implement this
15 remaining items
melvin-bot commentedon Apr 9, 2026
@neil-marcellini The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Apr 9, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)neil-marcellini commentedon Apr 15, 2026
Not overdue. Payment needed. I don't think we need a bug zero checklist because this was related to a new feature.
melvin-bot commentedon Apr 16, 2026
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
mallenexpensify commentedon Apr 17, 2026
Payment Summary
Contributor+: @brunovjk due $250 via NewDot
Contributor+: @parasharrajat due $250 via NewDot
laurenreidexpensify commentedon Apr 20, 2026
@brunovjk $250 approved in New Expensify
parasharrajat commentedon Jul 5, 2026
Payment requested as per #87019 (comment)
garrettmknight commentedon Jul 6, 2026
$250 approved for @parasharrajat