Skip to content

[Due for payment 2026-04-30] Android - Chat - Suggestion modal appear at the bottom and blocks composer #87309

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.54-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #85229
Email or phone of affected tester (no customers): jsdjosidjiojisojio3@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Samsung Galaxy S25 FE / Android 16
App Component: Chat Report View

Action Performed:

  1. Launch Expensify app in landscape mode.
  2. Go to any chat.
  3. Type :sm
  4. Tap device back button to dismiss the keyboard.

Expected Result:

Suggestion modal will appear above the composer so user can easily scroll through the list.

Actual Result:

Suggestion modal appear at the bottom and blocks composer.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7124266_1775609054317.07.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Apr 8, 2026
  2. melvin-bot commented on Apr 8, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #85229

  3. melvin-bot commented on Apr 8, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on Apr 8, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. OSBotify commented on Apr 8, 2026

    @OSBotify
    Contributor

    Investigation Summary

    Classification: Frontend bug
    Causing PR: #85229 - "Unlock landscape mode" by @GCyganek (High confidence)
    Related Issues: N/A

    Recommendation: REVERT

    PR #85229 unlocked landscape mode for phones on Android and iOS. The suggestion modal position calculation does not correctly handle the landscape orientation on Android when the keyboard is dismissed, causing the modal to appear at the bottom and block the composer.

    Assigned: @GCyganek (PR author), @rushatgabhane, @truph01, @mjasikowski (approving reviewers)
    Labels: Both DeployBlockerCash and DeployBlocker are present. Removing DeployBlocker since this is a frontend (App) bug requiring an App fix, not a backend fix.

    Detailed Analysis

    Evidence

    • The issue is reproducible on staging (version 9.3.54-0) and is listed as a new feature (landscape mode was not previously supported), so it does not exist in production.
    • The melvin-bot directly attributed this to PR Unlock landscape mode #85229 in the first comment.
    • PR Unlock landscape mode #85229 is explicitly referenced in the issue body under the regression test link.
    • The PR unlocked landscape mode by removing portrait-only orientation locks in android/app/src/main/java/com/expensify/chat/MainActivity.kt, android/app/src/main/res/values/orientation.xml, and related files.

    Verification

    • Affected area: AutoCompleteSuggestions portal on Android in landscape mode.
    • The suggestion portal position (bottom) is calculated in src/components/AutoCompleteSuggestions/index.tsx (line 100) as: let bottomValue = windowHeight - (cursorCoordinates.y - scrollValue + y) - keyboardHeight;
    • When the keyboard is dismissed in landscape mode via the back button, keyboardHeight becomes 0, and the landscape windowHeight is significantly smaller (since width/height swap). This causes the bottomValue to be calculated incorrectly, placing the suggestion modal at or below the composer instead of above it.
    • The Android-specific getBottomSuggestionPadding in src/components/AutoCompleteSuggestions/AutoCompleteSuggestionsPortal/getBottomSuggestionPadding/index.android.ts also uses Dimensions.get("window").height for its calculation, which changes when the device rotates to landscape.
    • PR Unlock landscape mode #85229 modifies android/app/src/main/java/com/expensify/chat/MainActivity.kt, android/app/src/main/res/values/orientation.xml, and adds landscape mode-specific layout logic across many components, but the suggestion modal positioning was not addressed.

    Root Cause

    Before PR #85229, Android phones were locked to portrait orientation, so the suggestion modal position calculation only ever needed to handle portrait dimensions. After the PR unlocked landscape mode, the suggestion modal position is computed with the landscape window height (shorter than portrait height). When the keyboard is dismissed via the hardware back button in landscape mode, the keyboardHeight drops to 0 but the cursor/layout positions are still measured relative to the landscape layout. The resulting bottomValue becomes incorrect, causing the suggestion modal to appear at the bottom of the screen overlapping the composer rather than floating above it.

  6. removed
    DeployBlockerIndicates it should block deploying the API
    on Apr 8, 2026
  7. 20 remaining items

  8. melvin-bot commented on Apr 23, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  9. melvin-bot commented on Apr 23, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.61-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-04-30. 🎊

    For reference, here are some details about the assignees on this issue:

    • @GCyganek does not require payment (Contractor)
    • @truph01 requires payment through NewDot Manual Requests
  10. melvin-bot commented on Apr 23, 2026

    @melvin-bot

    @truph01 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  11. melvin-bot commented on Apr 28, 2026

    @melvin-bot

    @truph01 Huh... This is 4 days overdue. Who can take care of this?

  12. GCyganek commented on Apr 29, 2026

    @GCyganek
    Contributor

    deployed to production

  13. melvin-bot commented on Apr 29, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  14. melvin-bot commented on Apr 29, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  15. melvin-bot commented on Apr 30, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @GCyganek does not require payment (Contractor)
    • Reviewer: @truph01 owed $250 via NewDot

    BugZero Checklist (@mallenexpensify)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  16. mallenexpensify commented on May 1, 2026

    @mallenexpensify
    Contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions