You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-04-30] Android - Chat - Suggestion modal appear at the bottom and blocks composer #87309
Version Number: 9.3.54-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#85229 Email or phone of affected tester (no customers):jsdjosidjiojisojio3@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Samsung Galaxy S25 FE / Android 16 App Component: Chat Report View
Action Performed:
Launch Expensify app in landscape mode.
Go to any chat.
Type :sm
Tap device back button to dismiss the keyboard.
Expected Result:
Suggestion modal will appear above the composer so user can easily scroll through the list.
Actual Result:
Suggestion modal appear at the bottom and blocks composer.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #85229 - "Unlock landscape mode" by @GCyganek (High confidence) Related Issues: N/A
Recommendation: REVERT
PR #85229 unlocked landscape mode for phones on Android and iOS. The suggestion modal position calculation does not correctly handle the landscape orientation on Android when the keyboard is dismissed, causing the modal to appear at the bottom and block the composer.
Assigned: @GCyganek (PR author), @rushatgabhane, @truph01, @mjasikowski (approving reviewers) Labels: Both DeployBlockerCash and DeployBlocker are present. Removing DeployBlocker since this is a frontend (App) bug requiring an App fix, not a backend fix.
Detailed Analysis
Evidence
The issue is reproducible on staging (version 9.3.54-0) and is listed as a new feature (landscape mode was not previously supported), so it does not exist in production.
The PR unlocked landscape mode by removing portrait-only orientation locks in android/app/src/main/java/com/expensify/chat/MainActivity.kt, android/app/src/main/res/values/orientation.xml, and related files.
Verification
Affected area: AutoCompleteSuggestions portal on Android in landscape mode.
The suggestion portal position (bottom) is calculated in src/components/AutoCompleteSuggestions/index.tsx (line 100) as: let bottomValue = windowHeight - (cursorCoordinates.y - scrollValue + y) - keyboardHeight;
When the keyboard is dismissed in landscape mode via the back button, keyboardHeight becomes 0, and the landscape windowHeight is significantly smaller (since width/height swap). This causes the bottomValue to be calculated incorrectly, placing the suggestion modal at or below the composer instead of above it.
The Android-specific getBottomSuggestionPadding in src/components/AutoCompleteSuggestions/AutoCompleteSuggestionsPortal/getBottomSuggestionPadding/index.android.ts also uses Dimensions.get("window").height for its calculation, which changes when the device rotates to landscape.
PR Unlock landscape mode #85229 modifies android/app/src/main/java/com/expensify/chat/MainActivity.kt, android/app/src/main/res/values/orientation.xml, and adds landscape mode-specific layout logic across many components, but the suggestion modal positioning was not addressed.
Root Cause
Before PR #85229, Android phones were locked to portrait orientation, so the suggestion modal position calculation only ever needed to handle portrait dimensions. After the PR unlocked landscape mode, the suggestion modal position is computed with the landscape window height (shorter than portrait height). When the keyboard is dismissed via the hardware back button in landscape mode, the keyboardHeight drops to 0 but the cursor/layout positions are still measured relative to the landscape layout. The resulting bottomValue becomes incorrect, causing the suggestion modal to appear at the bottom of the screen overlapping the composer rather than floating above it.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.61-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@truph01 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Apr 8, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #85229
melvin-bot commentedon Apr 8, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 8, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Apr 8, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #85229 - "Unlock landscape mode" by @GCyganek (High confidence)
Related Issues: N/A
Recommendation: REVERT
PR #85229 unlocked landscape mode for phones on Android and iOS. The suggestion modal position calculation does not correctly handle the landscape orientation on Android when the keyboard is dismissed, causing the modal to appear at the bottom and block the composer.
Assigned: @GCyganek (PR author), @rushatgabhane, @truph01, @mjasikowski (approving reviewers)
Labels: Both
DeployBlockerCashandDeployBlockerare present. RemovingDeployBlockersince this is a frontend (App) bug requiring an App fix, not a backend fix.Detailed Analysis
Evidence
android/app/src/main/java/com/expensify/chat/MainActivity.kt,android/app/src/main/res/values/orientation.xml, and related files.Verification
AutoCompleteSuggestionsportal on Android in landscape mode.bottom) is calculated insrc/components/AutoCompleteSuggestions/index.tsx(line 100) as:let bottomValue = windowHeight - (cursorCoordinates.y - scrollValue + y) - keyboardHeight;keyboardHeightbecomes 0, and the landscapewindowHeightis significantly smaller (since width/height swap). This causes thebottomValueto be calculated incorrectly, placing the suggestion modal at or below the composer instead of above it.getBottomSuggestionPaddinginsrc/components/AutoCompleteSuggestions/AutoCompleteSuggestionsPortal/getBottomSuggestionPadding/index.android.tsalso usesDimensions.get("window").heightfor its calculation, which changes when the device rotates to landscape.android/app/src/main/java/com/expensify/chat/MainActivity.kt,android/app/src/main/res/values/orientation.xml, and adds landscape mode-specific layout logic across many components, but the suggestion modal positioning was not addressed.Root Cause
Before PR #85229, Android phones were locked to portrait orientation, so the suggestion modal position calculation only ever needed to handle portrait dimensions. After the PR unlocked landscape mode, the suggestion modal position is computed with the landscape window height (shorter than portrait height). When the keyboard is dismissed via the hardware back button in landscape mode, the
keyboardHeightdrops to 0 but the cursor/layout positions are still measured relative to the landscape layout. The resultingbottomValuebecomes incorrect, causing the suggestion modal to appear at the bottom of the screen overlapping the composer rather than floating above it.20 remaining items
melvin-bot commentedon Apr 23, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 23, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.61-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-04-30. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 23, 2026
@truph01 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Apr 28, 2026
@truph01 Huh... This is 4 days overdue. Who can take care of this?
GCyganek commentedon Apr 29, 2026
deployed to production
melvin-bot commentedon Apr 29, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Apr 29, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Apr 30, 2026
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon May 1, 2026
@truph01 Will be paid in