You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-04-28] [$250] Android & iOS - Wallet - "Need to add company cards?" icon is blank on native apps #87665
Version Number: 9.3.58-1 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:#83211 Email or phone of affected tester (no customers):jsdjosidjiojisojio3@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Samsung Galaxy S25 FE / Android 16 App Component: User Settings
Action Performed:
Launch Expensify app.
Go to Account > Wallet.
Scroll down to Assigned cards.
Expected Result:
"Need to add company cards?" icon will not be blank on native apps.
Actual Result:
"Need to add company cards?" icon is blank on native apps.
The MenuItem rendering the "Need to add company cards?" illustration forces a monochrome fill color onto the icon, which breaks multi-color SVG illustrations on native platforms.
In WalletPage/index.tsx, the MenuItem is rendered with icon={illustrations.VerticalCreditCards} but without displayInDefaultIconColor or a custom iconFill. Since displayInDefaultIconColor defaults to false, MenuItem.tsx sets fill to StyleUtils.getIconFillColor(...) (a solid theme color).
On web, the SVG is rendered as a React component via SVGR, and the CSS <style> classes in the SVG (.st0{fill:#e4bc07}, .st3{fill:#ff7101}, etc.) take precedence over the fill prop — so the illustration displays correctly with its original colors.
On native (Android/iOS), the SVG asset is rendered via expo-image in ImageSVG/index.android.tsx with tintColor={fill}. Since the native SVG decoder doesn't fully process CSS <style> class-based fills, the paths are effectively transparent, and tintColor has nothing to colorize — resulting in a blank icon.
What changes do you think we should make in order to solve the problem?
Pass displayInDefaultIconColor to the MenuItem in WalletPage/index.tsx so that no fill/tintColor is forced onto the illustration:
This prevents MenuItem from injecting a theme fill color, allowing the illustration to render with its original multi-color SVG fills on native — matching the web behavior.
What alternative solutions did you explore? (Optional)
Converting the SVG to use inline fill attributes instead of CSS <style> classes — this would be a more systemic fix but higher risk since inlineStyles is already explicitly disabled in compressSvg.ts due to known Android fill issues.
Passing iconFill={undefined} explicitly — this would also work but displayInDefaultIconColor is the intended API for this purpose and is more readable.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
changed the title [-]Android & iOS - Wallet - "Need to add company cards?" icon is blank on native apps[/-][+][$250] Android & iOS - Wallet - "Need to add company cards?" icon is blank on native apps[/+]on Apr 10, 2026
Please re-state the problem that we are trying to solve in this issue.
The "Need to add company cards?" icon is blank/invisible on native apps (Android and iOS) in the Wallet page.
What is the root cause of that problem?
The SVG file simple-illustration__vertical-credit-cards.svg uses CSS <style> blocks with class selectors (.st0, .st1, etc.) to define fills and strokes on its path elements. This was introduced when the SVG was replaced with an Adobe Illustrator export in PR #83211.
On web, this works because @svgr/webpack processes SVGs into React components that properly handle CSS. On native however, SVG files are treated as static image assets and rendered through expo-image, which uses native platform decoders that do not support CSS <style> elements within SVGs. Without CSS class resolution, none of the <path> elements have any fill or stroke applied, so the icon renders blank.
What changes do you think we should make in order to solve the problem?
Convert the CSS class-based styling in the SVG to inline fill/stroke attributes directly on each <path> element. This preserves the exact same visual appearance while ensuring compatibility with native SVG renderers.
The mapping from CSS classes to inline attributes:
Please re-state the problem that we are trying to solve in this issue.
The "Need to add company cards?" icon is blank/invisible on native apps (Android and iOS) in the Wallet page.
What is the root cause of that problem?
The "Need to add company cards?" Wallet row uses VerticalCreditCards, and this specific illustration renders blank on native in this MenuItem context. While testing the replacement icon, we also saw that MenuItem applies a theme tint by default, which can make multi-color illustrations look incorrect unless we explicitly opt out of tinting.
This initialization includes VerticalCreditCards in the Wallet illustration set.
Because this asset is selected here, the native rendering issue starts from this line.
This fill logic explains why replacement illustrations can look muted on native.
Without opting out, MenuItem applies theme tint instead of original illustration colors.
What changes do you think we should make in order to solve the problem?
We should switch this Wallet row to CreditCardsNew (already used elsewhere), and render it with displayInDefaultIconColor so native keeps the original multi-color illustration instead of applying a theme tint.
⚠️@abbasifaizan70 Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).
⚠️@emkhalid Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not needed
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
MelvinBot commentedon Apr 10, 2026
Proposal
What is the root cause of that problem?
The
MenuItemrendering the "Need to add company cards?" illustration forces a monochromefillcolor onto the icon, which breaks multi-color SVG illustrations on native platforms.In
WalletPage/index.tsx, the MenuItem is rendered withicon={illustrations.VerticalCreditCards}but withoutdisplayInDefaultIconColoror a customiconFill. SincedisplayInDefaultIconColordefaults tofalse,MenuItem.tsxsetsfilltoStyleUtils.getIconFillColor(...)(a solid theme color).On web, the SVG is rendered as a React component via SVGR, and the CSS
<style>classes in the SVG (.st0{fill:#e4bc07},.st3{fill:#ff7101}, etc.) take precedence over thefillprop — so the illustration displays correctly with its original colors.On native (Android/iOS), the SVG asset is rendered via
expo-imageinImageSVG/index.android.tsxwithtintColor={fill}. Since the native SVG decoder doesn't fully process CSS<style>class-based fills, the paths are effectively transparent, andtintColorhas nothing to colorize — resulting in a blank icon.What changes do you think we should make in order to solve the problem?
Pass
displayInDefaultIconColorto the MenuItem inWalletPage/index.tsxso that nofill/tintColoris forced onto the illustration:This prevents
MenuItemfrom injecting a theme fill color, allowing the illustration to render with its original multi-color SVG fills on native — matching the web behavior.What alternative solutions did you explore? (Optional)
fillattributes instead of CSS<style>classes — this would be a more systemic fix but higher risk sinceinlineStylesis already explicitly disabled incompressSvg.tsdue to known Android fill issues.iconFill={undefined}explicitly — this would also work butdisplayInDefaultIconColoris the intended API for this purpose and is more readable.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.melvin-bot commentedon Apr 10, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (
External)melvin-bot commentedon Apr 10, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022042674292361297862
[-]Android & iOS - Wallet - "Need to add company cards?" icon is blank on native apps[/-][+][$250] Android & iOS - Wallet - "Need to add company cards?" icon is blank on native apps[/+]wildan-m commentedon Apr 10, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
The "Need to add company cards?" icon is blank/invisible on native apps (Android and iOS) in the Wallet page.
What is the root cause of that problem?
The SVG file
simple-illustration__vertical-credit-cards.svguses CSS<style>blocks with class selectors (.st0,.st1, etc.) to define fills and strokes on its path elements. This was introduced when the SVG was replaced with an Adobe Illustrator export in PR #83211.On web, this works because
@svgr/webpackprocesses SVGs into React components that properly handle CSS. On native however, SVG files are treated as static image assets and rendered throughexpo-image, which uses native platform decoders that do not support CSS<style>elements within SVGs. Without CSS class resolution, none of the<path>elements have any fill or stroke applied, so the icon renders blank.What changes do you think we should make in order to solve the problem?
Convert the CSS class-based styling in the SVG to inline
fill/strokeattributes directly on each<path>element. This preserves the exact same visual appearance while ensuring compatibility with native SVG renderers.The mapping from CSS classes to inline attributes:
.st0→fill="#e4bc07"(gold card body).st1→fill="none" stroke="#002140" stroke-linecap="round" stroke-linejoin="round"(card outlines).st2→fill="#002140" stroke="#002140" stroke-linecap="round" stroke-linejoin="round"(dark stripe).st3→fill="#ff7101"(orange card body).st4→fill="#fbccff"(small detail).st5→fill="#002140"(dark rectangle)Compare branch: https://github.com/Expensify/App/compare/main...wildan-m:App:wildan/87665-fix-vertical-credit-cards-icon?expand=1
abbasifaizan70 commentedon Apr 10, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
The "Need to add company cards?" icon is blank/invisible on native apps (Android and iOS) in the Wallet page.
What is the root cause of that problem?
The "Need to add company cards?" Wallet row uses
VerticalCreditCards, and this specific illustration renders blank on native in thisMenuItemcontext. While testing the replacement icon, we also saw thatMenuItemapplies a theme tint by default, which can make multi-color illustrations look incorrect unless we explicitly opt out of tinting.This initialization includes
VerticalCreditCardsin the Wallet illustration set.Because this asset is selected here, the native rendering issue starts from this line.
App/src/pages/settings/Wallet/WalletPage/index.tsx
Line 100 in e0067ad
This Wallet CTA is the exact row where users see the icon issue.
It renders
illustrations.VerticalCreditCards, which appears blank on native.App/src/pages/settings/Wallet/WalletPage/index.tsx
Lines 719 to 731 in e0067ad
This import points to the specific SVG file used for
VerticalCreditCards.The problematic visual comes from this source asset reference.
App/src/components/Icon/chunks/illustrations.chunk.ts
Line 196 in e0067ad
This fill logic explains why replacement illustrations can look muted on native.
Without opting out,
MenuItemapplies theme tint instead of original illustration colors.App/src/components/MenuItem.tsx
Lines 911 to 923 in e0067ad
What changes do you think we should make in order to solve the problem?
We should switch this Wallet row to
CreditCardsNew(already used elsewhere), and render it withdisplayInDefaultIconColorso native keeps the original multi-color illustration instead of applying a theme tint.App/src/pages/settings/Wallet/WalletPage/index.tsx
Line 100 in e0067ad
App/src/pages/settings/Wallet/WalletPage/index.tsx
Line 725 in e0067ad
App/src/pages/settings/Wallet/WalletPage/index.tsx
Lines 719 to 732 in e0067ad
Demo
github-actions commentedon Apr 10, 2026
github-actions commentedon Apr 11, 2026
parasharrajat commentedon Apr 12, 2026
@MelvinBot implement this.
16 remaining items
parasharrajat commentedon Apr 25, 2026
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Add personal card empty state, warning flow and upgrade flow #83211 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not needed
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/630790
Regression Test Proposal
Test:
Do we agree 👍 or 👎
Zapier Logs
Run ID: 00040eee-bc53-accc-ee32-1b7ba11db3b4melvin-bot commentedon Apr 27, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Apr 28, 2026
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Apr 28, 2026
Payment Summary
Contributor+: @parasharrajat due $250 via NewDot
^ Test case created
Thx
parasharrajat commentedon May 20, 2026
Payment requested as per #87665 (comment)
garrettmknight commentedon May 21, 2026
$250 approved for @parasharrajat