You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-05-11] Web - Expense - Tax rate column shows the default tax rate when tax rate is deleted #87667
Version Number: 9.3.58-2 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#84769 Email or phone of affected tester (no customers):sdjnsoidjiondjosjsoj@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Enable Taxes in workspace settings.
Go to staging.new.expensify.com
Go to workspace chat.
Create two expenses with 5% tax rates.
Go to workspace settings > More features.
Disable Taxes.
Open the expense report from Step 3.
Open any expense.
Click Tax field.
Click Delete tax.
Close report RHP.
Expected Result:
Tax rate column should be empty because tax rate is deleted.
Actual Result:
Tax rate column shows the default tax rate when tax rate is deleted.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Evidence: PR 84769 (merged 2026-04-09) is in StagingDeployCash and was identified by melvin-bot. The bug is staging-only (new feature, not in production). The PR modifies src/components/ReportActionItem/MoneyRequestView.tsx, src/libs/Violations/ViolationsUtils.ts, and src/libs/MergeTransactionUtils.ts - all directly related to the affected tax functionality.
Root cause: PR 84769 introduces showTaxDisabledAlert() which calls updateMoneyRequestTaxRate with taxCode set to empty string to delete the tax. The getTaxName utility in src/libs/TransactionUtils/index.ts (line 2155) has this fallback: (transaction?.taxCode || defaultTaxCode). Since empty string is falsy in JS, this evaluates to defaultTaxCode after deletion, so getTaxName returns the workspace default tax rate name instead of undefined. The taxRateValue in MoneyRequestView then falls through to taxRateTitle and displays the default tax rate name rather than an empty field - matching the observed bug. Assigned: @dominictb@hoangzinh@youssef-lr@trjExpensify
changed the title [-]Web - Expense - Tax rate column shows the default tax rate when tax rate is deleted[/-][+][Due for payment 2026-05-11] Web - Expense - Tax rate column shows the default tax rate when tax rate is deleted[/+]on May 4, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.65-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@hoangzinh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Apr 10, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #84769
melvin-bot commentedon Apr 10, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 10, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Apr 10, 2026
Classification: Frontend bug | Causing PR: #84769 by @dominictb (High confidence) | Recommendation: REVERT
OSBotify commentedon Apr 10, 2026
Evidence: PR 84769 (merged 2026-04-09) is in StagingDeployCash and was identified by melvin-bot. The bug is staging-only (new feature, not in production). The PR modifies src/components/ReportActionItem/MoneyRequestView.tsx, src/libs/Violations/ViolationsUtils.ts, and src/libs/MergeTransactionUtils.ts - all directly related to the affected tax functionality.
OSBotify commentedon Apr 10, 2026
Root cause: PR 84769 introduces showTaxDisabledAlert() which calls updateMoneyRequestTaxRate with taxCode set to empty string to delete the tax. The getTaxName utility in src/libs/TransactionUtils/index.ts (line 2155) has this fallback: (transaction?.taxCode || defaultTaxCode). Since empty string is falsy in JS, this evaluates to defaultTaxCode after deletion, so getTaxName returns the workspace default tax rate name instead of undefined. The taxRateValue in MoneyRequestView then falls through to taxRateTitle and displays the default tax rate name rather than an empty field - matching the observed bug. Assigned: @dominictb @hoangzinh @youssef-lr @trjExpensify
29 remaining items
hoangzinh commentedon Apr 23, 2026
Can someone please help mark this PR is ready for review #88580? Melvin couldn't
cc @youssef-lr
[-]Web - Expense - Tax rate column shows the default tax rate when tax rate is deleted[/-][+][Due for payment 2026-05-11] Web - Expense - Tax rate column shows the default tax rate when tax rate is deleted[/+]melvin-bot commentedon May 4, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 4, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.65-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-11. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 4, 2026
@hoangzinh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
hoangzinh commentedon May 4, 2026
We can close this issue