Skip to content

[Due for payment 2026-05-11] Web - Expense - Tax rate column shows the default tax rate when tax rate is deleted #87667

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.58-2
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #84769
Email or phone of affected tester (no customers): sdjnsoidjiondjosjsoj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Enable Taxes in workspace settings.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create two expenses with 5% tax rates.
  4. Go to workspace settings > More features.
  5. Disable Taxes.
  6. Open the expense report from Step 3.
  7. Open any expense.
  8. Click Tax field.
  9. Click Delete tax.
  10. Close report RHP.

Expected Result:

Tax rate column should be empty because tax rate is deleted.

Actual Result:

Tax rate column shows the default tax rate when tax rate is deleted.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7127008_1775845494597.14.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @hoangzinh

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 10, 2026
  2. melvin-bot commented on Apr 10, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #84769

  3. melvin-bot commented on Apr 10, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on Apr 10, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. OSBotify commented on Apr 10, 2026

    @OSBotify
    Contributor

    Classification: Frontend bug | Causing PR: #84769 by @dominictb (High confidence) | Recommendation: REVERT

  6. OSBotify commented on Apr 10, 2026

    @OSBotify
    Contributor

    Evidence: PR 84769 (merged 2026-04-09) is in StagingDeployCash and was identified by melvin-bot. The bug is staging-only (new feature, not in production). The PR modifies src/components/ReportActionItem/MoneyRequestView.tsx, src/libs/Violations/ViolationsUtils.ts, and src/libs/MergeTransactionUtils.ts - all directly related to the affected tax functionality.

  7. OSBotify commented on Apr 10, 2026

    @OSBotify
    Contributor

    Root cause: PR 84769 introduces showTaxDisabledAlert() which calls updateMoneyRequestTaxRate with taxCode set to empty string to delete the tax. The getTaxName utility in src/libs/TransactionUtils/index.ts (line 2155) has this fallback: (transaction?.taxCode || defaultTaxCode). Since empty string is falsy in JS, this evaluates to defaultTaxCode after deletion, so getTaxName returns the workspace default tax rate name instead of undefined. The taxRateValue in MoneyRequestView then falls through to taxRateTitle and displays the default tax rate name rather than an empty field - matching the observed bug. Assigned: @dominictb @hoangzinh @youssef-lr @trjExpensify

  8. 29 remaining items

  9. hoangzinh commented on Apr 23, 2026

    @hoangzinh
    Contributor

    Can someone please help mark this PR is ready for review #88580? Melvin couldn't

    cc @youssef-lr

  10. added and removed
    ReviewingHas a PR in review
    on May 4, 2026
  11. changed the title [-]Web - Expense - Tax rate column shows the default tax rate when tax rate is deleted[/-] [+][Due for payment 2026-05-11] Web - Expense - Tax rate column shows the default tax rate when tax rate is deleted[/+] on May 4, 2026
  12. melvin-bot commented on May 4, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on May 4, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.65-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-05-11. 🎊

    For reference, here are some details about the assignees on this issue:

    • @hoangzinh requires payment through NewDot Manual Requests
    • @dominictb does not require payment (Contractor)
  14. melvin-bot commented on May 4, 2026

    @melvin-bot

    @hoangzinh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. hoangzinh commented on May 4, 2026

    @hoangzinh
    Contributor

    We can close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions