You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Rejected and Held Expenses Not Handled Correctly During Approval Flow #88355
Version Number: 9.3.60-18 Reproducible in staging?: Needs Reproduction (Requires Chrome PWA) Reproducible in production?: Needs reproduction If this was caught during regression testing, add the test name, ID and link from BrowserStack: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by:@rafecolton Slack conversation (hyperlinked to channel name): #Expensify Product
Action Performed:
Create a report with: Valid receipts and Receipts with violations
Attempt to reject the expenses with violations
Observe behavior
Put the violating expenses on hold
Click Approve on the report
Expected Result:
Rejected expenses:
Should be removed from the report or clearly marked as rejected
Held expenses Should:
Trigger a prompt to approve only unheld expenses
Be excluded from approval
Be moved to a separate report or remain pending
Actual Result:
Rejected expenses: Remain on the report
No visual indicator of rejection
No error or feedback
Held expenses: Show hold violation indicator
But are still approved when approving the report
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
⚠️Preliminary analysis (medium confidence) — the code appears to already handle both scenarios described, so this may be an edge case, a backend issue, or needs clearer reproduction steps.
Finding: The App codebase already implements both (1) a held-expense approval modal that lets approvers choose partial vs full approval, and (2) individual expense rejection that removes expenses from reports and adds a visual violation indicator. The symptoms described may stem from an edge case where these flows don't trigger correctly, or from confusion about the two different rejection flows (individual vs report-level).
Recommended next step: This issue needs clear reproduction steps to determine whether the code paths are failing or whether the reporter encountered a different flow than expected.
"Approve only $X" → partial approval (full=false), held expenses split into a new report via Hold.ts:656-962
"Approve $Y" → full approval (full=true), clears all holds
This is handled in ReportWorkflow.ts:325-691. The full parameter controls whether held transactions are included or split out.
Rejection Flow
Individual expense rejection in RejectMoneyRequest.ts:196-701does remove expenses from reports (adjusting totals or deleting single-expense reports) and does add an AUTO_REPORTED_REJECTED_EXPENSE violation with showInReview: true.
However, the separate report-level rejection (rejectExpenseReport at line 961) changes report state without removing individual expenses — the reporter may have encountered this flow instead.
Why the reported behavior might still occur
The hasNonHeldExpenses check could be computed incorrectly for certain expense configurations (e.g., mixed violation types), preventing the modal from appearing
The Chrome PWA platform (noted in the issue) could have a rendering issue with the modal
The backend may not be properly honoring full=false in some configurations
changed the title [-]Rejected and Held Expenses Not Handled Correctly During Approval Flow[/-][+][$250] Rejected and Held Expenses Not Handled Correctly During Approval Flow[/+]on Apr 20, 2026
✅ Proposal
Please re-state the problem that we are trying to solve in this issue.
During the approval flow, expenses that are rejected or put on hold are not handled correctly:
Rejected expenses remain in the report without any clear visual indication
Held expenses still get approved when approving the full report
No clear feedback or prompt is shown to the user
This creates confusion and incorrect financial actions during approval.
What is the root cause of that problem?
The issue appears to be caused by inconsistent filtering and state handling in the approval flow:
Rejected expenses
The rejection action updates the expense state
But the report-level UI and approval logic still include these expenses
There is no consistent filtering or visual indicator applied after rejection
Held expenses
Held state (violation) is shown in UI
But the approval action does not exclude held expenses when approving the report
This suggests that the approval logic is not validating expense-level states before processing
Desync between UI and action logic
UI correctly shows violations (held)
But approval logic processes all transactions without checking:
isHeld
isRejected
👉 So root problem:
Approval flow is not respecting expense-level states (held/rejected) when performing report-level approval
What changes do you think we should make in order to solve the problem?
We should enforce state-aware approval logic + UI consistency:
✅ 1. Exclude held & rejected expenses during approval
In approval action (likely in ReportActions or approval handler):
✅ 2. Trigger confirmation modal when held expenses exist
Before approving:
If held expenses exist → show modal:
“This report contains held expenses. Do you want to approve only valid expenses?”
This aligns with expected behavior mentioned in issue.
✅ 3. Ensure rejected expenses are handled in UI
Either:
Remove them from the report view
OR clearly mark them as Rejected with a badge/state
Example:
{isRejected && }
✅ 4. Keep report state consistent
Report totals should exclude:
Rejected expenses
Held expenses (until resolved)
Why this approach?
Fixes both logic + UI inconsistency
Prevents incorrect approvals
Aligns behavior with expected approval flow
Handles edge cases (partial approvals, violations)
What alternative solutions did you explore? (Optional)
Only fixing UI → rejected because logic would still approve invalid expenses
Only fixing approval logic → rejected because UX confusion remains
Backend-only fix → avoided since issue shows clear FE inconsistency
⚠️@JasimMalook Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).
⚠️@JasimMalook Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.
Activity
MelvinBot commentedon Apr 20, 2026
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
MelvinBot commentedon Apr 20, 2026
Issue Analysis
Finding: The App codebase already implements both (1) a held-expense approval modal that lets approvers choose partial vs full approval, and (2) individual expense rejection that removes expenses from reports and adds a visual violation indicator. The symptoms described may stem from an edge case where these flows don't trigger correctly, or from confusion about the two different rejection flows (individual vs report-level).
Recommended next step: This issue needs clear reproduction steps to determine whether the code paths are failing or whether the reporter encountered a different flow than expected.
Investigation details
Held Expense Approval Flow
The approval flow at
useConfirmApproval.ts:34-61checksisAnyTransactionOnHoldand opens a hold menu modal (ProcessMoneyReportHoldMenu.tsx:78-94) with two options:full=false), held expenses split into a new report viaHold.ts:656-962full=true), clears all holdsThis is handled in
ReportWorkflow.ts:325-691. Thefullparameter controls whether held transactions are included or split out.Rejection Flow
Individual expense rejection in
RejectMoneyRequest.ts:196-701does remove expenses from reports (adjusting totals or deleting single-expense reports) and does add anAUTO_REPORTED_REJECTED_EXPENSEviolation withshowInReview: true.However, the separate report-level rejection (
rejectExpenseReportat line 961) changes report state without removing individual expenses — the reporter may have encountered this flow instead.Why the reported behavior might still occur
hasNonHeldExpensescheck could be computed incorrectly for certain expense configurations (e.g., mixed violation types), preventing the modal from appearingfull=falsein some configurationsPossibly Related Issues
Next Steps: Reply with
@MelvinBot implement thisto create a draft PR, or@MelvinBot <your feedback>to refine this analysis.melvin-bot commentedon Apr 20, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (
External)[-]Rejected and Held Expenses Not Handled Correctly During Approval Flow[/-][+][$250] Rejected and Held Expenses Not Handled Correctly During Approval Flow[/+]melvin-bot commentedon Apr 20, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022046326401067371473
JasimMalook commentedon Apr 20, 2026
✅ Proposal
Please re-state the problem that we are trying to solve in this issue.
During the approval flow, expenses that are rejected or put on hold are not handled correctly:
Rejected expenses remain in the report without any clear visual indication
Held expenses still get approved when approving the full report
No clear feedback or prompt is shown to the user
This creates confusion and incorrect financial actions during approval.
What is the root cause of that problem?
The issue appears to be caused by inconsistent filtering and state handling in the approval flow:
Rejected expenses
The rejection action updates the expense state
But the report-level UI and approval logic still include these expenses
There is no consistent filtering or visual indicator applied after rejection
Held expenses
Held state (violation) is shown in UI
But the approval action does not exclude held expenses when approving the report
This suggests that the approval logic is not validating expense-level states before processing
Desync between UI and action logic
UI correctly shows violations (held)
But approval logic processes all transactions without checking:
isHeld
isRejected
👉 So root problem:
Approval flow is not respecting expense-level states (held/rejected) when performing report-level approval
What changes do you think we should make in order to solve the problem?
We should enforce state-aware approval logic + UI consistency:
✅ 1. Exclude held & rejected expenses during approval
In approval action (likely in ReportActions or approval handler):
const approvableTransactions = reportTransactions.filter(
(transaction) =>
!isHeld(transaction) &&
!isRejected(transaction)
);
Only approve approvableTransactions.
✅ 2. Trigger confirmation modal when held expenses exist
Before approving:
If held expenses exist → show modal:
“This report contains held expenses. Do you want to approve only valid expenses?”
This aligns with expected behavior mentioned in issue.
✅ 3. Ensure rejected expenses are handled in UI
Either:
Remove them from the report view
OR clearly mark them as Rejected with a badge/state
Example:
{isRejected && }
✅ 4. Keep report state consistent
Report totals should exclude:
Rejected expenses
Held expenses (until resolved)
Why this approach?
Fixes both logic + UI inconsistency
Prevents incorrect approvals
Aligns behavior with expected approval flow
Handles edge cases (partial approvals, violations)
What alternative solutions did you explore? (Optional)
Only fixing UI → rejected because logic would still approve invalid expenses
Only fixing approval logic → rejected because UX confusion remains
Backend-only fix → avoided since issue shows clear FE inconsistency
📌 Contributor Details
Email: jasimmalook@gmail.com
Upwork: https://www.upwork.com/freelancers/~014c25762fc2275193
github-actions commentedon Apr 20, 2026
JasimMalook commentedon Apr 20, 2026
🚫 Duplicated proposal withdrawn by 🤖 ProposalPolice.
github-actions commentedon Apr 20, 2026
22 remaining items
mvtglobally commentedon May 16, 2026
Issue not reproducible during KI retests. (Second week)
melvin-bot commentedon May 18, 2026
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
sobitneupane commentedon May 18, 2026
@rafecolton It looks like the issue is no longer reproducible. Are you still able to reproduce it?
melvin-bot commentedon May 18, 2026
@sobitneupane this issue is now 4 weeks old, please consider:
Thanks!
melvin-bot commentedon May 21, 2026
@sobitneupane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
mvtglobally commentedon May 23, 2026
Issue not reproducible during KI retests. (Third week)
melvin-bot commentedon May 25, 2026
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
melvin-bot commentedon May 25, 2026
@sobitneupane Still overdue 6 days?! Let's take care of this!
sobitneupane commentedon May 27, 2026
Since the issue is no longer reproducible, we can close it.