You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Navigate to report thread in RHP when viewing a report in a right docked modal #88532
I tried clicking on the "Explain" feature and I was a bit surprised that it took me out of the right-docked modal context and sent me over to the Inbox. I would think we should open up the thread directly on top of the report, the same way we open up editing push rows into RHP modals.
Activity
hungvu193 commentedon May 2, 2026
Please assign me here since I reviewed the PR. Ty 🙇
mitarachim commentedon May 11, 2026
Deploy Blocker #90180 was identified to be related to the PR #88527 that attempted to fix this issue.
melvin-bot commentedon May 11, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
mountiny commentedon May 11, 2026
Had to revert the PR, @WojtekBoman is working on a fix
36 remaining items
melvin-bot commentedon Jun 10, 2026
@shawnborton, @hungvu193, @mountiny, @WojtekBoman, @adamgrzybowski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
hungvu193 commentedon Jun 11, 2026
Same
melvin-bot commentedon Jun 16, 2026
@shawnborton, @hungvu193, @mountiny, @WojtekBoman, @adamgrzybowski Eep! 4 days overdue now. Issues have feelings too...
hungvu193 commentedon Jun 17, 2026
@mallenexpensify This is due for payment. We had a regression above (#88532 (comment)).
hungvu193 commentedon Jun 17, 2026
This is an improvement. I think we only need the Regression test:
Regression Tests
Web wide layout
On web (wide layout), go to the Search tab and open any expense report that has a chat thread (
search/view/:reportID).In the report header, tap the thread's parent link ("from [Report Name]").
Verify that the parent report opens in the RHP (stays in Search tab) instead of navigating away to the Inbox tab.
On web (wide layout), open a report in Search (
search/view/:reportID) that has a child thread.Tap on the thread action to open the child report.
Verify that the child report opens via
search/view/:childReportIDwith a slide-from-right animation (not appearing instantly without animation).On web (wide layout), open a report in Search (
search/view/:reportID) and tap into a child thread report.Tap the composer text input area.
Verify that focus is correctly applied to the composer after the transition animation completes (no jank or missed focus).
Do we 👍 or 👎 ?
melvin-bot commentedon Jun 17, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)mallenexpensify commentedon Jun 17, 2026
Payment Summary
Contributor+: @hungvu193 due $125 via NewDot
^ Test case created. Thx
JmillsExpensify commentedon Jun 18, 2026
$125 approved for @hungvu193