Skip to content

Navigate to report thread in RHP when viewing a report in a right docked modal #88532

Closed

Description

@shawnborton

I tried clicking on the "Explain" feature and I was a bit surprised that it took me out of the right-docked modal context and sent me over to the Inbox. I would think we should open up the thread directly on top of the report, the same way we open up editing push rows into RHP modals.

CleanShot.2026-04-17.at.09.54.54.mp4

cc @Expensify/design @JmillsExpensify @mountiny @adamgrzybowski @WojtekBoman

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. hungvu193 commented on May 2, 2026

    @hungvu193
    Contributor

    Please assign me here since I reviewed the PR. Ty 🙇

  2. mitarachim commented on May 11, 2026

    @mitarachim

    Deploy Blocker #90180 was identified to be related to the PR #88527 that attempted to fix this issue.

  3. melvin-bot commented on May 11, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  4. mountiny commented on May 11, 2026

    @mountiny
    Contributor

    Had to revert the PR, @WojtekBoman is working on a fix

  5. 36 remaining items

  6. melvin-bot commented on Jun 10, 2026

    @melvin-bot

    @shawnborton, @hungvu193, @mountiny, @WojtekBoman, @adamgrzybowski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  7. hungvu193 commented on Jun 11, 2026

    @hungvu193
    Contributor

    Same

  8. melvin-bot commented on Jun 16, 2026

    @melvin-bot

    @shawnborton, @hungvu193, @mountiny, @WojtekBoman, @adamgrzybowski Eep! 4 days overdue now. Issues have feelings too...

  9. hungvu193 commented on Jun 17, 2026

    @hungvu193
    Contributor

    @mallenexpensify This is due for payment. We had a regression above (#88532 (comment)).

  10. hungvu193 commented on Jun 17, 2026

    @hungvu193
    Contributor

    This is an improvement. I think we only need the Regression test:

    Regression Tests

    Web wide layout

    1. On web (wide layout), go to the Search tab and open any expense report that has a chat thread (search/view/:reportID).

    2. In the report header, tap the thread's parent link ("from [Report Name]").

    3. Verify that the parent report opens in the RHP (stays in Search tab) instead of navigating away to the Inbox tab.

    4. On web (wide layout), open a report in Search (search/view/:reportID) that has a child thread.

    5. Tap on the thread action to open the child report.

    6. Verify that the child report opens via search/view/:childReportID with a slide-from-right animation (not appearing instantly without animation).

    7. On web (wide layout), open a report in Search (search/view/:reportID) and tap into a child thread report.

    8. Tap the composer text input area.

    9. Verify that focus is correctly applied to the composer after the transition animation completes (no jank or missed focus).

    Do we 👍 or 👎 ?

  11. melvin-bot commented on Jun 17, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  12. mallenexpensify commented on Jun 17, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @hungvu193 due $125 via NewDot

    ^ Test case created. Thx

  13. JmillsExpensify commented on Jun 18, 2026

    @JmillsExpensify
    Contributor

    $125 approved for @hungvu193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2Task

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions