You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-08-05] [$250] Reorder onboarding steps: feature selection before accounting integration #89594
During onboarding, some "manage my team" users select None in the Accounting integration step, then later toggle Accounting back on in the feature selection step (since it shows as disabled after choosing None). The current step order (Accounting first, then feature selection) leads to confusion because None logically reads as "none of these options, but I still use accounting."
Proposed Changes
Switch the order of onboarding steps: Show the feature selection step first, then the accounting integration list. This makes the flow go from broader functionality to more granular, reducing confusion.
If the user keeps Accounting enabled in feature selection, show the accounting integration options where:
Remove the None option
Make Other a free text input
Rationale
Users are selecting None instead of Other, then re-enabling accounting in the next step. Reordering the steps and cleaning up the options should reduce this friction.
The onboarding step order for "manage my team" users is defined in getOnboardingStepCounter.ts:42 as EMPLOYEES → ACCOUNTING → INTERESTED_FEATURES. This puts accounting integration selection before feature selection, so users see "None" and pick it (thinking "none of these"), then later re-enable Accounting in the feature toggle step. The same order also appears for VSB/SMB qualifier flows at line 55-56.
What changes do you think we should make in order to solve the problem?
3. Conditionally show the Accounting step: If the user disables Accounting in feature selection, skip the Accounting step entirely.
4. Remove the "None" option from BaseOnboardingAccounting.tsx:149-162 — delete the noneAccountingOption object and remove it from the returned array at line 179.
5. Convert "Other" to a free text input: Replace the static "Other" option at BaseOnboardingAccounting.tsx:164-177 with a selectable option that, when selected, reveals a TextInput for the user to type their accounting tool name. Store the typed value (instead of the string 'other') via setOnboardingUserReportedIntegration.
What alternative solutions did you explore? (Optional)
An alternative is to keep the step order the same but just remove "None" — however, this doesn't address the broader UX confusion of asking for a specific integration before asking whether the user even wants accounting enabled. Swapping the order makes the flow logically progressive (broad feature selection → specific integration) and naturally eliminates the need for "None."
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
@nabi-ebrahimi can you please accept the job below? Please reply here and tag me once you have.
If you're not sent an offer in Upwork when you're assigned to an issue, please tag me. If an Upwork job exists, please submit a proposal. https://www.upwork.com/jobs/~022085551964297837554
@parasharrajat This is regarding the Regression test proposal
Just to confirm, Features modal displayed before accounting modal for all the number of employees option. Hope its expected.
Activity
dylanexpensify commentedon May 5, 2026
@MelvinBot propose how you'd implement this.
MelvinBot commentedon May 5, 2026
Proposal
What is the root cause of that problem?
The onboarding step order for "manage my team" users is defined in
getOnboardingStepCounter.ts:42asEMPLOYEES → ACCOUNTING → INTERESTED_FEATURES. This puts accounting integration selection before feature selection, so users see "None" and pick it (thinking "none of these"), then later re-enable Accounting in the feature toggle step. The same order also appears for VSB/SMB qualifier flows atline 55-56.What changes do you think we should make in order to solve the problem?
1. Swap step order in
getOnboardingStepCounter.ts:MANAGE_TEAMto[EMPLOYEES, INTERESTED_FEATURES, ACCOUNTING]2. Update hardcoded navigation in the continue handlers:
BaseOnboardingEmployees.tsx:74: Navigate toONBOARDING_INTERESTED_FEATURESinstead ofONBOARDING_ACCOUNTINGBaseOnboardingInterestedFeatures.tsx: Navigate toONBOARDING_ACCOUNTINGinstead of completing onboarding (when Accounting feature is enabled)BaseOnboardingAccounting.tsx:191: Navigate to the completion/workspace flow instead ofONBOARDING_INTERESTED_FEATURES3. Conditionally show the Accounting step: If the user disables Accounting in feature selection, skip the Accounting step entirely.
4. Remove the "None" option from
BaseOnboardingAccounting.tsx:149-162— delete thenoneAccountingOptionobject and remove it from the returned array at line 179.5. Convert "Other" to a free text input: Replace the static "Other" option at
BaseOnboardingAccounting.tsx:164-177with a selectable option that, when selected, reveals aTextInputfor the user to type their accounting tool name. Store the typed value (instead of the string'other') viasetOnboardingUserReportedIntegration.What alternative solutions did you explore? (Optional)
An alternative is to keep the step order the same but just remove "None" — however, this doesn't address the broader UX confusion of asking for a specific integration before asking whether the user even wants accounting enabled. Swapping the order makes the flow logically progressive (broad feature selection → specific integration) and naturally eliminates the need for "None."
Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.melvin-bot commentedon May 8, 2026
@dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
dylanexpensify commentedon May 12, 2026
Moving forward this week!
melvin-bot commentedon May 14, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (
External)51 remaining items
melvin-bot commentedon Aug 4, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Aug 4, 2026
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Aug 7, 2026
Payment Summary
Contributor: @nabi-ebrahimi paid $250 via Upwork
Contributor+: @parasharrajat due $250 via NewDot
@nabi-ebrahimi can you please accept the job below? Please reply here and tag me once you have.
If you're not sent an offer in Upwork when you're assigned to an issue, please tag me. If an Upwork job exists, please submit a proposal.
https://www.upwork.com/jobs/~022085551964297837554
^ Test case created. Thx
nabi-ebrahimi commentedon Aug 10, 2026
@mallenexpensify, Accepted the offer. thanks.
mallenexpensify commentedon Aug 10, 2026
@nabi-ebrahimi paid, summary updated above. Thx.
m-natarajan commentedon Aug 13, 2026
@parasharrajat This is regarding the
Regression test proposalJust to confirm, Features modal displayed before accounting modal for all the number of employees option. Hope its expected.
parasharrajat commentedon Aug 14, 2026
yes it is fine.