You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-05-15] [Due for payment 2026-05-13] Tags -"Not allowed" icon is shown when hover over disabled tag radio button #89656
Version Number: 9.3.67-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:https://test-management.browserstack.com/projects/2219752/folder/13176676/test-cases/41237308 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Bug source: Regression TC Execution Device used: MacBook Air 15.7.4 Chrome, iPhone 15 iOS 26.3.1 App Component: Money Requests
Action Performed:
Preconditions: Admin added tags to the workspace. Invited a member
As a Member, create an expense in a workspace, selecting a tag
As an Admin, open Workspace Settings/ Tags and disable all tags
As an Admin, open the expense from step 1, click the tag row, hover over radio button with a checkmark near the tag, try to click on it to deselect (on iOS tap the checkmark)
Expected Result:
Admin can easily deselect the tag in the member's expense details after disabling tags in the workspace
Actual Result:
"Not allowed" icon is shown when hover over disabled tag radio button on Web. On iOS, tapping radio button with a checkmark does not deselect the tag.
Step 8 of the TC is failed
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
When an admin disables all tags in workspace settings, the tag picker for an existing expense correctly shows the previously-selected tag (so it can be deselected), but the radio button renders with cursor: not-allowed and appears disabled — preventing deselection via the button.
Solution
The row's Pressable in BaseListItem.tsx:197 already has the correct pattern: disabled={isDisabled && !item.isSelected} — a disabled-but-selected item remains interactive so the user can deselect it.
The radio button in SelectableListItem.tsx:45 (and line 62 for left-positioned buttons) does not have this exception — it uses disabled={isDisabled || item.isDisabledCheckbox} unconditionally.
Fix: Change both lines in SelectableListItem.tsx from:
This matches the existing BaseListItem pattern and allows the radio button to remain interactive for deselection when the tag is disabled but currently selected.
Evidence & data flow
Admin disables all tags → all PolicyTag objects have enabled: false
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
Classification: Frontend bug Causing PR: #87087 - "Consistent checkboxes and radio buttons UI" by @mhawryluk (High confidence) Related Issues: None
Recommendation: REVERT
PR #87087 introduced a regression in the disabled-state logic for radio buttons on selected-but-workspace-disabled tags. The fix is a small one-line change in SelectableListItem.tsx, but the PR itself is a large refactor touching 80+ files, making a targeted roll-forward safer than a full revert. However, the PR is still open (not marked as verified in the deploy checklist), so a revert is the cleanest path.
Assigned: @mhawryluk (PR author), @dukenv0307 and @grgia (approving reviewers) from highest-confidence causing PR only Labels: DeployBlockerCash kept (frontend App PR caused this). No label changes made.
📋 Detailed Analysis
Evidence
The issue is only reproducible on staging (version 9.3.67-0) and not on production. PR #87087 is in the current staging deploy checklist and is titled "Consistent checkboxes and radio buttons UI" — a large refactor of the selection list components including SelectableListItem.tsx, ListRadioButton.tsx, SelectionButton.tsx, and TagPicker.tsx.
The symptom is: when an admin opens a member's expense and the tag picker is shown, a tag that is currently selected but has been disabled in the workspace settings shows a "not allowed" cursor on web (and is untappable on iOS), preventing the admin from deselecting it.
Before PR #87087, the old RadioListItem.tsx rendered its radio button (a Checkbox component with circular border radius) with:
disabled={!!isDisabled&&!item.isSelected}
This meant: the radio button was disabled only if the item was both disabled AND not currently selected. When a disabled tag was the currently selected tag (item.isSelected === true), the radio button remained interactive — allowing the user to click it to deselect.
After PR #87087, the new SelectableListItem.tsx renders the radio button (ListRadioButton) with:
disabled={isDisabled||item.isDisabledCheckbox}
This removes the !item.isSelected exception. Now if isDisabled is true (which it is for a tag marked as not enabled in the workspace), the radio button is always disabled — even when the item is selected. This produces the "not allowed" cursor on web and prevents tapping on iOS.
The isDisabled value flows from BaseSelectionList.tsx line 350:
constisItemDisabled=isDisabled||item.isDisabled;
where item.isDisabled is set to !tag.enabled in TagsOptionsListUtils.ts → getTagsOptions(). So any tag with enabled: false causes isDisabled: true to be passed down to the radio button, blocking interaction even for the currently selected tag.
changed the title [-]Tags -"Not allowed" icon is shown when hover over disabled tag radio button[/-][+][Due for payment 2026-05-13] Tags -"Not allowed" icon is shown when hover over disabled tag radio button[/+]on May 6, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.67-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
changed the title [-][Due for payment 2026-05-13] Tags -"Not allowed" icon is shown when hover over disabled tag radio button[/-][+][Due for payment 2026-05-15] [Due for payment 2026-05-13] Tags -"Not allowed" icon is shown when hover over disabled tag radio button[/+]on May 8, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.68-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon May 5, 2026
Triggered auto assignment to @Beamanator (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon May 5, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 5, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon May 5, 2026
Proposal
Problem
When an admin disables all tags in workspace settings, the tag picker for an existing expense correctly shows the previously-selected tag (so it can be deselected), but the radio button renders with
cursor: not-allowedand appears disabled — preventing deselection via the button.Solution
The row's
PressableinBaseListItem.tsx:197already has the correct pattern:disabled={isDisabled && !item.isSelected}— a disabled-but-selected item remains interactive so the user can deselect it.The radio button in
SelectableListItem.tsx:45(and line 62 for left-positioned buttons) does not have this exception — it usesdisabled={isDisabled || item.isDisabledCheckbox}unconditionally.Fix: Change both lines in
SelectableListItem.tsxfrom:to:
This matches the existing
BaseListItempattern and allows the radio button to remain interactive for deselection when the tag is disabled but currently selected.Evidence & data flow
PolicyTagobjects haveenabled: falseTagsOptionsListUtils.ts:99sets the selected tag'senabledtofalse(not inenabledTagsNames)TagsOptionsListUtils.ts:57convertsenabled: false→isDisabled: trueBaseListItem.tsx:197allows the row press (disabled={isDisabled && !item.isSelected}→falsesinceisSelectedistrue) ✅SelectableListItem.tsx:45disables the radio button (disabled={isDisabled}→true, ignoringisSelected) ❌SelectionButton.tsx:186appliesstyles.cursorDisabled→cursor: not-allowedNext Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.OSBotify commentedon May 5, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #87087 - "Consistent checkboxes and radio buttons UI" by @mhawryluk (High confidence)
Related Issues: None
Recommendation: REVERT
PR #87087 introduced a regression in the disabled-state logic for radio buttons on selected-but-workspace-disabled tags. The fix is a small one-line change in
SelectableListItem.tsx, but the PR itself is a large refactor touching 80+ files, making a targeted roll-forward safer than a full revert. However, the PR is still open (not marked as verified in the deploy checklist), so a revert is the cleanest path.Assigned: @mhawryluk (PR author), @dukenv0307 and @grgia (approving reviewers) from highest-confidence causing PR only
Labels:
DeployBlockerCashkept (frontend App PR caused this). No label changes made.📋 Detailed Analysis
Evidence
The issue is only reproducible on staging (version 9.3.67-0) and not on production. PR #87087 is in the current staging deploy checklist and is titled "Consistent checkboxes and radio buttons UI" — a large refactor of the selection list components including
SelectableListItem.tsx,ListRadioButton.tsx,SelectionButton.tsx, andTagPicker.tsx.The symptom is: when an admin opens a member's expense and the tag picker is shown, a tag that is currently selected but has been disabled in the workspace settings shows a "not allowed" cursor on web (and is untappable on iOS), preventing the admin from deselecting it.
Verification
The affected code path is:
src/components/SelectionList/ListItem/SelectableListItem.tsx— confirmed modified by PR Consistent checkboxes and radio buttons UI #87087 (new file, 73 lines added)src/components/SelectionList/components/ListRadioButton.tsx— new file added by PR Consistent checkboxes and radio buttons UI #87087src/components/SelectionList/components/ListSelectionButton.tsx— new file added by PR Consistent checkboxes and radio buttons UI #87087Root Cause
Before PR #87087, the old
RadioListItem.tsxrendered its radio button (aCheckboxcomponent with circular border radius) with:This meant: the radio button was disabled only if the item was both disabled AND not currently selected. When a disabled tag was the currently selected tag (
item.isSelected === true), the radio button remained interactive — allowing the user to click it to deselect.After PR #87087, the new
SelectableListItem.tsxrenders the radio button (ListRadioButton) with:This removes the
!item.isSelectedexception. Now ifisDisabledistrue(which it is for a tag marked as not enabled in the workspace), the radio button is always disabled — even when the item is selected. This produces the "not allowed" cursor on web and prevents tapping on iOS.The
isDisabledvalue flows fromBaseSelectionList.tsxline 350:where
item.isDisabledis set to!tag.enabledinTagsOptionsListUtils.ts→getTagsOptions(). So any tag withenabled: falsecausesisDisabled: trueto be passed down to the radio button, blocking interaction even for the currently selected tag.4 remaining items
m-natarajan commentedon May 6, 2026
Passed, Chrome / v9.3.67-9
REC-20260506192845.mp4
Beamanator commentedon May 6, 2026
Nice! Closing!
[-]Tags -"Not allowed" icon is shown when hover over disabled tag radio button[/-][+][Due for payment 2026-05-13] Tags -"Not allowed" icon is shown when hover over disabled tag radio button[/+]melvin-bot commentedon May 6, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 6, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.67-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-13. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 6, 2026
@dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[-][Due for payment 2026-05-13] Tags -"Not allowed" icon is shown when hover over disabled tag radio button[/-][+][Due for payment 2026-05-15] [Due for payment 2026-05-13] Tags -"Not allowed" icon is shown when hover over disabled tag radio button[/+]melvin-bot commentedon May 8, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.68-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-15. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 8, 2026
@dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]