Skip to content

[Due for payment 2026-05-15] [Due for payment 2026-05-13] Tags -"Not allowed" icon is shown when hover over disabled tag radio button #89656

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.67-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176676/test-cases/41237308
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: MacBook Air 15.7.4 Chrome, iPhone 15 iOS 26.3.1
App Component: Money Requests

Action Performed:

Preconditions: Admin added tags to the workspace. Invited a member

  1. As a Member, create an expense in a workspace, selecting a tag
  2. As an Admin, open Workspace Settings/ Tags and disable all tags
  3. As an Admin, open the expense from step 1, click the tag row, hover over radio button with a checkmark near the tag, try to click on it to deselect (on iOS tap the checkmark)

Expected Result:

Admin can easily deselect the tag in the member's expense details after disabling tags in the workspace

Actual Result:

"Not allowed" icon is shown when hover over disabled tag radio button on Web. On iOS, tapping radio button with a checkmark does not deselect the tag.
Step 8 of the TC is failed

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7145335_1778011366643.Not_allowed.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @dukenv0307

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 5, 2026
  2. melvin-bot commented on May 5, 2026

    @melvin-bot

    Triggered auto assignment to @Beamanator (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on May 5, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on May 5, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. MelvinBot commented on May 5, 2026

    @MelvinBot
    Contributor

    Proposal

    Problem

    When an admin disables all tags in workspace settings, the tag picker for an existing expense correctly shows the previously-selected tag (so it can be deselected), but the radio button renders with cursor: not-allowed and appears disabled — preventing deselection via the button.

    Solution

    The row's Pressable in BaseListItem.tsx:197 already has the correct pattern: disabled={isDisabled && !item.isSelected} — a disabled-but-selected item remains interactive so the user can deselect it.

    The radio button in SelectableListItem.tsx:45 (and line 62 for left-positioned buttons) does not have this exception — it uses disabled={isDisabled || item.isDisabledCheckbox} unconditionally.

    Fix: Change both lines in SelectableListItem.tsx from:

    disabled={isDisabled || item.isDisabledCheckbox}
    

    to:

    disabled={(isDisabled && !item.isSelected) || item.isDisabledCheckbox}
    

    This matches the existing BaseListItem pattern and allows the radio button to remain interactive for deselection when the tag is disabled but currently selected.

    Evidence & data flow
    1. Admin disables all tags → all PolicyTag objects have enabled: false
    2. TagsOptionsListUtils.ts:99 sets the selected tag's enabled to false (not in enabledTagsNames)
    3. TagsOptionsListUtils.ts:57 converts enabled: false → isDisabled: true
    4. BaseListItem.tsx:197 allows the row press (disabled={isDisabled && !item.isSelected} → false since isSelected is true) ✅
    5. SelectableListItem.tsx:45 disables the radio button (disabled={isDisabled} → true, ignoring isSelected) ❌
    6. SelectionButton.tsx:186 applies styles.cursorDisabled → cursor: not-allowed

    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  6. OSBotify commented on May 5, 2026

    @OSBotify
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: #87087 - "Consistent checkboxes and radio buttons UI" by @mhawryluk (High confidence)
    Related Issues: None

    Recommendation: REVERT

    PR #87087 introduced a regression in the disabled-state logic for radio buttons on selected-but-workspace-disabled tags. The fix is a small one-line change in SelectableListItem.tsx, but the PR itself is a large refactor touching 80+ files, making a targeted roll-forward safer than a full revert. However, the PR is still open (not marked as verified in the deploy checklist), so a revert is the cleanest path.

    Assigned: @mhawryluk (PR author), @dukenv0307 and @grgia (approving reviewers) from highest-confidence causing PR only
    Labels: DeployBlockerCash kept (frontend App PR caused this). No label changes made.

    📋 Detailed Analysis

    Evidence

    The issue is only reproducible on staging (version 9.3.67-0) and not on production. PR #87087 is in the current staging deploy checklist and is titled "Consistent checkboxes and radio buttons UI" — a large refactor of the selection list components including SelectableListItem.tsx, ListRadioButton.tsx, SelectionButton.tsx, and TagPicker.tsx.

    The symptom is: when an admin opens a member's expense and the tag picker is shown, a tag that is currently selected but has been disabled in the workspace settings shows a "not allowed" cursor on web (and is untappable on iOS), preventing the admin from deselecting it.

    Verification

    The affected code path is:

    Root Cause

    Before PR #87087, the old RadioListItem.tsx rendered its radio button (a Checkbox component with circular border radius) with:

    disabled={!!isDisabled && !item.isSelected}

    This meant: the radio button was disabled only if the item was both disabled AND not currently selected. When a disabled tag was the currently selected tag (item.isSelected === true), the radio button remained interactive — allowing the user to click it to deselect.

    After PR #87087, the new SelectableListItem.tsx renders the radio button (ListRadioButton) with:

    disabled={isDisabled || item.isDisabledCheckbox}

    This removes the !item.isSelected exception. Now if isDisabled is true (which it is for a tag marked as not enabled in the workspace), the radio button is always disabled — even when the item is selected. This produces the "not allowed" cursor on web and prevents tapping on iOS.

    The isDisabled value flows from BaseSelectionList.tsx line 350:

    const isItemDisabled = isDisabled || item.isDisabled;

    where item.isDisabled is set to !tag.enabled in TagsOptionsListUtils.ts → getTagsOptions(). So any tag with enabled: false causes isDisabled: true to be passed down to the radio button, blocking interaction even for the currently selected tag.

  7. 4 remaining items

  8. m-natarajan commented on May 6, 2026

    @m-natarajan

    Passed, Chrome / v9.3.67-9

    REC-20260506192845.mp4
  9. Beamanator commented on May 6, 2026

    @Beamanator
    Contributor

    Nice! Closing!

  10. added and removed
    ReviewingHas a PR in review
    on May 6, 2026
  11. changed the title [-]Tags -"Not allowed" icon is shown when hover over disabled tag radio button[/-] [+][Due for payment 2026-05-13] Tags -"Not allowed" icon is shown when hover over disabled tag radio button[/+] on May 6, 2026
  12. melvin-bot commented on May 6, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on May 6, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.67-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-05-13. 🎊

    For reference, here are some details about the assignees on this issue:

    • @mhawryluk does not require payment (Contractor)
    • @dukenv0307 requires payment through NewDot Manual Requests
  14. melvin-bot commented on May 6, 2026

    @melvin-bot

    @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. changed the title [-][Due for payment 2026-05-13] Tags -"Not allowed" icon is shown when hover over disabled tag radio button[/-] [+][Due for payment 2026-05-15] [Due for payment 2026-05-13] Tags -"Not allowed" icon is shown when hover over disabled tag radio button[/+] on May 8, 2026
  16. melvin-bot commented on May 8, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.68-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-05-15. 🎊

    For reference, here are some details about the assignees on this issue:

    • @mhawryluk does not require payment (Contractor)
    • @dukenv0307 requires payment through NewDot Manual Requests
  17. melvin-bot commented on May 8, 2026

    @melvin-bot

    @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions