Skip to content

[Due for payment 2026-07-23] [Split #88320] PR 12 - Flip list-ref ownership on ActionListContext #89773

Closed

Description

@rlinoz

Goal: Remove the last React Compiler bail in ReportActionsList by moving list ref ownership local to each list.

Scope:

  • Update ReportScreenContext.ts
  • Update useActionListContextValue.ts
  • Update useReportScrollManager files
  • Update ReportActionsList.tsx
  • Update MoneyRequestReportActionsList.tsx
  • Update ReportActionItemMessageEdit.tsx
  • Add lifecycle and ref-resolution tests

Risk: Low-medium. Context shape changes.

Depends on: #89772

Parent issue: #88320
Source plan: #88320 (comment)

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. melvin-bot commented on May 29, 2026

    @melvin-bot

    This issue has not been updated in over 15 days. @rlinoz, @adhorodyski, @DylanDylann eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  2. LukasMod commented on Jun 30, 2026

    @LukasMod
    Contributor

    Hi, I am Łukasz from Callstack, an expert agency and I can work on this issue

  3. LukasMod commented on Jul 1, 2026

    @LukasMod
    Contributor

    Still working on this one. While preparing test videos, I noticed layout flickering after opening a deep link, and it also seems to happen on main. I'm not sure what the exact reproduction steps are yet. I send multiple messages, use deep links, press the floating scroll button, and at some point the layout starts flickering when opening a deep link or refreshing a chat with a linked message. Before we move forward, we should identify the root cause to avoid having to revert more changes.
    Examples:
    branch:

    Screen.Recording.2026-07-01.at.12.26.31.mov

    main:

    Screen.Recording.2026-07-01.at.14.39.38.mov

    If we fix that and add this change, React Compiler will work for the list, and we'll be ready to remove the manual memoization from it. I'll create a separate PR for that. For now, I'll hold off until we pinpoint what causes that.

    I'm OOO until Monday (06/07). If anything urgent comes up while I'm away, please reach out to @VickyStash. She'll help find the right person from the team to assist.

  4. added
    ReviewingHas a PR in review
    and removed on Jul 6, 2026
  5. 16 remaining items

  6. melvin-bot commented on Jul 16, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.34-14 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-07-23. 🎊

    For reference, here are some details about the assignees on this issue:

  7. melvin-bot commented on Jul 20, 2026

    @melvin-bot

    @DylanDylann Eep! 4 days overdue now. Issues have feelings too...

  8. melvin-bot commented on Jul 22, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  9. melvin-bot commented on Jul 22, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @adhorodyski does not require payment (Contractor)
    • Contributor: @LukasMod does not require payment (Contractor)
    • Reviewer: @DylanDylann owed $250 via NewDot

    BugZero Checklist (@mallenexpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  10. mallenexpensify commented on Jul 25, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @DylanDylann due $250 via NewDot

  11. DylanDylann commented on Jul 27, 2026

    @DylanDylann
    Contributor

    @mallenexpensify Actually, to avoid creating a big PR, the author created two PRs for this issue

    Could you evaluate the compensation again?

  12. mallenexpensify commented on Jul 27, 2026

    @mallenexpensify
    Contributor

    @DylanDylann updated to $250 cuz of two PRs. (I don't have a great way to tell if it's more than one PRs that's been merged, cuz I usually scroll up to the first one linked, review, pay, close)

  13. quinthar commented on Aug 19, 2026

    @quinthar
    Contributor

    Approved $250 to @DylanDylann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions