You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-05-20] [Due for payment 2026-05-20] Report - Expense details load infinitelly after adding expense to empty report offline. #90287
Version Number: 9.3.70-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#89791 Email or phone of affected tester (no customers):ibellicotest+2250@gmail.com Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: Motorola MotoG60 / Android 12 (Hybrid app) - Windows 11 / Chrome App Component: Money Requests
Action Performed:
Prerequisite: Account has at least one workspace.
Open the staging.new.expensify.com website.
Open any workspace chat.
Create a new empty report.
Turn off internet connection.
Open the just created report and click on "Add Expense"
Add a new manual expense.
Note that after expense is created, receipt thumbnail is visible (On Web), but expense details load infinitelly.
Turn on internet connection
Note that now, expense details load correctly.
Expected Result:
Expense report should be automatically visible without glitches or excesive loading after adding an expense to an empty report while offline.
Actual Result:
After adding an expense to an empty report while offline, expense´s details load infinitelly on report. On Web, only receipt thumbnail is correctly visible and on Android app, entire report loads infinitelly.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #89791 - "Re-land of smooth post-submit navigation and rendering on Spend tab" by @JakubKorytko (High confidence) Related Issues: #89669 (previous deploy blocker that this PR was trying to fix)
Recommendation: REVERT
PR #89791 introduced a regression in the offline flow for adding expenses to empty reports. Reverting it will resolve the infinite loading state.
Assigned: @JakubKorytko (PR author), @ShridharGoel, @mountiny (approving reviewers) Labels: Both DeployBlockerCash and DeployBlocker are already present. The fix is in App (frontend), so DeployBlocker (backend label) should be removed. DeployBlockerCash (App label) should stay.
Details
Evidence
The issue is reproducible on staging but not production, consistent with it being introduced by a PR in the current staging deploy.
PR #89791 introduced MoneyReportContentCreated, a new component that handles the IOU/Expense/Invoice branch of ReportActionItemContentCreated. Inside it, a transient pending state is detected via:
This flag is forwarded as isTotalPending to MoneyReportView, which then renders an ActivityIndicator instead of the total amount. The intent is to handle the brief gap between a transaction landing in Onyx and the transaction-thread report's useOnyx subscription delivering.
The offline bug: When a user adds an expense to an empty report while offline, the transaction is written optimistically to Onyx locally, making isSingleTransactionReport return true. However, transactionThreadReport?.reportID never arrives because the API call to create the thread report cannot complete without network connectivity. As a result, isPendingSingleExpenseThread remains true indefinitely — the ActivityIndicator is shown forever and expense details never load.
Additionally, in MoneyRequestReportActionsList.tsx, the isAwaitingDeferredTransaction skeleton logic uses hasDeferredWriteForReport — a non-reactive module-level Map check. When offline, the deferred write mechanism may not behave as expected (the write callback may never execute), potentially also contributing to the report loading infinitely on Android.
The previous version of this code (before PR #89791) did not have this issue because the ReportActionItemContentCreated component did not have the isPendingSingleExpenseThread transient-gap detection; the component fell through to MoneyReportView directly without the pending override.
changed the title [-]Report - Expense details load infinitelly after adding expense to empty report offline.[/-][+][Due for payment 2026-05-20] Report - Expense details load infinitelly after adding expense to empty report offline.[/+]on May 13, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.72-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@ShridharGoel The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
changed the title [-][Due for payment 2026-05-20] Report - Expense details load infinitelly after adding expense to empty report offline.[/-][+][Due for payment 2026-05-20] [Due for payment 2026-05-20] Report - Expense details load infinitelly after adding expense to empty report offline.[/+]on May 13, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.73-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@ShridharGoel The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon May 12, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #89791
melvin-bot commentedon May 12, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 12, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon May 12, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #89791 - "Re-land of smooth post-submit navigation and rendering on Spend tab" by @JakubKorytko (High confidence)
Related Issues: #89669 (previous deploy blocker that this PR was trying to fix)
Recommendation: REVERT
PR #89791 introduced a regression in the offline flow for adding expenses to empty reports. Reverting it will resolve the infinite loading state.
Assigned: @JakubKorytko (PR author), @ShridharGoel, @mountiny (approving reviewers)
Labels: Both
DeployBlockerCashandDeployBlockerare already present. The fix is in App (frontend), soDeployBlocker(backend label) should be removed.DeployBlockerCash(App label) should stay.Details
Evidence
MoneyReportContentCreatedcomponent andisTotalPendinglogic was designed to handle.Verification
The affected files from PR #89791 that relate directly to this bug:
src/pages/inbox/report/MoneyReportContentCreated.tsx(new file introduced by the PR)src/components/ReportActionItem/MoneyReportView.tsx(modified to acceptisTotalPendingprop)src/components/MoneyRequestReportView/MoneyRequestReportActionsList.tsx(modified skeleton logic)Root Cause
PR #89791 introduced
MoneyReportContentCreated, a new component that handles the IOU/Expense/Invoice branch ofReportActionItemContentCreated. Inside it, a transient pending state is detected via:This flag is forwarded as
isTotalPendingtoMoneyReportView, which then renders anActivityIndicatorinstead of the total amount. The intent is to handle the brief gap between a transaction landing in Onyx and the transaction-thread report'suseOnyxsubscription delivering.The offline bug: When a user adds an expense to an empty report while offline, the transaction is written optimistically to Onyx locally, making
isSingleTransactionReportreturntrue. However,transactionThreadReport?.reportIDnever arrives because the API call to create the thread report cannot complete without network connectivity. As a result,isPendingSingleExpenseThreadremainstrueindefinitely — theActivityIndicatoris shown forever and expense details never load.Additionally, in
MoneyRequestReportActionsList.tsx, theisAwaitingDeferredTransactionskeleton logic useshasDeferredWriteForReport— a non-reactive module-level Map check. When offline, the deferred write mechanism may not behave as expected (the write callback may never execute), potentially also contributing to the report loading infinitely on Android.The previous version of this code (before PR #89791) did not have this issue because the
ReportActionItemContentCreatedcomponent did not have theisPendingSingleExpenseThreadtransient-gap detection; the component fell through toMoneyReportViewdirectly without the pending override.5 remaining items
IuliiaHerets commentedon May 12, 2026
Issue not repro anymore on Web and Android, v9.3.70-3
screen-20260512-125719.mp4
expense.detail.mp4
[-]Report - Expense details load infinitelly after adding expense to empty report offline.[/-][+][Due for payment 2026-05-20] Report - Expense details load infinitelly after adding expense to empty report offline.[/+]melvin-bot commentedon May 13, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 13, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.72-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-20. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 13, 2026
@ShridharGoel The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[-][Due for payment 2026-05-20] Report - Expense details load infinitelly after adding expense to empty report offline.[/-][+][Due for payment 2026-05-20] [Due for payment 2026-05-20] Report - Expense details load infinitelly after adding expense to empty report offline.[/+]melvin-bot commentedon May 13, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.73-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-20. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 13, 2026
@ShridharGoel The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]