Skip to content

[Due for payment 2026-05-29] Add ExportDownload Onyx foundation and shared export action functions #90295

Closed

Description

@mollfpr

Context

Shared foundation for the Bulk Report PDF Export and Improve Report Export
Realtime Delivery projects. No user-visible changes — nothing renders yet.

Changes

src/types/onyx/ExportDownload.ts (new file)

  • Discriminated union type. reportCount and failedReportCount are optional
    even in the ready state — present for PDF exports, absent for CSV exports

src/CONST/index.ts

  • Add EXPORT_DOWNLOAD: { STATE: { PREPARING, READY, FAILED } } constants

src/ONYXKEYS.ts

  • Add EXPORT_DOWNLOAD: 'nvp_exportDownload_' to the COLLECTION object
  • Map to OnyxTypes.ExportDownload in OnyxCollectionValuesMapping

src/libs/API/types.ts

  • Add SEND_EXPORT_FILE_FROM_CONCIERGE and CLEAR_EXPORT_DOWNLOAD to
    WRITE_COMMANDS
  • Add SendExportFileFromConciergeParams and ClearExportDownloadParams,
    each with {exportID: string}
  • Map them in WriteCommandParameters

src/libs/actions/Export.ts (new file)

  • sendExportFileFromConcierge(exportID) — optimistically merges
    {shouldSendFromConcierge: true}, calls
    API.write(SEND_EXPORT_FILE_FROM_CONCIERGE, {exportID})
  • clearExportDownload(exportID) — optimistically sets Onyx key to null,
    calls API.write(CLEAR_EXPORT_DOWNLOAD, {exportID})
  • clearStaleExportDownloads() — iterates
    ONYXKEYS.COLLECTION.EXPORT_DOWNLOAD and calls clearExportDownload
    for each entry found

src/libs/Navigation/AppNavigator/AuthScreensInitHandler.tsx

  • Call Export.clearStaleExportDownloads() alongside existing
    Download.clearDownloads()

Testing

Unit tests in tests/unit/ExportActionsTest.ts:

  • sendExportFileFromConcierge merges {shouldSendFromConcierge: true} into
    the correct Onyx key
  • sendExportFileFromConcierge failureData clears Onyx key
  • clearExportDownload sets Onyx key to null
  • clearStaleExportDownloads calls clearExportDownload for each non-null
    entry in the collection
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. self-assigned this
    on May 12, 2026
  2. mollfpr commented on May 12, 2026

    @mollfpr
    ContributorAuthor

    @daledah as reviewer and @truph01 will implementing 🙌

  3. truph01 commented on May 14, 2026

    @truph01
    Contributor

    I’m working on the PR. It should be ready for review EOD.

  4. 14 remaining items

  5. mollfpr commented on Jun 2, 2026

    @mollfpr
    ContributorAuthor

    Hey! Payment's due, and I think the full amount is fair —

    • No proposals: I reached out to a C+ contributor directly to take these on, so the proposal step was skipped intentionally rather than missed.
    • No test videos: the 2 prep issues didn't have anything to demo by design (setup work, no user-facing behavior to record). The 2 wire-up PRs do include testing.

    So I don't think a reduction applies — per-issue at the standard rate works for me.

    @daledah @truph01 also wanted to check in with you: does the standard rate feel fair given the scope of the work? Happy to revisit if not.

  6. mallenexpensify commented on Jun 2, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @truph01 due $250 via NewDot
    Contributor+: @daledah due $250 via NewDot

    @mollfpr I'm assuming we either don'e need a test case or that you're going to take care of that elsewhere. If not, please reopen.

  7. quinthar commented on Jul 5, 2026

    @quinthar
    Contributor

    Approved $250 to @daledah

  8. garrettmknight commented on Aug 10, 2026

    @garrettmknight
    Contributor

    $250 approved for @truph01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions