Skip to content

[Due for payment 2026-07-21] [$125] iOS - Workspace - Circle icon is shown on top left of Members, Categories, Taxes, Distance rates #90374

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.70-3
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #87256
Email or phone of affected tester (no customers): sdsdjoijdoisnjodis@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: iPhone 15 Pro Max / iOS 26.4.2
App Component: Workspace Settings

Action Performed:

  1. Launch Expensify app in landscape mode.
  2. Go to workspace settings.
  3. Go to Members, Categories, Taxes and Distance rates page.

Expected Result:

There will be no circle icon on the top left of the page.

Actual Result:

Circle icon is visible on the top left of Members, Categories, Taxes and Distance rates page.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Video.mp4
Image

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mallenexpensify
Upwork Automation - Do Not Edit

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 12, 2026
  2. melvin-bot commented on May 12, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #87256

  3. melvin-bot commented on May 12, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on May 12, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. OSBotify commented on May 12, 2026

    @OSBotify
    Contributor

    Investigation Summary

    Classification: Frontend bug
    Causing PR: #87256 - "Use desktop layout for header buttons in landscape mode" by @GCyganek (High confidence)
    Related Issues: N/A

    Recommendation: REVERT

    PR #87256 introduced the regression. In landscape mode on iOS, the PR changed workspace settings pages (Members, Categories, Taxes, Distance Rates) to place header buttons in the header row instead of a separate line, but the illustration icon (e.g. ReceiptWrangler) passed via the icon prop to HeaderWithBackButton is still rendered unconditionally. This causes the circle icon to appear on the top-left of those pages in landscape mode — a layout path that was not exercised before this PR.

    Assigned: @GCyganek (PR author), @truph01 @mountiny (approving reviewers)
    Labels: DeployBlockerCash kept (Frontend bug in App). No label changes needed.

    Detailed Analysis

    Evidence

    • The issue is staging-only (Reproducible in production?: No), version 9.3.70-3, which matches the current StagingDeployCash.
    • melvin-bot already flagged PR Use dekstop layout for header buttons in landscape mode #87256 as the likely cause.
    • PR Use dekstop layout for header buttons in landscape mode #87256 is the first chronological PR in the StagingDeployCash deploy checklist.
    • The bug affects workspace settings pages that are explicitly modified in the PR: WorkspaceMembersPage.tsx, WorkspaceCategoriesPage.tsx, WorkspaceTaxesPage.tsx, and PolicyDistanceRatesPage.tsx.
    • The PR was merged 2026-05-08, and the bug is in the staging version deployed after that merge.

    Verification

    • PR Use dekstop layout for header buttons in landscape mode #87256 directly modifies all four files named in the bug report: WorkspaceMembersPage.tsx, WorkspaceCategoriesPage.tsx, WorkspaceTaxesPage.tsx (via WorkspaceTaxesPage.tsx), and PolicyDistanceRatesPage.tsx.
    • The new useShouldDisplayButtonsInSeparateLine hook (src/hooks/useShouldDisplayButtonsInSeparateLine.ts) returns shouldUseNarrowLayout && !isInLandscapeMode. On iOS in landscape mode this returns false.
    • Each affected page passes headerContent={!shouldDisplayButtonsInSeparateLine && getHeaderButtons()} to WorkspacePageWithSections, which in turn passes it to HeaderWithBackButton. In landscape mode, !false = true so buttons are rendered in the header row. However, the icon prop (e.g. illustrations.ReceiptWrangler) is still also passed and renders unconditionally in HeaderWithBackButton at line 271–278, creating the visible circle icon on the top-left.

    Root Cause

    Before PR #87256, headerContent was only populated when !shouldUseNarrowLayout (i.e. wide/desktop layout). On iOS in landscape mode, shouldUseNarrowLayout was true, so headerContent was false and buttons appeared below the header. After the PR, landscape mode is treated like desktop, so buttons move into the header row. The problem is that the icon illustration (used for the headline header style on narrow portrait layouts) is now also shown in the same header row in landscape mode, appearing as an unexpected circle icon on the top-left. The fix should either conditionally suppress the icon prop in landscape mode, or the PR should be reverted.

  6. MelvinBot commented on May 12, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    PR #87256 introduced useShouldDisplayButtonsInSeparateLine, which returns false in landscape mode on mobile (shouldUseNarrowLayout && !isInLandscapeMode). When false, buttons move into the header row via headerContent. However, the icon prop (e.g. illustrations.ReceiptWrangler) is still passed unconditionally to HeaderWithBackButton, which renders it as a 48×48px circle in the compact header bar.

    The asymmetry is: headerContent is gated on !shouldDisplayButtonsInSeparateLine, but icon is only gated on !selectionModeHeader — it has no landscape awareness.

    What changes do you think we should make in order to solve the problem?

    On each affected page, suppress the icon when shouldDisplayButtonsInSeparateLine is false (i.e., landscape mode). Change:

    icon={!selectionModeHeader ? illustrations.X : undefined}
    

    to:

    icon={!selectionModeHeader && shouldDisplayButtonsInSeparateLine ? illustrations.X : undefined}
    

    Affected files:

    What alternative solutions did you explore? (Optional)

    1. Suppress icon centrally in HeaderWithBackButton when children is provided — cleaner single-point fix but risks unintended side effects on pages that intentionally show both icon and children.
    2. Suppress icon in WorkspacePageWithSections when headerContent is truthy — covers most pages but misses PolicyDistanceRatesPage which uses HeaderWithBackButton directly.

    The per-page fix is most explicit, least risky, and keeps intent clear at each call site.


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  7. 94 remaining items

  8. melvin-bot commented on Jul 31, 2026

    @melvin-bot

    Auto-assign attempt failed, all eligible assignees are OOO.

  9. mountiny commented on Jul 31, 2026

    @mountiny
    Contributor

    I believe this is a regression from original PR so the only payment due is $125 to @samranahm

  10. changed the title [-][Due for payment 2026-07-21] [$250] iOS - Workspace - Circle icon is shown on top left of Members, Categories, Taxes, Distance rates[/-] [+][Due for payment 2026-07-21] [$125] iOS - Workspace - Circle icon is shown on top left of Members, Categories, Taxes, Distance rates[/+] on Jul 31, 2026
  11. melvin-bot commented on Jul 31, 2026

    @melvin-bot

    Upwork job price has been updated to $125

  12. melvin-bot commented on Aug 3, 2026

    @melvin-bot

    @mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  13. mallenexpensify commented on Aug 4, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @samranahm paid $125 via Upwork
    Contributor+: @truph01 due $125 via NewDot

  14. truph01 commented on Aug 4, 2026

    @truph01
    Contributor

    @mallenexpensify It looks like you missed my payment, as I also worked on this issue.

  15. mallenexpensify commented on Aug 5, 2026

    @mallenexpensify
    Contributor

    @truph01 paid, summary updated above. Thx., apologies for missing that

  16. garrettmknight commented on Sep 3, 2026

    @garrettmknight
    Contributor

    $125 approved for @truph01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions