Skip to content

[Due for payment 2026-05-26] [Due for payment 2026-05-26] [$250] Hmm.. it's not here page displayed after entering magic code #90880

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.75-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from BrowserStack:
Email or phone of affected tester (no customers): applausetester+mn03employee@applause.expensifail.com, applausetester+0516mn2@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation (hyperlinked to channel name):

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Enter expensifail or gmail account
  3. Enter the magic code received

Expected Result:

User able to signin and navigated to Home tab

Actual Result:

Hmm...it's not here page displayed

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Recording.2866.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mallenexpensify
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022056536156735942602
  • Upwork Job ID: 2056536156735942602
  • Last Price Increase: 2026-05-19

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 16, 2026
  2. melvin-bot commented on May 16, 2026

    @melvin-bot

    Triggered auto assignment to @blimpich (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on May 16, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on May 16, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. MelvinBot commented on May 16, 2026

    @MelvinBot
    Contributor

    Proposal

    Root Cause: PR #87928 ("Replace individual private detail edit pages with unified form + magic code") modified core navigation files — ROUTES.ts, SCREENS.ts, and linkingConfig/config.ts — which altered the route structure. After signing in with a magic code, the app attempts to navigate to the home screen but hits an unmatched route, falling through to the catch-all NOT_FOUND screen (* route) which renders the FullPageNotFoundView ("Hmm... it's not here").

    This explains why it reproduces on staging (which includes PR #87928) but not production (which doesn't).

    Fix: This has already been reverted by PR #90835, which was merged on May 15 and is included in the 9.3.75-1 deploy checklist. The revert undoes all navigation config changes from PR #87928.

    Investigation details

    How the not-found page works:

    • The catch-all route [SCREENS.NOT_FOUND]: '*' in config.ts matches any URL that doesn't match a defined route
    • This renders NotFoundPage → FullPageNotFoundView with the "Hmm... it's not here" message
    • After magic code sign-in, if the post-auth redirect targets a path that no longer matches a valid route, the user lands here

    PR #87928 changes that likely caused this:

    • Modified ROUTES.ts and SCREENS.ts (added/changed route definitions for private personal details)
    • Modified linkingConfig/config.ts (navigation linking configuration)
    • Modified SETTINGS_TO_RHP.ts (right-hand panel relations)
    • These changes could have caused route matching conflicts or broken the default post-sign-in navigation path

    Timeline:

    Related issues in this deploy:

    Recommended action: Verify the sign-in flow on the latest staging build (which should include the revert). If the issue persists after confirming the revert is deployed, further investigation into other navigation-related PRs in this deploy will be needed.


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  6. OSBotify commented on May 16, 2026

    @OSBotify
    Contributor

    Investigation Summary

    Classification: Frontend bug
    Causing PR: Unable to determine with confidence — see candidates below
    Related Issues: #90834 (another deploy blocker in this staging cycle)

    Recommendation: NEEDS INVESTIGATION

    The "Hmm...it's not here" page appearing immediately after magic code sign-in is a serious regression, but I was unable to identify a single PR with medium or high confidence. The most likely candidates are identified below. The PR authors and reviewers should verify and determine which change introduced this routing failure.

    Assigned: @JakubKorytko (PR author of #90044), @ZhenjaHorbach @mountiny (reviewers of #90044), @adhorodyski (PR author of #90696), @Pujan92 @roryabraham (reviewers of #90696)
    Labels: DeployBlockerCash label kept — this is a staging-only issue caused by an App PR; DeployBlocker not present so no change needed.

    Detailed Analysis

    Evidence

    Issue summary: After navigating to staging.new.expensify.com, entering an email/phone account, and entering the magic code, users land on the "Hmm...it's not here" page (FullPageNotFoundView) instead of the Home tab. Reproducible on staging only (not production), on Chrome and Safari (web), version 9.3.75-1.

    Candidate PR 1 — Medium confidence:
    #90044 — "Fix reveal navigation under RHP + re-land reveal workspace route under RHP before dismissing on workspace creation" by @JakubKorytko (merged 2026-05-15T11:58:41Z)

    This PR introduced substantial navigation history management via a new addRootHistoryRouterExtension.ts and heavily modified GetStateForActionHandlers.ts. Key concerns:

    • Adds REVEAL_PADDING sentinels to state.history that persist across navigation actions.
    • The getRehydratedState path (called on every state rebuild, including post-sign-in) now prepends padding sentinels via applyRevealPaddingOffset. If any lingering REVEAL_PADDING exists from a prior navigation epoch and isn't cleared during sign-in's resetRoot, it could misalign the history length vs routes length, causing the browser URL to resolve to an incorrect route — including NOT_FOUND.
    • SCREENS.NOT_FOUND is in MODAL_ROUTES_TO_DISMISS (line 38 of GetStateForActionHandlers.ts). If this was newly added in this PR, the handleDismissModalAction path could interact unexpectedly during the post-sign-in navigation transition.
    • The PR description notes this fixes prior deploy blockers (Reveal workspace route under RHP before dismissing on workspace creation #89605), which means this code is already known to have subtle side effects.

    Candidate PR 2 — Low-Medium confidence:
    #90696 — "Make NetInfo reachability ping environment-aware" by @adhorodyski (merged 2026-05-15T15:12:12Z)

    This PR changes configureAndSubscribe() in NetworkState.ts from a synchronous call to an async one deferred behind getEnvironment().then(...). On staging builds, if getEnvironment() takes longer to resolve (e.g., on ADHOC or STAGING environments that require a native bridge call), NetInfo may not be configured during the initial sign-in window. If isOffline defaults to false and isLoadingReportData transitions to false before reports arrive, ReportNotFoundGuard could show the "not here" page because shouldShowNotFoundPage = !isLoading && !reportExists becomes true. This is specifically staging-only behavior given the async environment detection path.

    Verification

    Files affected by the bug path:

    Verification for PR #90044: Check whether GetStateForActionHandlers.ts existed before this PR and whether SCREENS.NOT_FOUND was already in MODAL_ROUTES_TO_DISMISS. Also verify that after magic code sign-in, Navigation.resetRoot() properly clears any REVEAL_PADDING sentinels from a previous navigation epoch.

    Verification for PR #90696: Check if on staging web, getEnvironment() resolution is delayed enough to cause NetInfo to be unconfigured during the sign-in sequence. Specifically verify whether isOffline could be false while isLoadingReportData becomes false before reports are loaded.

    Root Cause

    The root cause is likely one of the following:

    1. The navigation history padding introduced by PR Fix reveal navigation under RHP + re-land reveal workspace route under RHP before dismissing on workspace creation  #90044's addRootHistoryRouterExtension persists across the sign-in state reset, causing the browser URL to be misresolved to NOT_FOUND after authentication completes.

    2. The async getEnvironment() deferral in PR Make NetInfo reachability ping environment-aware #90696 causes a window where NetInfo's reachability detection is not configured, leading to incorrect isOffline state that triggers ReportNotFoundGuard to show "not here" before reports have loaded on staging.

    Both PRs touch staging-specific code paths and were merged on 2026-05-15 — the same day this regression was introduced.

  7. JakubKorytko commented on May 16, 2026

    @JakubKorytko
    Member

    Not really sure how the workspace navigation could affect magic code page, seems like Melvin found the better candidate than my PR. Will take a look just in case on Monday.

  8. 62 remaining items

  9. mkhutornyi commented on May 30, 2026

    @mkhutornyi
    Contributor

    @MelvinBot provide issue summary based on comments history

  10. MelvinBot commented on May 30, 2026

    @MelvinBot
    Contributor

    Issue Summary

    Bug: After entering the magic code on staging, users landed on the "Hmm... it's not here" page instead of the Home tab. Reproducible on staging, not production.

    Reproduction steps (consistent repro by mkhutornyi on 2026-05-18):

    1. Logout if already logged in
    2. Refresh browser (key step)
    3. Login with existing account
    4. Enter magic code

    Root Cause: PR #85740 added an extra condition hasCompletedGuidedSetupFlowSelector(val) in src/libs/actions/Link.ts. For old/migrated accounts with an empty onboarding object, that selector returns true, so handleDeeplinkNavigation() fired before login completed — pushing the user to the catch-all NOT_FOUND route.

    Fix: PR #91022 — added isAuthenticated guard. Deployed in v9.3.75-14 → production v9.3.77-3.


    Timeline of False Leads


    Contributors & Roles

    User Role Contribution
    m-natarajan Reporter (Applause QA) Reported the issue
    mkhutornyi Reviewer Found consistent reproduction steps; reviewed proposals; selected apeyada's; implemented the fix via MelvinBot
    apeyada Contributor (proposal author) Posted the accepted proposal with the correct one-line fix
    JakubKorytko Contractor (investigator) Investigated and ruled out his own PR #90044; confirmed staging-only nature
    adhorodyski Contractor (assigned via OSBotify) Auto-assigned as a candidate PR author; PR #90696 ruled out
    mountiny Reviewer Coordinated QA retesting, created revert PR #90982
    roryabraham Manager Assigned apeyada and authorized using MelvinBot for the implementation
    mallenexpensify BugZero Assignee Payment processing owner

    Payment Summary (from MelvinBot's auto-generated table)

    • adhorodyski — does NOT require payment (Contractor)
    • JakubKorytko — does NOT require payment (Contractor)
    • mkhutornyi — owed $250 via NewDot Manual Requests (Reviewer)
    • apeyada — requires payment via Upwork — Needs manual offer from BZ (Proposal author / Contributor)

    The Upwork job is at https://www.upwork.com/jobs/~022056536156735942602.

    Note: roryabraham explicitly approved using MelvinBot to implement apeyada's proposal in his comment and confirmed apeyada should still be compensated the standard proposal rate.

  11. mkhutornyi commented on May 30, 2026

    @mkhutornyi
    Contributor

    @mallenexpensify the summary is above. @apeyada and me are due compensation.
    BZ Checklist: #90880 (comment) in case you don't wanna click "Load more"

  12. mallenexpensify commented on May 30, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @apeyada paid $125 via Upwork
    Contributor+: @mkhutornyi due $250 via NewDot

    @apeyada can you please accept the job below? Please reply here and tag me once you have.
    If you're not sent an offer in Upwork when you're assigned to an issue, please tag me. If an Upwork job exists, please submit a proposal.
    https://www.upwork.com/jobs/~022056536156735942602

    ^ Test case created. Thx

    I'm still on the fence about using Melv for payment summaries cuz they often reference the payment summary auto-posts, vs stuff like ✔️ on PRs (and if tests were done on PRs, or not).

  13. apeyada commented on May 30, 2026

    @apeyada
    Contributor

    Thanks @mallenexpensify maybe full rate as per @roryabraham's comment?

  14. mallenexpensify commented on Jun 1, 2026

    @mallenexpensify
    Contributor

    Assigned to @apeyada, but @mkhutornyi if you want to use Melvin to implement the proposed solution so we can get it done sooner, that's fine with me. and we can still compensate @apeyada the standard rate for the proposal

    @apeyada the standard rate for using details from a proposal, where no work was done on a PR, is 50%, so $125.
    Historically, we've documented partial payments internally and in a C+ process doc, because they can occasionally change and we don't want outdate payment details out there. This is what we have

    50% if we or Melvin used non-trivial details from a proposal in the bug-fix PR.

    I do think we'll start seeing more 50% payments though, do you think it'd be helpful to have this on CONTRIBUTING.md? Thx

    @apeyada can you please accept the job below? Please reply here and tag me once you have.
    https://www.upwork.com/jobs/~022056536156735942602

  15. melvin-bot commented on Jun 4, 2026

    @melvin-bot

    @mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  16. melvin-bot commented on Jun 8, 2026

    @melvin-bot

    @mallenexpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  17. mallenexpensify commented on Jun 9, 2026

    @mallenexpensify
    Contributor

    @apeyada paid, summary updated above. Thx.

  18. trjExpensify commented on Jun 23, 2026

    @trjExpensify
    Contributor

    approved $250 for @mkhutornyi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions