You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-05-26] [Due for payment 2026-05-26] [$250] Hmm.. it's not here page displayed after entering magic code #90880
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Root Cause:PR #87928 ("Replace individual private detail edit pages with unified form + magic code") modified core navigation files — ROUTES.ts, SCREENS.ts, and linkingConfig/config.ts — which altered the route structure. After signing in with a magic code, the app attempts to navigate to the home screen but hits an unmatched route, falling through to the catch-all NOT_FOUND screen (* route) which renders the FullPageNotFoundView ("Hmm... it's not here").
This explains why it reproduces on staging (which includes PR #87928) but not production (which doesn't).
Fix: This has already been reverted by PR #90835, which was merged on May 15 and is included in the 9.3.75-1 deploy checklist. The revert undoes all navigation config changes from PR #87928.
Investigation details
How the not-found page works:
The catch-all route [SCREENS.NOT_FOUND]: '*' in config.ts matches any URL that doesn't match a defined route
This renders NotFoundPage → FullPageNotFoundView with the "Hmm... it's not here" message
After magic code sign-in, if the post-auth redirect targets a path that no longer matches a valid route, the user lands here
Recommended action: Verify the sign-in flow on the latest staging build (which should include the revert). If the issue persists after confirming the revert is deployed, further investigation into other navigation-related PRs in this deploy will be needed.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
Classification: Frontend bug Causing PR: Unable to determine with confidence — see candidates below Related Issues: #90834 (another deploy blocker in this staging cycle)
Recommendation: NEEDS INVESTIGATION
The "Hmm...it's not here" page appearing immediately after magic code sign-in is a serious regression, but I was unable to identify a single PR with medium or high confidence. The most likely candidates are identified below. The PR authors and reviewers should verify and determine which change introduced this routing failure.
Issue summary: After navigating to staging.new.expensify.com, entering an email/phone account, and entering the magic code, users land on the "Hmm...it's not here" page (FullPageNotFoundView) instead of the Home tab. Reproducible on staging only (not production), on Chrome and Safari (web), version 9.3.75-1.
Candidate PR 1 — Medium confidence: #90044 — "Fix reveal navigation under RHP + re-land reveal workspace route under RHP before dismissing on workspace creation" by @JakubKorytko (merged 2026-05-15T11:58:41Z)
This PR introduced substantial navigation history management via a new addRootHistoryRouterExtension.ts and heavily modified GetStateForActionHandlers.ts. Key concerns:
Adds REVEAL_PADDING sentinels to state.history that persist across navigation actions.
The getRehydratedState path (called on every state rebuild, including post-sign-in) now prepends padding sentinels via applyRevealPaddingOffset. If any lingering REVEAL_PADDING exists from a prior navigation epoch and isn't cleared during sign-in's resetRoot, it could misalign the history length vs routes length, causing the browser URL to resolve to an incorrect route — including NOT_FOUND.
SCREENS.NOT_FOUND is in MODAL_ROUTES_TO_DISMISS (line 38 of GetStateForActionHandlers.ts). If this was newly added in this PR, the handleDismissModalAction path could interact unexpectedly during the post-sign-in navigation transition.
This PR changes configureAndSubscribe() in NetworkState.ts from a synchronous call to an async one deferred behind getEnvironment().then(...). On staging builds, if getEnvironment() takes longer to resolve (e.g., on ADHOC or STAGING environments that require a native bridge call), NetInfo may not be configured during the initial sign-in window. If isOffline defaults to false and isLoadingReportData transitions to false before reports arrive, ReportNotFoundGuard could show the "not here" page because shouldShowNotFoundPage = !isLoading && !reportExists becomes true. This is specifically staging-only behavior given the async environment detection path.
Verification
Files affected by the bug path:
src/pages/inbox/ReportNotFoundGuard.tsx — This is the component that renders FullPageNotFoundView. The shouldShowNotFoundPage condition (line 53) fires when !isLoading && !reportExists. The isLoading guard depends on isLoadingApp !== false, isLoadingReportData, and isLoadingInitialReportActions.
Verification for PR #90044: Check whether GetStateForActionHandlers.ts existed before this PR and whether SCREENS.NOT_FOUND was already in MODAL_ROUTES_TO_DISMISS. Also verify that after magic code sign-in, Navigation.resetRoot() properly clears any REVEAL_PADDING sentinels from a previous navigation epoch.
Verification for PR #90696: Check if on staging web, getEnvironment() resolution is delayed enough to cause NetInfo to be unconfigured during the sign-in sequence. Specifically verify whether isOffline could be false while isLoadingReportData becomes false before reports are loaded.
The async getEnvironment() deferral in PR Make NetInfo reachability ping environment-aware #90696 causes a window where NetInfo's reachability detection is not configured, leading to incorrect isOffline state that triggers ReportNotFoundGuard to show "not here" before reports have loaded on staging.
Both PRs touch staging-specific code paths and were merged on 2026-05-15 — the same day this regression was introduced.
Not really sure how the workspace navigation could affect magic code page, seems like Melvin found the better candidate than my PR. Will take a look just in case on Monday.
Bug: After entering the magic code on staging, users landed on the "Hmm... it's not here" page instead of the Home tab. Reproducible on staging, not production.
Reproduction steps (consistent repro by mkhutornyi on 2026-05-18):
Logout if already logged in
Refresh browser (key step)
Login with existing account
Enter magic code
Root Cause: PR #85740 added an extra condition hasCompletedGuidedSetupFlowSelector(val) in src/libs/actions/Link.ts. For old/migrated accounts with an empty onboarding object, that selector returns true, so handleDeeplinkNavigation() fired before login completed — pushing the user to the catch-all NOT_FOUND route.
Fix: PR #91022 — added isAuthenticated guard. Deployed in v9.3.75-14 → production v9.3.77-3.
Timeline of False Leads
First Melvin proposal wrongly pointed at PR #87928 (already reverted by #90835) — not the cause.
OSBotify pointed at PRs #90044 (JakubKorytko) and #90696 (adhorodyski) — both investigated and ruled out.
Note: roryabraham explicitly approved using MelvinBot to implement apeyada's proposal in his comment and confirmed apeyada should still be compensated the standard proposal rate.
Contributor: @apeyada paid $125 via Upwork
Contributor+: @mkhutornyi due $250 via NewDot
@apeyada can you please accept the job below? Please reply here and tag me once you have.
If you're not sent an offer in Upwork when you're assigned to an issue, please tag me. If an Upwork job exists, please submit a proposal. https://www.upwork.com/jobs/~022056536156735942602
^ Test case created. Thx
I'm still on the fence about using Melv for payment summaries cuz they often reference the payment summary auto-posts, vs stuff like ✔️ on PRs (and if tests were done on PRs, or not).
Assigned to @apeyada, but @mkhutornyi if you want to use Melvin to implement the proposed solution so we can get it done sooner, that's fine with me. and we can still compensate @apeyada the standard rate for the proposal
@apeyada the standard rate for using details from a proposal, where no work was done on a PR, is 50%, so $125.
Historically, we've documented partial payments internally and in a C+ process doc, because they can occasionally change and we don't want outdate payment details out there. This is what we have
50% if we or Melvin used non-trivial details from a proposal in the bug-fix PR.
I do think we'll start seeing more 50% payments though, do you think it'd be helpful to have this on CONTRIBUTING.md? Thx
Activity
melvin-bot commentedon May 16, 2026
Triggered auto assignment to @blimpich (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon May 16, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 16, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon May 16, 2026
Proposal
Root Cause: PR #87928 ("Replace individual private detail edit pages with unified form + magic code") modified core navigation files —
ROUTES.ts,SCREENS.ts, andlinkingConfig/config.ts— which altered the route structure. After signing in with a magic code, the app attempts to navigate to the home screen but hits an unmatched route, falling through to the catch-allNOT_FOUNDscreen (*route) which renders theFullPageNotFoundView("Hmm... it's not here").This explains why it reproduces on staging (which includes PR #87928) but not production (which doesn't).
Fix: This has already been reverted by PR #90835, which was merged on May 15 and is included in the 9.3.75-1 deploy checklist. The revert undoes all navigation config changes from PR #87928.
Investigation details
How the not-found page works:
[SCREENS.NOT_FOUND]: '*'inconfig.tsmatches any URL that doesn't match a defined routeNotFoundPage→FullPageNotFoundViewwith the "Hmm... it's not here" messagePR #87928 changes that likely caused this:
ROUTES.tsandSCREENS.ts(added/changed route definitions for private personal details)linkingConfig/config.ts(navigation linking configuration)SETTINGS_TO_RHP.ts(right-hand panel relations)Timeline:
Related issues in this deploy:
Recommended action: Verify the sign-in flow on the latest staging build (which should include the revert). If the issue persists after confirming the revert is deployed, further investigation into other navigation-related PRs in this deploy will be needed.
Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.OSBotify commentedon May 16, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: Unable to determine with confidence — see candidates below
Related Issues: #90834 (another deploy blocker in this staging cycle)
Recommendation: NEEDS INVESTIGATION
The "Hmm...it's not here" page appearing immediately after magic code sign-in is a serious regression, but I was unable to identify a single PR with medium or high confidence. The most likely candidates are identified below. The PR authors and reviewers should verify and determine which change introduced this routing failure.
Assigned: @JakubKorytko (PR author of #90044), @ZhenjaHorbach @mountiny (reviewers of #90044), @adhorodyski (PR author of #90696), @Pujan92 @roryabraham (reviewers of #90696)
Labels:
DeployBlockerCashlabel kept — this is a staging-only issue caused by an App PR;DeployBlockernot present so no change needed.Detailed Analysis
Evidence
Issue summary: After navigating to
staging.new.expensify.com, entering an email/phone account, and entering the magic code, users land on the "Hmm...it's not here" page (FullPageNotFoundView) instead of the Home tab. Reproducible on staging only (not production), on Chrome and Safari (web), version 9.3.75-1.Candidate PR 1 — Medium confidence:
#90044 — "Fix reveal navigation under RHP + re-land reveal workspace route under RHP before dismissing on workspace creation" by @JakubKorytko (merged 2026-05-15T11:58:41Z)
This PR introduced substantial navigation history management via a new
addRootHistoryRouterExtension.tsand heavily modifiedGetStateForActionHandlers.ts. Key concerns:REVEAL_PADDINGsentinels tostate.historythat persist across navigation actions.getRehydratedStatepath (called on every state rebuild, including post-sign-in) now prepends padding sentinels viaapplyRevealPaddingOffset. If any lingeringREVEAL_PADDINGexists from a prior navigation epoch and isn't cleared during sign-in'sresetRoot, it could misalign the history length vs routes length, causing the browser URL to resolve to an incorrect route — includingNOT_FOUND.SCREENS.NOT_FOUNDis inMODAL_ROUTES_TO_DISMISS(line 38 ofGetStateForActionHandlers.ts). If this was newly added in this PR, thehandleDismissModalActionpath could interact unexpectedly during the post-sign-in navigation transition.Candidate PR 2 — Low-Medium confidence:
#90696 — "Make NetInfo reachability ping environment-aware" by @adhorodyski (merged 2026-05-15T15:12:12Z)
This PR changes
configureAndSubscribe()inNetworkState.tsfrom a synchronous call to an async one deferred behindgetEnvironment().then(...). On staging builds, ifgetEnvironment()takes longer to resolve (e.g., onADHOCorSTAGINGenvironments that require a native bridge call), NetInfo may not be configured during the initial sign-in window. IfisOfflinedefaults tofalseandisLoadingReportDatatransitions tofalsebefore reports arrive,ReportNotFoundGuardcould show the "not here" page becauseshouldShowNotFoundPage = !isLoading && !reportExistsbecomestrue. This is specifically staging-only behavior given the async environment detection path.Verification
Files affected by the bug path:
src/pages/inbox/ReportNotFoundGuard.tsx— This is the component that rendersFullPageNotFoundView. TheshouldShowNotFoundPagecondition (line 53) fires when!isLoading && !reportExists. TheisLoadingguard depends onisLoadingApp !== false,isLoadingReportData, andisLoadingInitialReportActions.src/libs/Navigation/AppNavigator/routerExtensions/addRootHistoryRouterExtension.ts— New in PR Fix reveal navigation under RHP + re-land reveal workspace route under RHP before dismissing on workspace creation #90044; manages history padding.src/libs/NetworkState.ts— Modified in PR Make NetInfo reachability ping environment-aware #90696; defers NetInfo configuration.Verification for PR #90044: Check whether
GetStateForActionHandlers.tsexisted before this PR and whetherSCREENS.NOT_FOUNDwas already inMODAL_ROUTES_TO_DISMISS. Also verify that after magic code sign-in,Navigation.resetRoot()properly clears anyREVEAL_PADDINGsentinels from a previous navigation epoch.Verification for PR #90696: Check if on staging web,
getEnvironment()resolution is delayed enough to cause NetInfo to be unconfigured during the sign-in sequence. Specifically verify whetherisOfflinecould befalsewhileisLoadingReportDatabecomesfalsebefore reports are loaded.Root Cause
The root cause is likely one of the following:
The navigation history padding introduced by PR Fix reveal navigation under RHP + re-land reveal workspace route under RHP before dismissing on workspace creation #90044's
addRootHistoryRouterExtensionpersists across the sign-in state reset, causing the browser URL to be misresolved toNOT_FOUNDafter authentication completes.The async
getEnvironment()deferral in PR Make NetInfo reachability ping environment-aware #90696 causes a window where NetInfo's reachability detection is not configured, leading to incorrectisOfflinestate that triggersReportNotFoundGuardto show "not here" before reports have loaded on staging.Both PRs touch staging-specific code paths and were merged on 2026-05-15 — the same day this regression was introduced.
JakubKorytko commentedon May 16, 2026
Not really sure how the workspace navigation could affect magic code page, seems like Melvin found the better candidate than my PR. Will take a look just in case on Monday.
62 remaining items
mkhutornyi commentedon May 30, 2026
@MelvinBot provide issue summary based on comments history
MelvinBot commentedon May 30, 2026
Issue Summary
Bug: After entering the magic code on staging, users landed on the "Hmm... it's not here" page instead of the Home tab. Reproducible on staging, not production.
Reproduction steps (consistent repro by
mkhutornyion 2026-05-18):Root Cause: PR #85740 added an extra condition
hasCompletedGuidedSetupFlowSelector(val)insrc/libs/actions/Link.ts. For old/migrated accounts with an empty onboarding object, that selector returnstrue, sohandleDeeplinkNavigation()fired before login completed — pushing the user to the catch-allNOT_FOUNDroute.Fix: PR #91022 — added
isAuthenticatedguard. Deployed in v9.3.75-14 → production v9.3.77-3.Timeline of False Leads
JakubKorytko) and #90696 (adhorodyski) — both investigated and ruled out.JakubKorytkoconfirmed bug was reproducible in v9.3.74-4/6 staging but NOT in v9.3.74-6 production → ruled out his own PR.mkhutornyifound the consistent browser-refresh repro, which unblocked the investigation.oqildev(external) posted a detailed proposal pointing at PR fix: User does not navigate to concierge chat via link when login with old account #85740 (Link.ts).apeyadaposted an equivalent proposal (auto-flagged as duplicate) with the minimal one-line fix.Contributors & Roles
m-natarajanmkhutornyiapeyada's; implemented the fix via MelvinBotapeyadaJakubKorytkoadhorodyskimountinyroryabrahamapeyadaand authorized using MelvinBot for the implementationmallenexpensifyPayment Summary (from MelvinBot's auto-generated table)
adhorodyski— does NOT require payment (Contractor)JakubKorytko— does NOT require payment (Contractor)mkhutornyi— owed $250 via NewDot Manual Requests (Reviewer)apeyada— requires payment via Upwork — Needs manual offer from BZ (Proposal author / Contributor)The Upwork job is at https://www.upwork.com/jobs/~022056536156735942602.
Note:
roryabrahamexplicitly approved using MelvinBot to implementapeyada's proposal in his comment and confirmedapeyadashould still be compensated the standard proposal rate.mkhutornyi commentedon May 30, 2026
@mallenexpensify the summary is above. @apeyada and me are due compensation.
BZ Checklist: #90880 (comment) in case you don't wanna click "Load more"
mallenexpensify commentedon May 30, 2026
Payment Summary
Contributor: @apeyada paid $125 via Upwork
Contributor+: @mkhutornyi due $250 via NewDot
@apeyada can you please accept the job below? Please reply here and tag me once you have.
If you're not sent an offer in Upwork when you're assigned to an issue, please tag me. If an Upwork job exists, please submit a proposal.
https://www.upwork.com/jobs/~022056536156735942602
^ Test case created. Thx
I'm still on the fence about using Melv for payment summaries cuz they often reference the payment summary auto-posts, vs stuff like ✔️ on PRs (and if tests were done on PRs, or not).
apeyada commentedon May 30, 2026
Thanks @mallenexpensify maybe full rate as per @roryabraham's comment?
mallenexpensify commentedon Jun 1, 2026
@apeyada the standard rate for using details from a proposal, where no work was done on a PR, is 50%, so $125.
Historically, we've documented partial payments internally and in a C+ process doc, because they can occasionally change and we don't want outdate payment details out there. This is what we have
I do think we'll start seeing more 50% payments though, do you think it'd be helpful to have this on CONTRIBUTING.md? Thx
@apeyada can you please accept the job below? Please reply here and tag me once you have.
https://www.upwork.com/jobs/~022056536156735942602
melvin-bot commentedon Jun 4, 2026
@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Jun 8, 2026
@mallenexpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
mallenexpensify commentedon Jun 9, 2026
@apeyada paid, summary updated above. Thx.
trjExpensify commentedon Jun 23, 2026
approved $250 for @mkhutornyi