Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.3.73-4
Reproducible in staging?: Needs Reproduction (Unable to reproduce)
Reproducible in production?: Needs Reproduction
If this was caught during regression testing, add the test name, ID and link from BrowserStack:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @abbagail
Slack conversation (hyperlinked to channel name): #Expensify Bugs
Action Performed:
Issue: 1
- login into Expensify in Classic or directly to New Expensify
- wait for the page to load
Issue: 2
- Login in to Expensify Classic
- switch to New Expensify
- refresh the page
- wait for New Expensify to load
Expected Result:
Page loads, and you're able to start working
Actual Result:
Page never loads. Even after trying to clean sign out and clearing cache and cookies. Sutck on the green E loading screen
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
Screenshots/Videos
The screenshot for the issue is in Slack thread
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~022056434464843697407
- Upwork Job ID: 2056434464843697407
- Last Price Increase: 2026-07-06
Metadata
Metadata
Assignees
Labels
Type
Projects
- StatusShow more project fieldsDone
Activity
exfy-zapier commentedon May 18, 2026
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
melvin-bot commentedon May 18, 2026
📣 @exfy-zapier! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
annaweber830 commentedon May 18, 2026
🚨 Edited by proposal-police: This proposal was edited at 2026-05-18 18:51:00 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
On Safari (macOS), New Expensify gets stuck on the green loading screen indefinitely. The splash screen never hides even after clearing cache and cookies.
What is the root cause of that problem?
The splash is gated on
shouldHideSplash, which requireshasAttemptedToOpenPublicRoomto be true. That flag only flips afterReport.doneCheckingPublicRoom()is called fromDeepLinkHandler. Both call sites inDeepLinkHandlerare inside auseEffectwhose body only runs onceisLoadingOnyxValuereturns false:DeepLinkHandler.tsx#L40-L43
allReportsMetadatacomes fromONYXKEYS.COLLECTION.REPORT— the largest collection in Onyx. On Safari, ITP and stricter IndexedDB policies can leave this collection instatus: 'loading'for an extended period or indefinitely. When that happens, thereturnfires on every render,Linking.getInitialURL()is never called,doneCheckingPublicRoom()is never called, and the splash never hides.The safety-net effect below also cannot help:
DeepLinkHandler.tsx#L131-L136
initialUrlProcessed.currentis only set inside the blocked effect, so this safety net is also a no-op when the main effect never runs.This is a regression introduced by PR #89745 (commit
6a10132bdb1), which expanded the loading gate fromisLoadingOnyxValue(sessionMetadata, isSelfTourViewedMetadata)to includeallReportsMetadata,conciergeReportIDMetadata,introSelectedMetadata, andbetasMetadata. The report collection was not needed in the gate —openReportFromDeepLink()already handles missing report data internally and waits for specific report keys when necessary. AddingallReportsMetadatato the gate made the splash screen's lifetime depend on the entire report collection hydration, which can stall on Safari.What changes do you think we should make in order to solve the problem?
Remove
allReportsMetadatafrom theisLoadingOnyxValuecheck and from the effect's dependency array.allReportsstill needs to be subscribed to (it is passed intoopenReportFromDeepLink), but its loading status does not need to gate URL resolution —openReportFromDeepLinkhandles the undefined/partial case itself.File:
src/DeepLinkHandler.tsxDeepLinkHandler.tsx#L31
Current code:
Updated code:
DeepLinkHandler.tsx#L40
Current code:
Updated code:
DeepLinkHandler.tsx#L114-L124
Current code:
Updated code:
With this change the
isLoadingOnyxValueguard clears as soon as session, concierge ID, intro selection, self-tour flag, and betas are ready — none of which depend on the full report collection.allReportsis still passed toopenReportFromDeepLinkas the available snapshot, and that function's own per-report wait logic handles the case where a specific report hasn't loaded yet. The splash is no longer held hostage byCOLLECTION.REPORThydration time.Only one file changes. No new state, no timeout heuristics, no behaviour change for the deep-link flow itself.
MelvinBot commentedon May 18, 2026
Proposal
What is the root cause of that problem?
The app gets stuck on the green "E" splash screen because the splash screen can only be hidden once all three gates in
Expensify.tsx:139resolve:If any one of these stalls, the splash screen stays visible indefinitely. The most likely culprit for Safari on macOS is the
isCheckingPublicRoomgate (which controlshasAttemptedToOpenPublicRoom). This Onyx keyRAM_ONLY_IS_CHECKING_PUBLIC_ROOMdefaults totrueand must be explicitly set tofalseafter the public room check completes. If the network request fails silently or thefinallyDatacallback is dropped (as was confirmed in the related #85763), this gate never opens and the splash screen stays stuck.A secondary Safari-specific factor is that Safari has stricter IndexedDB behavior (disabled in private browsing, lower storage quotas, incomplete clearing via DevTools). If Onyx's persistence layer (backed by IndexedDB) fails to initialize,
preferredLocalemay also never resolve, creating a second blocking gate.What changes do you think we should make in order to solve the problem?
This issue needs reproduction data first. The codebase already has built-in telemetry for exactly this scenario — the
startBootsplashMonitorfires a Sentry warning every 10 seconds while the splash screen is still visible, logging the exact gate status (isCheckingPublicRoom,preferredLocale,isNavigationReady, etc.).Recommended next steps:
[BootSplash] splash screen is still visiblewarnings from Safari user agents around the time this was reported — theextradata will show exactly which gate is stuckisCheckingPublicRoomis the stuck gate: the fix from [$250] Navigation- Web page stuck on logo when navigating to IOU while logout #85763 (PR [CP Staging] Revert "[No QA] Fix lost/duplicated requests in PersistedRequests (Issues 2, 3, 4, 5)" #85804) addressed a race condition inPersistedRequestsand a reauthentication middleware issue that could drop thefinallyDatathat sets this flag tofalse. Verify whether those fixes are included in v9.3.73-4, or if this is a recurrence on a different code pathpreferredLocaleis the stuck gate: add a timeout/fallback for locale loading that defaults toenif IndexedDB is unavailable (Safari private browsing scenario)What alternative solutions did you explore? (Optional)
A defensive timeout that force-hides the splash screen after N seconds was considered, but this would mask the root cause and could lead to a broken app state (rendering before data is ready). The telemetry-first approach is preferred since the instrumentation already exists.
Related issues
PersistedRequests.tsthat droppedfinallyData, leavingIS_CHECKING_PUBLIC_ROOMstuck attrue. Fixed in PR [CP Staging] Revert "[No QA] Fix lost/duplicated requests in PersistedRequests (Issues 2, 3, 4, 5)" #85804.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.melvin-bot commentedon May 18, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (
External)[-]Safari stuck loading on New Expensify[/-][+][$250] Safari stuck loading on New Expensify[/+]melvin-bot commentedon May 18, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022056434464843697407
nabi-ebrahimi commentedon May 18, 2026
Proposal
What is the root cause of that problem?
Expensifycannot mountNavigationRootor hide the splash until the public-room gate has completed. That is visible inshouldInitand theNavigationRootmount guard atExpensify.tsx#L293-L300.That gate is opened by
DeepLinkHandler, butDeepLinkHandlercurrently returns before it even callsLinking.getInitialURL()while any listed Onyx metadata is still loading, including the entire report collection atDeepLinkHandler.tsx#L31-L41. Because the call toReport.doneCheckingPublicRoom()is inside the URL-resolution path atDeepLinkHandler.tsx#L54-L83, a slow or stuckONYXKEYS.COLLECTION.REPORThydration prevents the public-room gate from opening at all.The report collection does not need to finish hydrating before startup URL resolution can begin.
openReportFromDeepLink()already handles missing report data by waiting for the specific report key when necessary atLink.ts#L330-L363. Blocking on the whole report collection before resolving the initial URL is what leaves Safari stuck on the green loading screen.What changes do you think we should make in order to solve the problem?
Remove
allReportsMetadatafrom theDeepLinkHandlerloading gate and dependency list.That keeps the existing deep-link flow intact, but stops the startup splash from depending on the full report collection hydration status.
allReportscan still be passed intoopenReportFromDeepLink()as the currently available snapshot, and the report-specific fallback inopenReportFromDeepLink()will continue to handle missing report data.Required changes:
ONYXKEYS.COLLECTION.REPORTfor the currentallReportssnapshot.allReportsMetadata.allReportsMetadatafromisLoadingOnyxValue(...).allReportsMetadata.statusfrom the effect dependency list.Tests to add:
DeepLinkHandlerwhereallReportsMetadata.statusisloadingbut the other required metadata is loaded, then assert thatLinking.getInitialURL()is still called andReport.doneCheckingPublicRoom()runs when the initial URL is null.openReportFromDeepLink()still receives the currentallReportssnapshot.A timeout fallback was proposed in the issue thread. That would eventually unblock the splash, but it still leaves the incorrect dependency in place and makes affected users wait for the timeout on normal startup. This proposal is not a duplicate because it removes the unnecessary report-collection loading gate instead of masking it with a delayed fallback.
The telemetry-first proposal is useful for confirming which splash gate is stuck in Sentry, but it does not fix the App-side root cause.
What alternative solutions did you explore? (Optional)
26 remaining items
yusufdeveloper2903 commentedon Jun 18, 2026
Updated my proposal above
Abdulloh0109 commentedon Jun 19, 2026
@abdulrahuman5196
What do you think about my proposal?
abdulrahuman5196 commentedon Jun 21, 2026
Hi, All the Contributor proposal seems theoretical solution got with the existing code flow.
But since we are not able to repro the issue, All Contributors who have made proposals, kindly add information on how you tested the issue and your fix? Did you repro the issue via UI in your local setup? if so share the steps.
Without proper reproducibility either way, we won't be able to understand if your fix is actually working.
Kindly update your proposals with the steps and add a comment once updated.
melvin-bot commentedon Jun 22, 2026
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
mvtglobally commentedon Jun 27, 2026
Issue not reproducible during KI retests. (First week)
melvin-bot commentedon Jun 29, 2026
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
mvtglobally commentedon Jul 3, 2026
Issue not reproducible during KI retests. (Second week)
melvin-bot commentedon Jul 6, 2026
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
abdulrahuman5196 commentedon Jul 8, 2026
Still not reproducible
mvtglobally commentedon Jul 11, 2026
Issue not reproducible during KI retests. (Third week)