Skip to content

Expense - The compact duplicate expense cards doesn't display Tags #91374

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.79-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #89587
Email or phone of affected tester (no customers): applausetester+bm55673@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Web, android
App Component: Money Requests

Action Performed:

Precondition -
Create duplicate expense with the same amount, each using a different merchant category and unique tags.

  1. Go to https://staging.new.expensify.com/
  2. Open the expense report containing those expenses.
  3. Click “Review duplicates.”

Expected Result:

According to the Tc it should include tags

Actual Result:

The compact duplicate expense cards doesn't display Tags

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Image
Bug7160138_1779403791252.bandicam_2026-05-22_01-42-25-494.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7160138

Issue OwnerCurrent Issue Owner: @sobitneupane

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 21, 2026
  2. applause-bot commented on May 21, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/759876f11e35117ca1d4127bb709d03e49fcf1ed2339df53e0d2ea109f291866

  3. melvin-bot commented on May 21, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #89587

  4. melvin-bot commented on May 21, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on May 21, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on May 21, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    PR #89587 switched the duplicate review screen to use TransactionItemRow with shouldUseNarrowLayout always set to true. The narrow layout variant (TransactionItemRowNarrow.tsx) only renders date and category in its second row via DateCell's suffixText prop — it never renders tags. The TagCell component is only imported and used in TransactionItemRowWide. Additionally, the TransactionItemRowNarrowComputedData type has categoryForDisplay but no tag-related field, and the dispatcher in index.tsx computes categoryForDisplay but never computes or passes tag data to the narrow layout.

    What changes do you think we should make in order to solve the problem?

    1. In TransactionItemRow/index.tsx, compute a tagForDisplay value for the narrow layout (similar to how categoryForDisplay is computed) and pass it to TransactionItemRowNarrow.
    2. Add tagForDisplay to the TransactionItemRowNarrowComputedData type.
    3. In TransactionItemRowNarrow.tsx, append the tag to the DateCell suffixText (e.g., date * category * tag) or render it as a separate text element in the second row, gated by a shouldShowTag prop so it only appears when relevant (e.g., in the duplicate review context or when the policy has tags enabled).
    Investigation details

    The existing pattern in DateCell already supports suffix text: [const displayText = suffixText ? \${formattedDate} * ${suffixText}` : formattedDate](https://github.com/Expensify/App/blob/d14747711ed3fb5e9cdce4082f3c6c3135b05715/src/components/Search/SearchList/ListItem/DateCell.tsx#L28). The category is passed this way today. A combined suffix like category * tag` would follow the same pattern.

    DuplicateTransactionItem.tsx passes shouldUseNarrowLayout which forces the narrow variant. This is the only caller that needs tags in the narrow layout, so a shouldShowTag prop could scope the change appropriately.


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  7. deetergp commented on May 22, 2026

    @deetergp
    Contributor

    I do think we should fix this but I don't think it needs to be a blocker.

    cc @nabi-ebrahimi

  8. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on May 22, 2026
  9. nabi-ebrahimi commented on May 22, 2026

    @nabi-ebrahimi
    Contributor

    @deetergp, my apologies, I mistakenly added tags to this list.

    Image

    But the OP expected behavior doesn't contain tags, so I think we only need to update the test steps for this.

    Image
  10. deetergp commented on May 22, 2026

    @deetergp
    Contributor

    @nabi-ebrahimi Fair enough. I think if you edit the test steps on the original PR, I can ask for a retest and they will test it in the right order and then we can close this issue out.

  11. sobitneupane commented on May 22, 2026

    @sobitneupane
    Contributor

    This is expected behavior, so we can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions