You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Version Number: 9.3.79-1 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#89587 Email or phone of affected tester (no customers):applausetester+bm55673@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: Web, android App Component: Money Requests
Action Performed:
Precondition -
Create duplicate expense with the same amount, each using a different merchant category and unique tags.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
PR #89587 switched the duplicate review screen to use TransactionItemRow with shouldUseNarrowLayout always set to true. The narrow layout variant (TransactionItemRowNarrow.tsx) only renders date and category in its second row via DateCell's suffixText prop — it never renders tags. The TagCell component is only imported and used in TransactionItemRowWide. Additionally, the TransactionItemRowNarrowComputedData type has categoryForDisplay but no tag-related field, and the dispatcher in index.tsx computes categoryForDisplay but never computes or passes tag data to the narrow layout.
What changes do you think we should make in order to solve the problem?
In TransactionItemRow/index.tsx, compute a tagForDisplay value for the narrow layout (similar to how categoryForDisplay is computed) and pass it to TransactionItemRowNarrow.
In TransactionItemRowNarrow.tsx, append the tag to the DateCellsuffixText (e.g., date * category * tag) or render it as a separate text element in the second row, gated by a shouldShowTag prop so it only appears when relevant (e.g., in the duplicate review context or when the policy has tags enabled).
Investigation details
The existing pattern in DateCell already supports suffix text: [const displayText = suffixText ? \${formattedDate} * ${suffixText}` : formattedDate](https://github.com/Expensify/App/blob/d14747711ed3fb5e9cdce4082f3c6c3135b05715/src/components/Search/SearchList/ListItem/DateCell.tsx#L28). The category is passed this way today. A combined suffix like category * tag` would follow the same pattern.
DuplicateTransactionItem.tsx passes shouldUseNarrowLayout which forces the narrow variant. This is the only caller that needs tags in the narrow layout, so a shouldShowTag prop could scope the change appropriately.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
@nabi-ebrahimi Fair enough. I think if you edit the test steps on the original PR, I can ask for a retest and they will test it in the right order and then we can close this issue out.
Activity
applause-bot commentedon May 21, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/759876f11e35117ca1d4127bb709d03e49fcf1ed2339df53e0d2ea109f291866
melvin-bot commentedon May 21, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #89587
melvin-bot commentedon May 21, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 21, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon May 21, 2026
Proposal
What is the root cause of that problem?
PR #89587 switched the duplicate review screen to use
TransactionItemRowwithshouldUseNarrowLayoutalways set totrue. The narrow layout variant (TransactionItemRowNarrow.tsx) only renders date and category in its second row viaDateCell'ssuffixTextprop — it never renders tags. TheTagCellcomponent is only imported and used inTransactionItemRowWide. Additionally, theTransactionItemRowNarrowComputedDatatype hascategoryForDisplaybut no tag-related field, and the dispatcher inindex.tsxcomputescategoryForDisplaybut never computes or passes tag data to the narrow layout.What changes do you think we should make in order to solve the problem?
TransactionItemRow/index.tsx, compute atagForDisplayvalue for the narrow layout (similar to howcategoryForDisplayis computed) and pass it toTransactionItemRowNarrow.tagForDisplayto theTransactionItemRowNarrowComputedDatatype.TransactionItemRowNarrow.tsx, append the tag to theDateCellsuffixText(e.g.,date * category * tag) or render it as a separate text element in the second row, gated by ashouldShowTagprop so it only appears when relevant (e.g., in the duplicate review context or when the policy has tags enabled).Investigation details
The existing pattern in
DateCellalready supports suffix text: [const displayText = suffixText ? \${formattedDate} * ${suffixText}` : formattedDate](https://github.com/Expensify/App/blob/d14747711ed3fb5e9cdce4082f3c6c3135b05715/src/components/Search/SearchList/ListItem/DateCell.tsx#L28). The category is passed this way today. A combined suffix likecategory * tag` would follow the same pattern.DuplicateTransactionItem.tsxpassesshouldUseNarrowLayoutwhich forces the narrow variant. This is the only caller that needs tags in the narrow layout, so ashouldShowTagprop could scope the change appropriately.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.deetergp commentedon May 22, 2026
I do think we should fix this but I don't think it needs to be a blocker.
cc @nabi-ebrahimi
nabi-ebrahimi commentedon May 22, 2026
@deetergp, my apologies, I mistakenly added tags to this list.
But the OP expected behavior doesn't contain tags, so I think we only need to update the test steps for this.
deetergp commentedon May 22, 2026
@nabi-ebrahimi Fair enough. I think if you edit the test steps on the original PR, I can ask for a retest and they will test it in the right order and then we can close this issue out.
sobitneupane commentedon May 22, 2026
This is expected behavior, so we can close this.