You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Web -Workspace-Blank space appear for a brief moment after refreshing the page #9159
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
I can't tell if it's a regression or a fix of some sort though - on production, the label "Unlock next-day reimbursements" appears as a placeholder until the view gets updated with "Fast reimbursements = happy members!". So I'm assuming there's something that makes a network request to know what exact message the user should be shown, and the staging app doesn't show anything until that network request has received a response.
Going to dig a bit more to verify this hypothesis though.
There are 2 separate Get calls that are made when the user clicks Reimburse Expenses:
Get nameValuePairs with nvp name = expensify_freePlanBankAccountID,
Get nameValuePairs, bankAccountList with nvpNames=private_failedBankValidations_,expensify_migration_2020_04_28_RunKycVerifications,expensify_ACHData_throttled,private_throttledHistory_BankAccount_Get
And that hasn't changed on this version that is currently on staging. The only change is that we no longer show the wrong placeholder "Unlock next-day reimbursements", so I would lean on this not being a blocker or regression. Curious for other opinions though.
This was a purposeful fix for #9057. While I agree it's not the most optimal to have that brief delay while the ACH state is loading, I think it's an improvement over what was in place. Shouldn't be a deploy blocker at the least.
I agree with not even keeping this as an improvement. The solutions I can think of would be:
Add a skeleton screen while the network requests are pending. However that sounds like a bigger project we might want to plan out in detail first, and potentially use those skeletons every time some UI components are drawn after a network request completes (and also would most likely be on hold until the Offline First changes are finished)
Random example of what I'm talking about:
Load the NVPs and bankAccountList preemptively, and store them in Onyx - but I don't think that would be a suitable solution because we get NVPs like expensify_ACHData_throttled and private_throttledHistory_BankAccount_Get, which we probably don't want to cache in Onyx, and instead load every time.
Activity
OSBotify commentedon May 24, 2022
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon May 24, 2022
Triggered auto assignment to @francoisl (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.francoisl commentedon May 24, 2022
The blank space is almost unnoticeable on my personal account and also on web with the high traffic account applausetester+0901abb@applause.expensifail.com, I only notice it on mWeb.
I can't tell if it's a regression or a fix of some sort though - on production, the label "Unlock next-day reimbursements" appears as a placeholder until the view gets updated with "Fast reimbursements = happy members!". So I'm assuming there's something that makes a network request to know what exact message the user should be shown, and the staging app doesn't show anything until that network request has received a response.
Going to dig a bit more to verify this hypothesis though.
screen-20220524-154353.mp4
screen-20220524-154334.mp4
francoisl commentedon May 24, 2022
There are 2 separate
Getcalls that are made when the user clicks Reimburse Expenses:Get nameValuePairswith nvp name =expensify_freePlanBankAccountID,Get nameValuePairs, bankAccountListwithnvpNames=private_failedBankValidations_,expensify_migration_2020_04_28_RunKycVerifications,expensify_ACHData_throttled,private_throttledHistory_BankAccount_GetAnd that hasn't changed on this version that is currently on staging. The only change is that we no longer show the wrong placeholder "Unlock next-day reimbursements", so I would lean on this not being a blocker or regression. Curious for other opinions though.
amyevans commentedon May 25, 2022
This was a purposeful fix for #9057. While I agree it's not the most optimal to have that brief delay while the ACH state is loading, I think it's an improvement over what was in place. Shouldn't be a deploy blocker at the least.
Julesssss commentedon May 25, 2022
Thanks both, I agree that this is an overall improvement and shouldn't hold up deployment. 👍
Julesssss commentedon May 25, 2022
I guess now the question is: should we leave this open as an improvement? I'd say probably not, but happy either way.
francoisl commentedon May 25, 2022
I agree with not even keeping this as an improvement. The solutions I can think of would be:
Random example of what I'm talking about:
expensify_ACHData_throttledandprivate_throttledHistory_BankAccount_Get, which we probably don't want to cache in Onyx, and instead load every time.francoisl commentedon Jun 8, 2022
Going to close this since the root issue should be fixed now. We can consider adding skeleton UI later.