Skip to content

[Due for payment 2026-06-09] Wallet - Continue setup and Start over button do not appear after returning to initial page #91884

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.84-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #88193
Email or phone of affected tester (no customers): applausetester+ssndjois2jd1@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: User Settings

Action Performed:

Precondition:

  • Have a workspace.
  1. Go to staging.new.expensify.com
  2. Go to Account > Wallet.
  3. Click Add bank account.
  4. Select Make payments.
  5. Select United States > Next.
  6. Click Connect manually.
  7. Click Confirm.
  8. Enter account numbers > Next.
  9. Enter name > Next.
  10. Click RHP back button 4 times to return to initial page.

Expected Result:

Continue setup and Start over button will appear.

Actual Result:

Log into your bank and Connect manually button appear.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7164538_1779906363927.8.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Svetlana Lazutkina
Bug ID: 7164538

Issue OwnerCurrent Issue Owner: @dukenv0307

Activity

  1. applause-bot commented on May 27, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/5048b67776280298aabe11c739201110834c8117fcf09a9f338776cbd1f2ec2e

  2. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 27, 2026
  3. melvin-bot commented on May 27, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #88193

  4. melvin-bot commented on May 27, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on May 27, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on May 27, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    In the wallet flow (Account > Wallet > Add bank account), no policyID is passed in the route params. After the user partially completes the manual bank connection, the backend populates achData.policyID with a real policy ID. When the user navigates back to the entry point, hasInProgressVBBA compares achData.policyID (a real ID) against the route's policyIDParam (undefined) — they never match, so it returns false, and "Continue setup" / "Start over" buttons are never shown.

    This is a regression from PR #88193 which moved the USD flow to URL-based navigation. Previously, the inline flow's goBack handler explicitly called setShouldShowContinueSetupButton(true) when navigating back from the Country step with an in-progress VBBA. That code path is no longer reachable from the new URL-based flow.

    What changes do you think we should make in order to solve the problem?

    In hasInProgressVBBA, when policyID is undefined (wallet flow), skip the policyID comparison check. For example:

    if (policyID !== undefined && achData?.policyID !== policyID) {
        return false;
    }
    

    This allows the wallet flow (which has no policy context) to correctly detect in-progress bank accounts while preserving the existing guard for workspace-specific flows.

    What alternative solutions did you explore? (Optional)

    An alternative would be to pass achData.policyID into the route when navigating back, but this would require changes to the navigation layer and could introduce inconsistencies. The simpler guard on undefined correctly models the intended behavior: the wallet flow should recognize any in-progress VBBA regardless of policy.

    Investigation details

    Evidence chain:

    1. Wallet's CountrySelection calls navigateToBankAccountRoute without a policyID
    2. ReimbursementAccountPage computes shouldShowContinueSetupButton via hasInProgressVBBA(achData, isNonUSDWorkspace, policyIDParam) where policyIDParam is undefined
    3. hasInProgressVBBA returns false because achData.policyID (real ID from backend) !== undefined
    4. VerifiedBankAccountFlowEntryPoint renders "Log into your bank" / "Connect manually" instead of "Continue setup" / "Start over"

    Possibly related open issues:

    • Expensify/App#89200 — Bank Account Setup Stuck in "Review" State While Prompting User to Continue Setup (similar hasInProgressVBBA detection issue)

    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  7. arosiclair commented on May 27, 2026

    @arosiclair
    Contributor

    I reproduced in I reproduced this. We can still restart or continue the BBA flow in this state. The continuing behavior is also improved now if you leave and come back to the app (previously it would still continue from step 1). I'm going to demote this and we'll clean it up in a follow up. cc @MrMuzyk

  8. 6 remaining items

  9. VickyStash commented on May 28, 2026

    @VickyStash
    Contributor

    Fix suggested by Melv tests well, so I've opened a PR: #91939

  10. added and removed
    ReviewingHas a PR in review
    on Jun 2, 2026
  11. changed the title [-]Wallet - Continue setup and Start over button do not appear after returning to initial page[/-] [+][Due for payment 2026-06-09] Wallet - Continue setup and Start over button do not appear after returning to initial page[/+] on Jun 2, 2026
  12. melvin-bot commented on Jun 2, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Jun 2, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.90-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-06-09. 🎊

    For reference, here are some details about the assignees on this issue:

    • @MrMuzyk does not require payment (Contractor)
    • @dukenv0307 requires payment through NewDot Manual Requests
  14. melvin-bot commented on Jun 2, 2026

    @melvin-bot

    @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. dukenv0307 commented on Jun 2, 2026

    @dukenv0307
    Contributor

    We can close it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions