Skip to content

Workspace - After connecting bank account, white screen is shown when opening the tabs #9196

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Access staging.new.expensify.com
  2. Sign into a valid account (I used applause.expensifail.com account)
  3. Connect a bank account through VBA flow
  4. Tap on "Profile" > "Workspace"
  5. Tap on the internal options (For example: "Issue cards, Pay Bills, etc.)

Expected Result:

The user expects for the page to immediately load as it has in past regressions or display some type of message in case there needs to be a wait time or something similar

Actual Result:

The user is shown a blank white page that can stay for a couple of seconds

Workaround:

Uknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.68.2

Reproducible in staging?: Yes

Reproducible in production?: No

**Email or phone of affected tester: ** applauseteser+emilio@applause.expensifail.com/Emilio98

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5587227_White_Screens_shown_on_Staging.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Activity

  1. OSBotify commented on May 26, 2022

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on May 26, 2022

    @melvin-bot

    Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. marcaaron commented on May 27, 2022

    @marcaaron
    Contributor

    Seems like this is the expected behavior based on the changes we agreed to here...

    #9170 cc @amyevans

    But looking at this video now it does look a little janky.

    I think since we are in the process of improving the Offline UX we shouldn't go too crazy with trying to get this 100% perfect. But the workspace settings are kind of an important flow so maybe we should get it looking right. Open to other opinions.

    cc @aldo-expensify @luacmartins @francoisl as well.

  4. marcaaron commented on May 27, 2022

    @marcaaron
    Contributor

    I understand that basically contradicts the thumbs up in this thread #9170 (comment) (😶‍🌫️) but I did not watch the video 😬

  5. aldo-expensify commented on May 27, 2022

    @aldo-expensify
    Contributor

    I think since we are in the process of improving the Offline UX we shouldn't go too crazy with trying to get this 100% perfect. But the workspace settings are kind of an important flow so maybe we should get it looking right. Open to other opinions.

    I agree, there will be cases where a crappy connection makes the white screen stay for a while. I'm guessing it should be easy to put a spinner as a temporary thing.

  6. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on May 27, 2022
  7. Julesssss commented on May 27, 2022

    @Julesssss
    Contributor

    There are a few of these issues and I agree that this could/should be improved with spinner or content loading shapes (don't know the correct name for this). But also, it can probably wait until after offline/refactor has been completed.

    Removing the deploy blocker label.

  8. amyevans commented on May 27, 2022

    @amyevans
    Contributor

    I'll throw together a PR adding spinners to make this a little better for now, and we can improve later more holistically 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions