You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Workspace - After connecting bank account, white screen is shown when opening the tabs #9196
Sign into a valid account (I used applause.expensifail.com account)
Connect a bank account through VBA flow
Tap on "Profile" > "Workspace"
Tap on the internal options (For example: "Issue cards, Pay Bills, etc.)
Expected Result:
The user expects for the page to immediately load as it has in past regressions or display some type of message in case there needs to be a wait time or something similar
Actual Result:
The user is shown a blank white page that can stay for a couple of seconds
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
But looking at this video now it does look a little janky.
I think since we are in the process of improving the Offline UX we shouldn't go too crazy with trying to get this 100% perfect. But the workspace settings are kind of an important flow so maybe we should get it looking right. Open to other opinions.
I think since we are in the process of improving the Offline UX we shouldn't go too crazy with trying to get this 100% perfect. But the workspace settings are kind of an important flow so maybe we should get it looking right. Open to other opinions.
I agree, there will be cases where a crappy connection makes the white screen stay for a while. I'm guessing it should be easy to put a spinner as a temporary thing.
There are a few of these issues and I agree that this could/should be improved with spinner or content loading shapes (don't know the correct name for this). But also, it can probably wait until after offline/refactor has been completed.
Activity
OSBotify commentedon May 26, 2022
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon May 26, 2022
Triggered auto assignment to @marcaaron (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.marcaaron commentedon May 27, 2022
Seems like this is the expected behavior based on the changes we agreed to here...
#9170 cc @amyevans
But looking at this video now it does look a little janky.
I think since we are in the process of improving the Offline UX we shouldn't go too crazy with trying to get this 100% perfect. But the workspace settings are kind of an important flow so maybe we should get it looking right. Open to other opinions.
cc @aldo-expensify @luacmartins @francoisl as well.
marcaaron commentedon May 27, 2022
I understand that basically contradicts the thumbs up in this thread #9170 (comment) (😶🌫️) but I did not watch the video 😬
aldo-expensify commentedon May 27, 2022
I agree, there will be cases where a crappy connection makes the white screen stay for a while. I'm guessing it should be easy to put a spinner as a temporary thing.
Julesssss commentedon May 27, 2022
There are a few of these issues and I agree that this could/should be improved with spinner or content loading shapes (don't know the correct name for this). But also, it can probably wait until after offline/refactor has been completed.
Removing the deploy blocker label.
amyevans commentedon May 27, 2022
I'll throw together a PR adding spinners to make this a little better for now, and we can improve later more holistically 😄