Skip to content

[Due for payment 2026-06-16] Add high contrast option to sign up screen #92049

Closed

Description

@dubielzyk-expensify

Background

We've recently implemented a high contrast theme to New Expensify that makes the app more accessible for our users with various disabilities or needs. This is now live and can be enabled in the app under Account > Preferences > Theme > Turn on high contrast mode.

Problem

For the app to pass all accessibility requirements the path to turn this on needs to be available immediately when accessing the app

Solution

Add an ability to turn on high contrast mode from the sign up or log in screen in the footer.

Image Image

cc @Expensify/design @rushatgabhane

Issue OwnerCurrent Issue Owner: @Eskalifer1

Activity

  1. abhishek123pal commented on May 29, 2026

    @abhishek123pal

    Proposal

    Problem / Alternative Analysis

    To meet strict accessibility compliance, users must be able to toggle high-contrast mode immediately on the public landing/sign-up screen without needing to navigate into authenticated settings. This option belongs in the public footer layout alongside the existing language/locale and theme selection triggers.

    Technical Implementation

    1. Target Component: I will locate the public layout footer (likely inside src/pages/signin/SignInPageLayout or src/components/SignInPageFooter) where the language selector button group currently lives.
    2. State & Onyx Management: Rather than introducing isolated local component state that resets on refresh, I will utilize Expensify’s global state system. I will call the existing User.updateThemePreference() action (or modify ONYXKEYS.USER_INTERFACE_SETTINGS directly) to toggle the theme context to dark-contrast or light-contrast. This ensures that even for an unauthenticated client, the preference is saved globally across reloads and persists seamlessly when they transition to the authenticated layout after signing up.
    3. UI Reusability: I will reuse the existing toggle/button primitives used elsewhere in the onboarding screens to preserve visual consistency with the design system, avoiding any hardcoded CSS overrides.
    4. Accessibility (A11y): The toggle will be appended correctly into the linear tabIndex keyboard navigation order, use an explicit role="switch", and leverage proper aria-checked and aria-label tags derived from localized translation strings (src/languages/).

    Risks/Regressions

    Low risk. Utilizing the core User action layer guarantees that setting a high-contrast theme on a logged-out screen will not inadvertently break or cause sync collisions with preexisting cloud preferences once the user finishes authenticating.

  2. melvin-bot commented on May 29, 2026

    @melvin-bot

    📣 @abhishek123pal! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  3. dannymcclain commented on May 29, 2026

    @dannymcclain
    Contributor

    Seems good to me. @dubielzyk-expensify what kind of control is that in the footer? What does it look like when enabled? Sorry for all the questions I just wanna undersand!

  4. samranahm commented on May 29, 2026

    @samranahm
    Contributor

    @dannymcclain @dubielzyk-expensify I'd love your thoughts on this

    Image Image Image
  5. rushatgabhane commented on May 29, 2026

    @rushatgabhane
    Member

    Hey @dubielzyk-expensify I couldn't find the moon icon in app. Could you please send that svg

    Also.. can you please help me with the width of that container

  6. dubielzyk-expensify commented on Jun 1, 2026

    @dubielzyk-expensify
    ContributorAuthor

    (@dannymcclain and I synced in Slack so ignoring those comments 😅)

    I'd prefer not to have the switch toggle, but maybe that makes more sense. I know it's inconsistent but I kinda want it to just work like a link like this:

    Image

    Here's the SVG:

    moon.svg.zip

  7. melvin-bot commented on Jun 5, 2026

    @melvin-bot

    Triggered auto assignment to @luacmartins, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  8. mitarachim commented on Jun 5, 2026

    @mitarachim

    Deploy Blocker #92117 was identified to be related to the PR #92117 that attempted to fix this issue.

  9. 7 remaining items

  10. Eskalifer1 commented on Jun 17, 2026

    @Eskalifer1
    Contributor

    I reviewed the original PR; I think it should be due for payment

  11. melvin-bot commented on Jun 17, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  12. Eskalifer1 commented on Jun 17, 2026

    @Eskalifer1
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR: N/A - new feature

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template

    Regression Test Proposal

    Precondition:

    • Be logout

    Test:

    1. On Sign in page, verify that "Enable high contrast" button shows above language selector.
    2. Tap the button
    3. Verify that page goes high-contrast.
    4. Tap again. Verify page is normal contrast.
    5. Sign in and verify that the theme updates to contrast version of whatever the past theme was.

    Do we agree 👍 or 👎

    Zapier Logs Run ID: 00040eee-f6ee-a21e-1365-a4c23b99cf14
  13. Eskalifer1 commented on Jun 17, 2026

    @Eskalifer1
    Contributor

    Hi @mallenexpensify!

    This PR was relatively large and took several review rounds to fix most of the bugs; as a result, there was only one minor regression (a one-line fix), which was implemented as a follow-up, but since I wasn’t available (I was OOO), another C+ reviewed it.

    This information is for whoever will be processing the payment.

  14. mallenexpensify commented on Jun 17, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @Eskalifer1 paid $250 via NewDot

    @Eskalifer1 can you please accept the job below? Please reply here and tag me once you have.
    https://www.upwork.com/jobs/~022067325759130704075

    Treating this issue and the regression as an edge case cuz

    • @Eskalifer1 stated a week before he was going to be out (his plans had been in place for a long while)
    • It's an Accessibility issue and we want this project wrapped ASAP
    • PR is large.
  15. Eskalifer1 commented on Jun 17, 2026

    @Eskalifer1
    Contributor

    Hi @mallenexpensify, thank you! I have accepted!

  16. mallenexpensify commented on Jun 17, 2026

    @mallenexpensify
    Contributor

    @Eskalifer1 paid, summary updated above. Thx.

  17. QichenZhu commented on Jun 19, 2026

    @QichenZhu
    Contributor

    FYI we resolved a follow up issue where the switch button's state was inconsistent with the UI theme. More details: #92824 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions