You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-06-16] Add high contrast option to sign up screen #92049
We've recently implemented a high contrast theme to New Expensify that makes the app more accessible for our users with various disabilities or needs. This is now live and can be enabled in the app under Account > Preferences > Theme > Turn on high contrast mode.
Problem
For the app to pass all accessibility requirements the path to turn this on needs to be available immediately when accessing the app
Solution
Add an ability to turn on high contrast mode from the sign up or log in screen in the footer.
To meet strict accessibility compliance, users must be able to toggle high-contrast mode immediately on the public landing/sign-up screen without needing to navigate into authenticated settings. This option belongs in the public footer layout alongside the existing language/locale and theme selection triggers.
Technical Implementation
Target Component: I will locate the public layout footer (likely inside src/pages/signin/SignInPageLayout or src/components/SignInPageFooter) where the language selector button group currently lives.
State & Onyx Management: Rather than introducing isolated local component state that resets on refresh, I will utilize Expensify’s global state system. I will call the existing User.updateThemePreference() action (or modify ONYXKEYS.USER_INTERFACE_SETTINGS directly) to toggle the theme context to dark-contrast or light-contrast. This ensures that even for an unauthenticated client, the preference is saved globally across reloads and persists seamlessly when they transition to the authenticated layout after signing up.
UI Reusability: I will reuse the existing toggle/button primitives used elsewhere in the onboarding screens to preserve visual consistency with the design system, avoiding any hardcoded CSS overrides.
Accessibility (A11y): The toggle will be appended correctly into the linear tabIndex keyboard navigation order, use an explicit role="switch", and leverage proper aria-checked and aria-label tags derived from localized translation strings (src/languages/).
Risks/Regressions
Low risk. Utilizing the core User action layer guarantees that setting a high-contrast theme on a logged-out screen will not inadvertently break or cause sync collisions with preexisting cloud preferences once the user finishes authenticating.
📣 @abhishek123pal! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
Seems good to me. @dubielzyk-expensify what kind of control is that in the footer? What does it look like when enabled? Sorry for all the questions I just wanna undersand!
(@dannymcclain and I synced in Slack so ignoring those comments 😅)
I'd prefer not to have the switch toggle, but maybe that makes more sense. I know it's inconsistent but I kinda want it to just work like a link like this:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: N/A - new feature
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
This PR was relatively large and took several review rounds to fix most of the bugs; as a result, there was only one minor regression (a one-line fix), which was implemented as a follow-up, but since I wasn’t available (I was OOO), another C+ reviewed it.
This information is for whoever will be processing the payment.
Activity
abhishek123pal commentedon May 29, 2026
Proposal
Problem / Alternative Analysis
To meet strict accessibility compliance, users must be able to toggle high-contrast mode immediately on the public landing/sign-up screen without needing to navigate into authenticated settings. This option belongs in the public footer layout alongside the existing language/locale and theme selection triggers.
Technical Implementation
src/pages/signin/SignInPageLayoutorsrc/components/SignInPageFooter) where the language selector button group currently lives.User.updateThemePreference()action (or modifyONYXKEYS.USER_INTERFACE_SETTINGSdirectly) to toggle the theme context todark-contrastorlight-contrast. This ensures that even for an unauthenticated client, the preference is saved globally across reloads and persists seamlessly when they transition to the authenticated layout after signing up.tabIndexkeyboard navigation order, use an explicitrole="switch", and leverage properaria-checkedandaria-labeltags derived from localized translation strings (src/languages/).Risks/Regressions
Low risk. Utilizing the core
Useraction layer guarantees that setting a high-contrast theme on a logged-out screen will not inadvertently break or cause sync collisions with preexisting cloud preferences once the user finishes authenticating.melvin-bot commentedon May 29, 2026
📣 @abhishek123pal! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
dannymcclain commentedon May 29, 2026
Seems good to me. @dubielzyk-expensify what kind of control is that in the footer? What does it look like when enabled? Sorry for all the questions I just wanna undersand!
samranahm commentedon May 29, 2026
@dannymcclain @dubielzyk-expensify I'd love your thoughts on this
rushatgabhane commentedon May 29, 2026
Hey @dubielzyk-expensify I couldn't find the moon icon in app. Could you please send that svg
Also.. can you please help me with the width of that container
dubielzyk-expensify commentedon Jun 1, 2026
(@dannymcclain and I synced in Slack so ignoring those comments 😅)
I'd prefer not to have the switch toggle, but maybe that makes more sense. I know it's inconsistent but I kinda want it to just work like a link like this:
Here's the SVG:
moon.svg.zip
melvin-bot commentedon Jun 5, 2026
Triggered auto assignment to @luacmartins, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
mitarachim commentedon Jun 5, 2026
Deploy Blocker #92117 was identified to be related to the PR #92117 that attempted to fix this issue.
7 remaining items
Eskalifer1 commentedon Jun 17, 2026
I reviewed the original PR; I think it should be due for payment
melvin-bot commentedon Jun 17, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)Eskalifer1 commentedon Jun 17, 2026
BugZero Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: N/A - new feature
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/649802
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
Zapier Logs
Run ID: 00040eee-f6ee-a21e-1365-a4c23b99cf14Eskalifer1 commentedon Jun 17, 2026
Hi @mallenexpensify!
This PR was relatively large and took several review rounds to fix most of the bugs; as a result, there was only one minor regression (a one-line fix), which was implemented as a follow-up, but since I wasn’t available (I was OOO), another C+ reviewed it.
This information is for whoever will be processing the payment.
mallenexpensify commentedon Jun 17, 2026
Payment Summary
Contributor+: @Eskalifer1 paid $250 via NewDot
@Eskalifer1 can you please accept the job below? Please reply here and tag me once you have.
https://www.upwork.com/jobs/~022067325759130704075
Treating this issue and the regression as an edge case cuz
Eskalifer1 commentedon Jun 17, 2026
Hi @mallenexpensify, thank you! I have accepted!
mallenexpensify commentedon Jun 17, 2026
@Eskalifer1 paid, summary updated above. Thx.
QichenZhu commentedon Jun 19, 2026
FYI we resolved a follow up issue where the switch button's state was inconsistent with the UI theme. More details: #92824 (comment).