Skip to content

iOS - Distance - Unable to drag and drop waypoints #92205

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.90-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #92153
Email or phone of affected tester (no customers): jsodinjosdjsoinjsiojs@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: iPhone 15 Pro Max / iOS 26.5
App Component: Money Requests

Action Performed:

  1. Launch Expensify app.
  2. Open FAB > Track distance > Map.
  3. Long tap on Start and drag it below Stop.

Expected Result:

User can drag and drop waypoints.

Actual Result:

User is unable to drag and drop waypoints.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7168438_1780311267925.ScreenRecording_06-01-2026_18-53-14_1.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7168438

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 1, 2026
  2. applause-bot commented on Jun 1, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/7138ff3151ef9f6a920eece98cda3f0c8d21788f347e32588f13ad340d9456ec

  3. melvin-bot commented on Jun 1, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #92153

  4. melvin-bot commented on Jun 1, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jun 1, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on Jun 1, 2026

    @MelvinBot
    Contributor

    Proposal

    Confidence: Medium–High that Expensify/App#92153 (the FullStory babel‑plugin bump) is the trigger. The exact code‑level mechanism is not yet confirmed — see the caveat below. The fastest safe confirmation is a revert‑test on iOS.

    What is the root cause of that problem?

    Waypoint drag‑and‑drop on the distance Map tab is a pre‑existing feature (shipped 2026‑03‑31) that works in production. It only broke in staging 9.3.90-0, and only on iOS App.

    The only change in this deploy that alters runtime behavior exclusively on iOS New Architecture is Expensify/App#92153, which bumped the FullStory babel plugins:

    • @fullstory/babel-plugin-react-native 1.5.2 → 1.6.4
    • @fullstory/babel-plugin-annotate-react 2.3.2 → 2.4.0

    @fullstory/babel-plugin-react-native injects/annotates a synthetic ref into essentially every component, but only when Platform.OS === 'ios' and New Arch (TurboModules/Bridgeless) is enabled. That platform guard matches the iOS‑App‑only repro exactly — Android, web, and mWeb are unaffected, which is why no plain JS‑source bug fits. The long‑press → drag handoff for waypoint rows (IOURequestStepDistanceMap.tsx#L392-L410 → onSecondaryInteraction={drag} → PressableWithSecondaryInteraction/index.native.tsx#L58) stops activating the drag on iOS after this bump.

    Why I'm confident it's #92153, and how I ruled out alternatives

    ⚠️ Caveat — mechanism unconfirmed: The obvious theory (v1.6.4 makes the synthetic ref non‑enumerable so it no longer leaks through {...rest} spreads) does not hold under a full audit of the drag chain: every component in the path (DraggableList.native, draggable‑flatlist's CellRendererComponent, gesture‑handler's GestureDetector, PressableWithSecondaryInteraction.native, PressableWithFeedback, GenericPressable, MenuItem) forwards ref explicitly. So the precise broken line is still unknown — this conclusion rests on the version + iOS‑only‑platform + QA correlation, not a proven line of code. The remaining concrete lead is whether @fullstory/babel-plugin-annotate-react@2.4.0 changed how it tags JSX in a way that interferes with react-native-gesture-handler's React.Children.only around the draggable cells. Confirming requires an iOS‑device repro.

    What changes do you think we should make in order to solve the problem?

    Because this is a deploy blocker, the safe + fast path:

    1. CP‑revert Expensify/App#92153 from the 9.3.90 staging branch, then re‑QA waypoint drag‑and‑drop on iOS to confirm it returns. ⚠️ This reintroduces the tax‑name autofocus bug that fix: Tax - No autofocus in the name editing menu taxes #92153 fixed (Expensify/App#76650) — an acceptable temporary tradeoff to unblock the deploy.
    2. Re‑land the FullStory bump only after verifying iOS‑native long‑press/drag flows on a physical iOS device (distance waypoints and any other react-native-draggable-flatlist usages). If the bump is still required, prefer excluding FullStory annotation on the draggable cell / gesture‑wrapper components (or a patch-package fix) over shipping the global bump unverified against iOS drag flows.

    What alternative solutions did you explore? (Optional)

    Verified there is no gesture‑handler / reanimated / draggable‑flatlist version bump and no App‑source gesture change in this deploy (details above), so a non‑FullStory cause is unlikely. A definitive code‑level fix needs an iOS‑device reproduction to pin which FullStory transform breaks the drag — recommend the revert‑test first.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/92205) to create a draft PR (it would revert Expensify/App#92153).
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.

  7. IuliiaHerets commented on Jun 1, 2026

    @IuliiaHerets

    Issue is not repro using an ad hoc build

    ScreenRecording_06-01-2026.19-00-55_1.MP4
    Image
  8. self-assigned this
    on Jun 1, 2026
  9. kavimuru commented on Jun 1, 2026

    @kavimuru

    @lakchote not reproducible in staging

    ScreenRecording_06-01-2026.17-48-56_1.MP4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2ReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions