You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-06-17] [Due for payment 2026-06-16] Accounting - Offer available! is clickable for auditor which opens not here page #92812
Version Number: 9.4.0-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#92270 Email or phone of affected tester (no customers):sdsonjodjsodjos@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Workspace Settings
Action Performed:
Precondition:
User A invites User B to workspace as auditor.
Enable Accounting workspace settings > More features.
Perform steps below as auditor (User B).
Go to staging.new.expensify.com
Go to workspace settings > Accounting.
Click Offer available! next to Xero.
Expected Result:
Offer available! should not be clickable for auditor.
Actual Result:
Offer available! is clickable for auditor which opens not here page.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Regression from #92270 (read-only auditor access). The fix is fully within Expensify/App.
What is the root cause of that problem?
PR #92270 newly let auditors view the Accounting page (read access), but the "Offer available!" Xero badge still navigates everyone to an admin-only page.
The Xero badge's onBadgePress always navigates to the Claim Offer page — it is not gated by canWriteAccounting, unlike the adjacent "Setup" button right below it, which calls showReadOnlyModal() for read-only users: PolicyAccountingPage.tsx:362-367 (badge, ungated) vs. :372-394 (Setup button, gated).
The Claim Offer page is gated ADMIN-only — it passes accessVariants={[ADMIN]} but nopolicyFeature prop: ClaimOfferPage.tsx:138-142. An auditor is not an admin, so the wrapper renders the "not here" Not Found page.
Why the page loads for auditors but the badge target doesn't — mechanism
The new read-access mechanism in #92270 lives in AccessOrNotFoundWrapper.tsx:190-201: when a policyFeature prop is supplied, the ADMIN variant is filtered out and access is granted via canMemberRead(...) instead.
Accounting page passes policyFeature={POLICY_FEATURE.ACCOUNTING} → PolicyAccountingPage.tsx:668-672 → auditor passes the read check → page is visible.
Claim Offer page omits policyFeature and keeps accessVariants={[ADMIN]} → ADMIN check is not filtered out → auditor fails canEditWorkspaceSettings → Not Found page.
So the badge sends a read-only user to a route their role can't open — the bug is the ungated navigation, not the page guard itself (the Claim Offer / connect flow is intentionally a write action).
What changes do you think we should make in order to solve the problem?
Gate the badge press exactly like the adjacent "Setup" button: in onBadgePress at PolicyAccountingPage.tsx:363-367, when !canWriteAccounting, call showReadOnlyModal() and return instead of navigating to the Claim Offer route. This keeps read-only users on the "Not so fast" modal pattern already used everywhere else on this page.
What alternative solutions did you explore? (Optional)
Hide the badge entirely for read-only users (set badgeText/onBadgePress to undefined when !canWriteAccounting). This also fixes the crash-to-Not-Found, but it diverges from the page's established read-only pattern (show the control, route writes to the "Not so fast" modal), so gating the press is preferred.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/92812) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
changed the title [-]Accounting - Offer available! is clickable for auditor which opens not here page[/-][+][Due for payment 2026-06-16] Accounting - Offer available! is clickable for auditor which opens not here page[/+]on Jun 9, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.0-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@Julesssss The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
changed the title [-][Due for payment 2026-06-16] Accounting - Offer available! is clickable for auditor which opens not here page[/-][+][Due for payment 2026-06-17] [Due for payment 2026-06-16] Accounting - Offer available! is clickable for auditor which opens not here page[/+]on Jun 10, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.1-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@Julesssss The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Jun 5, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/0633101c1d468bb9479977781326880ed01e347b1265124ec217005ce5fd68e1
melvin-bot commentedon Jun 5, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #92270
melvin-bot commentedon Jun 5, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jun 5, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Jun 5, 2026
Proposal
What is the root cause of that problem?
PR #92270 newly let auditors view the Accounting page (read access), but the "Offer available!" Xero badge still navigates everyone to an admin-only page.
The Xero badge's
onBadgePressalways navigates to the Claim Offer page — it is not gated bycanWriteAccounting, unlike the adjacent "Setup" button right below it, which callsshowReadOnlyModal()for read-only users:PolicyAccountingPage.tsx:362-367(badge, ungated) vs.:372-394(Setup button, gated).The Claim Offer page is gated ADMIN-only — it passes
accessVariants={[ADMIN]}but nopolicyFeatureprop:ClaimOfferPage.tsx:138-142. An auditor is not an admin, so the wrapper renders the "not here" Not Found page.Why the page loads for auditors but the badge target doesn't — mechanism
The new read-access mechanism in #92270 lives in
AccessOrNotFoundWrapper.tsx:190-201: when apolicyFeatureprop is supplied, theADMINvariant is filtered out and access is granted viacanMemberRead(...)instead.policyFeature={POLICY_FEATURE.ACCOUNTING}→PolicyAccountingPage.tsx:668-672→ auditor passes the read check → page is visible.policyFeatureand keepsaccessVariants={[ADMIN]}→ ADMIN check is not filtered out → auditor failscanEditWorkspaceSettings→ Not Found page.So the badge sends a read-only user to a route their role can't open — the bug is the ungated navigation, not the page guard itself (the Claim Offer / connect flow is intentionally a write action).
What changes do you think we should make in order to solve the problem?
Gate the badge press exactly like the adjacent "Setup" button: in
onBadgePressatPolicyAccountingPage.tsx:363-367, when!canWriteAccounting, callshowReadOnlyModal()and return instead of navigating to the Claim Offer route. This keeps read-only users on the "Not so fast" modal pattern already used everywhere else on this page.What alternative solutions did you explore? (Optional)
Hide the badge entirely for read-only users (set
badgeText/onBadgePresstoundefinedwhen!canWriteAccounting). This also fixes the crash-to-Not-Found, but it diverges from the page's established read-only pattern (show the control, route writes to the "Not so fast" modal), so gating the press is preferred.Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/92812)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
ShridharGoel commentedon Jun 5, 2026
Fixed in #92781
CC: @Pujan92
Julesssss commentedon Jun 8, 2026
@flodnv I have handled
m-natarajan commentedon Jun 8, 2026
Chrome / v9.4.0-4
Passed
REC-20260608231431.mp4
Julesssss commentedon Jun 8, 2026
Thank you!
[-]Accounting - Offer available! is clickable for auditor which opens not here page[/-][+][Due for payment 2026-06-16] Accounting - Offer available! is clickable for auditor which opens not here page[/+]melvin-bot commentedon Jun 9, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.0-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-06-16. 🎊
melvin-bot commentedon Jun 9, 2026
@Julesssss The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
[-][Due for payment 2026-06-16] Accounting - Offer available! is clickable for auditor which opens not here page[/-][+][Due for payment 2026-06-17] [Due for payment 2026-06-16] Accounting - Offer available! is clickable for auditor which opens not here page[/+]melvin-bot commentedon Jun 10, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.1-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-06-17. 🎊
melvin-bot commentedon Jun 10, 2026
@Julesssss The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]