You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-06-25] [$250] Expense - Create report from FAB opens workspace selector when Submit workspace is default WS #92862
Version Number: 9.4.0-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#92241 Email or phone of affected tester (no customers):applausetester+sdodjsosdids@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Workspace Settings
Action Performed:
Precondition:
Log in with Expensifail account.
Create two Submit workspaces on OD. One of the workspaces will be default workspace.
Go to staging.new.expensify.com
Open FAB > Create report.
Expected Result:
Workspace selector will not open because one of the Submit workspaces is the default workspace.
Actual Result:
Workspace selector opens when one of the Submit workspaces is the default workspace.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
Creating a report from the FAB opens the workspace selector when the default (active) workspace is a Submit workspace and the user has 2+ Submit workspaces. It should create the report directly in the default Submit workspace without prompting.
What is the root cause of that problem?
PR #92241 taught most of the "create report" path to treat Submit workspaces as valid report targets by switching from isPaidGroupPolicy (Team/Corporate only) to isGroupPolicy (Team/Corporate + Submit). But one spot in the branching hook was missed.
For a Submit active policy, isPaidGroupPolicy(activePolicy) returns false (Submit isn't Team/Corporate — see PolicyUtils.ts:1047), so isDefaultPersonal is incorrectly true. Since the policy selectors now include Submit workspaces, groupPoliciesWithChatEnabled.length > 1 is also true with two Submit workspaces, so the guard at useCreateReport.tsx:112 (isDefaultPersonal && hasMultipleNonPersonalWorkspaces) fires and routes to the workspace selector.
This also explains why the repro needs two Submit workspaces: with one, length > 1 is false and the report is created directly.
What changes do you think we should make in order to solve the problem?
In src/hooks/useCreateReport.tsx, replace isPaidGroupPolicy with isGroupPolicy on line 107 so Submit workspaces are recognized as a valid (non-personal) default, matching the rest of the flow that PR #92241 already migrated:
And update the import on line 6 from isPaidGroupPolicy to isGroupPolicy.
Why this is the right scope
getDefaultChatEnabledPolicy already returns the active Submit policy as the default (it uses isGroupPolicy post-#92241), so workspaceIDForReportCreation is correctly populated — the only thing dead-ending the flow into the selector is the stale isPaidGroupPolicy check on line 107. No other branch in the hook needs to change.
Confidence: High — code-evident, the mechanism explains the exact repro (only fails with 2+ Submit workspaces), and it's a new feature so there's no prod log dependency.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/92862) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
What's next step here? @Pujan92 due $250 for the review?
Yes
Was there a reason @abzokhattab wasn't assigned as C+ since they reviewed the PR that caused the regression. It's best practice cuz they have knowledge and we don't end up paying another C+.
Probably because the auto assigner assigned someone else
Activity
applause-bot commentedon Jun 6, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/337c738ed3fa72de50fcbebd67d7eb0c9843e700e6f3a3f0f81b861b96dcfde2
melvin-bot commentedon Jun 6, 2026
@Gonals recently merged #92241, but they are OOO right now, so I'll auto-assign someone else.
melvin-bot commentedon Jun 6, 2026
Triggered auto assignment to @rlinoz (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jun 6, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jun 6, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Jun 6, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
Creating a report from the FAB opens the workspace selector when the default (active) workspace is a Submit workspace and the user has 2+ Submit workspaces. It should create the report directly in the default Submit workspace without prompting.
What is the root cause of that problem?
PR #92241 taught most of the "create report" path to treat Submit workspaces as valid report targets by switching from
isPaidGroupPolicy(Team/Corporate only) toisGroupPolicy(Team/Corporate + Submit). But one spot in the branching hook was missed.In
useCreateReport.tsx:107:For a Submit active policy,
isPaidGroupPolicy(activePolicy)returnsfalse(Submit isn't Team/Corporate — seePolicyUtils.ts:1047), soisDefaultPersonalis incorrectlytrue. Since the policy selectors now include Submit workspaces,groupPoliciesWithChatEnabled.length > 1is alsotruewith two Submit workspaces, so the guard atuseCreateReport.tsx:112(isDefaultPersonal && hasMultipleNonPersonalWorkspaces) fires and routes to the workspace selector.This also explains why the repro needs two Submit workspaces: with one,
length > 1is false and the report is created directly.What changes do you think we should make in order to solve the problem?
In
src/hooks/useCreateReport.tsx, replaceisPaidGroupPolicywithisGroupPolicyon line 107 so Submit workspaces are recognized as a valid (non-personal) default, matching the rest of the flow that PR #92241 already migrated:And update the import on line 6 from
isPaidGroupPolicytoisGroupPolicy.Why this is the right scope
getDefaultChatEnabledPolicyalready returns the active Submit policy as the default (it usesisGroupPolicypost-#92241), soworkspaceIDForReportCreationis correctly populated — the only thing dead-ending the flow into the selector is the staleisPaidGroupPolicycheck on line 107. No other branch in the hook needs to change.Confidence: High — code-evident, the mechanism explains the exact repro (only fails with 2+ Submit workspaces), and it's a new feature so there's no prod log dependency.
Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/92862)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
iwiznia commentedon Jun 8, 2026
Not a blocker since this is in beta
33 remaining items
melvin-bot commentedon Jul 3, 2026
@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Jul 4, 2026
@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Pujan92 commentedon Jul 6, 2026
Bump @iwiznia for #92862 (comment)
mallenexpensify commentedon Jul 6, 2026
Payment Summary
Contributor+: @Pujan92 due $250 via NewDot
iwiznia commentedon Jul 7, 2026
Yes
Probably because the auto assigner assigned someone else
twisterdotcom commentedon Jul 8, 2026
$250 approved for @Pujan92 in Report ID: R00Xkf2P4liW.
Zapier Logs
Run ID: 00040eee-1d58-a157-ac7b-f8cb3033bcc4SO: https://stackoverflowteams.com/c/expensify/questions/7582