Skip to content

[Due for payment 2026-06-25] [$250] Expense - Create report from FAB opens workspace selector when Submit workspace is default WS #92862

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.4.0-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #92241
Email or phone of affected tester (no customers): applausetester+sdodjsosdids@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Log in with Expensifail account.
  • Create two Submit workspaces on OD. One of the workspaces will be default workspace.
  1. Go to staging.new.expensify.com
  2. Open FAB > Create report.

Expected Result:

Workspace selector will not open because one of the Submit workspaces is the default workspace.

Actual Result:

Workspace selector opens when one of the Submit workspaces is the default workspace.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7173614_1780762429662.21.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7173614

Upwork Automation - Do Not Edit
Issue OwnerCurrent Issue Owner: @iwiznia

Activity

  1. applause-bot commented on Jun 6, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/337c738ed3fa72de50fcbebd67d7eb0c9843e700e6f3a3f0f81b861b96dcfde2

  2. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 6, 2026
  3. melvin-bot commented on Jun 6, 2026

    @melvin-bot

    @Gonals recently merged #92241, but they are OOO right now, so I'll auto-assign someone else.

  4. melvin-bot commented on Jun 6, 2026

    @melvin-bot

    Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. melvin-bot commented on Jun 6, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. github-actions commented on Jun 6, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  7. MelvinBot commented on Jun 6, 2026

    @MelvinBot
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Creating a report from the FAB opens the workspace selector when the default (active) workspace is a Submit workspace and the user has 2+ Submit workspaces. It should create the report directly in the default Submit workspace without prompting.

    What is the root cause of that problem?

    PR #92241 taught most of the "create report" path to treat Submit workspaces as valid report targets by switching from isPaidGroupPolicy (Team/Corporate only) to isGroupPolicy (Team/Corporate + Submit). But one spot in the branching hook was missed.

    In useCreateReport.tsx:107:

    const isDefaultPersonal = !activePolicy || activePolicy.type === CONST.POLICY.TYPE.PERSONAL || !isPaidGroupPolicy(activePolicy);

    For a Submit active policy, isPaidGroupPolicy(activePolicy) returns false (Submit isn't Team/Corporate — see PolicyUtils.ts:1047), so isDefaultPersonal is incorrectly true. Since the policy selectors now include Submit workspaces, groupPoliciesWithChatEnabled.length > 1 is also true with two Submit workspaces, so the guard at useCreateReport.tsx:112 (isDefaultPersonal && hasMultipleNonPersonalWorkspaces) fires and routes to the workspace selector.

    This also explains why the repro needs two Submit workspaces: with one, length > 1 is false and the report is created directly.

    What changes do you think we should make in order to solve the problem?

    In src/hooks/useCreateReport.tsx, replace isPaidGroupPolicy with isGroupPolicy on line 107 so Submit workspaces are recognized as a valid (non-personal) default, matching the rest of the flow that PR #92241 already migrated:

    const isDefaultPersonal = !activePolicy || activePolicy.type === CONST.POLICY.TYPE.PERSONAL || !isGroupPolicy(activePolicy);

    And update the import on line 6 from isPaidGroupPolicy to isGroupPolicy.

    Why this is the right scope

    getDefaultChatEnabledPolicy already returns the active Submit policy as the default (it uses isGroupPolicy post-#92241), so workspaceIDForReportCreation is correctly populated — the only thing dead-ending the flow into the selector is the stale isPaidGroupPolicy check on line 107. No other branch in the hook needs to change.

    Confidence: High — code-evident, the mechanism explains the exact repro (only fails with 2+ Submit workspaces), and it's a new feature so there's no prod log dependency.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/92862) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.

  8. iwiznia commented on Jun 8, 2026

    @iwiznia
    Contributor

    Not a blocker since this is in beta

  9. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Jun 8, 2026
  10. 33 remaining items

  11. melvin-bot commented on Jul 3, 2026

    @melvin-bot

    @mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  12. melvin-bot commented on Jul 4, 2026

    @melvin-bot

    @mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  13. Pujan92 commented on Jul 6, 2026

    @Pujan92
    Contributor
  14. mallenexpensify commented on Jul 6, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @Pujan92 due $250 via NewDot

  15. iwiznia commented on Jul 7, 2026

    @iwiznia
    Contributor

    What's next step here? @Pujan92 due $250 for the review?

    Yes

    Was there a reason @abzokhattab wasn't assigned as C+ since they reviewed the PR that caused the regression. It's best practice cuz they have knowledge and we don't end up paying another C+.

    Probably because the auto assigner assigned someone else

  16. twisterdotcom commented on Jul 8, 2026

    @twisterdotcom
    Contributor

    $250 approved for @Pujan92 in Report ID: R00Xkf2P4liW.

    Zapier Logs Run ID: 00040eee-1d58-a157-ac7b-f8cb3033bcc4

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions