You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-07-23 ?] [$250] [Submit] Workspace - Upgrade page reopens after upgrading workspace and importing spreadsheet #92943
Version Number: 9.4.0-2 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#91258 Email or phone of affected tester (no customers):applausetester+sdodjso22ds@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Workspace Settings
Action Performed:
Precondition:
Log in with Expensifail account.
Create a Control workspace and invite a member as auditor.
Create a Submit workspace on OD.
Go to staging.new.expensify.com
Go to Control workspace settings > Members.
Click More > Download CSV.
Go to Submit workspace settings > Members.
Click More > Import spreadsheet.
Click Import > Upgrade > Got it, thanks.
Click Import again.
Expected Result:
Upgrade page will not appear because the workspace is upgraded before.
Actual Result:
Upgrade page reopens after upgrading workspace and importing spreadsheet.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
On a Submit workspace, importing a member spreadsheet that contains an Auditor role sends the admin to the Upgrade page. After upgrading and importing again, the Upgrade page reopens instead of completing the import, even though the workspace was already upgraded.
What is the root cause of that problem?
The auditor import gate requires a Control policy, but the new Submit-workspace upgrade flow (added in Expensify/App#91258) upgrades to Collect by default — so the gate never passes after upgrade.
Step by step:
The import gate redirects to the Upgrade page using the auditor feature whenever the CSV has an auditor role and the policy is not Control — ImportedMembersPage.tsx:103-106.
For a Submit workspace, the upgrade calls upgradeSubmit(policy, targetType, …) where targetType = feature.requiredPlan ?? CONST.POLICY.TYPE.TEAM — WorkspaceUpgradePage.tsx:175-178.
The auditor feature has no requiredPlan — CONST/index.ts:8013-8020 — unlike rules/perDiem/hr, which set requiredPlan: CORPORATE. So targetType falls back to TEAM (Collect).
upgradeSubmit then sets policy.type = targetType = team (Collect) — Policy.ts:5828.
On the next import, isControlPolicy(policy) is still false (Collect ≠ Corporate — PolicyUtils.ts:1127-1129), so the same gate re-fires and the Upgrade page reopens.
Before #91258, onUpgradeToCorporate always called upgradeToCorporate(...), which upgrades to Control — so importing auditors landed on a Control policy and the gate passed. The new Submit path routes through upgradeSubmit with a default of TEAM, and because the auditor feature lacks requiredPlan, the workspace lands on Collect, leaving the auditor gate permanently unsatisfied.
What changes do you think we should make in order to solve the problem?
Add a requiredPlan to the auditor feature so the Submit upgrade routes to Control, matching the auditor gate:
This is consistent with the other Control-only features and makes upgradeSubmit pass CORPORATE, so after upgrade isControlPolicy(policy) is true and re-importing proceeds without showing the Upgrade page again.
What alternative solutions did you explore? (Optional)
Alternatively, relax the import gate at ImportedMembersPage.tsx:103 to also accept upgraded Submit (Collect) policies — but that would change the product rule that auditors require Control, so the requiredPlan fix is preferred.
Next Steps for Contributor+ team: To accept:@MelvinBot implement this to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
changed the title [-][Due for payment 2026-07-16] [$250] [Submit] Workspace - Upgrade page reopens after upgrading workspace and importing spreadsheet[/-][+][Due for payment 2026-07-23 ?] [$250] [Submit] Workspace - Upgrade page reopens after upgrading workspace and importing spreadsheet[/+]on Jul 17, 2026
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: Could not locate the PR.
Link to the comment on the Issue:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
applause-bot commentedon Jun 8, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/9a4531d98b831d1e156bcd80d84eec9fb43ee0798010507ab6add4c62ac867cc
melvin-bot commentedon Jun 8, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #91258
melvin-bot commentedon Jun 8, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jun 8, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Jun 8, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
On a Submit workspace, importing a member spreadsheet that contains an
Auditorrole sends the admin to the Upgrade page. After upgrading and importing again, the Upgrade page reopens instead of completing the import, even though the workspace was already upgraded.What is the root cause of that problem?
The auditor import gate requires a Control policy, but the new Submit-workspace upgrade flow (added in
Expensify/App#91258) upgrades to Collect by default — so the gate never passes after upgrade.Step by step:
auditorfeature whenever the CSV has an auditor role and the policy is not Control —ImportedMembersPage.tsx:103-106.upgradeSubmit(policy, targetType, …)wheretargetType = feature.requiredPlan ?? CONST.POLICY.TYPE.TEAM—WorkspaceUpgradePage.tsx:175-178.auditorfeature has norequiredPlan—CONST/index.ts:8013-8020— unlikerules/perDiem/hr, which setrequiredPlan: CORPORATE. SotargetTypefalls back toTEAM(Collect).upgradeSubmitthen setspolicy.type = targetType=team(Collect) —Policy.ts:5828.isControlPolicy(policy)is stillfalse(Collect ≠ Corporate —PolicyUtils.ts:1127-1129), so the same gate re-fires and the Upgrade page reopens.Why this is a regression from #91258
Before #91258,
onUpgradeToCorporatealways calledupgradeToCorporate(...), which upgrades to Control — so importing auditors landed on a Control policy and the gate passed. The new Submit path routes throughupgradeSubmitwith a default ofTEAM, and because theauditorfeature lacksrequiredPlan, the workspace lands on Collect, leaving the auditor gate permanently unsatisfied.What changes do you think we should make in order to solve the problem?
Add a
requiredPlanto theauditorfeature so the Submit upgrade routes to Control, matching the auditor gate:This is consistent with the other Control-only features and makes
upgradeSubmitpassCORPORATE, so after upgradeisControlPolicy(policy)istrueand re-importing proceeds without showing the Upgrade page again.What alternative solutions did you explore? (Optional)
Alternatively, relax the import gate at
ImportedMembersPage.tsx:103to also accept upgraded Submit (Collect) policies — but that would change the product rule that auditors require Control, so therequiredPlanfix is preferred.Next Steps for Contributor+ team:
To accept:
@MelvinBot implement thisto create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
iwiznia commentedon Jun 8, 2026
Not a blocker since it's under beta
45 remaining items
melvin-bot commentedon Jul 16, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Jul 16, 2026
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
[-][Due for payment 2026-07-16] [$250] [Submit] Workspace - Upgrade page reopens after upgrading workspace and importing spreadsheet[/-][+][Due for payment 2026-07-23 ?] [$250] [Submit] Workspace - Upgrade page reopens after upgrading workspace and importing spreadsheet[/+]sobitneupane commentedon Jul 23, 2026
BugZero Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: Could not locate the PR.
Link to the comment on the Issue:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/664865
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
Zapier Logs
Run ID: 00040eee-9850-a088-a5bc-22eca6e4f264mallenexpensify commentedon Jul 27, 2026
Payment Summary
Contributor+: @sobitneupane due $250 via NewDot
^ Test case created. Thx
Think we're good to close, comment or reopen if you disagree.
JmillsExpensify commentedon Jul 28, 2026
$250 approved for @sobitneupane