You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-06-19] [Due for payment 2026-06-18] Spend - Unable to pay report on Spend #93230
Version Number: 9.4.5-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#92297 Email or phone of affected tester (no customers):jsodinjosdjsoinjsiojs@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Money Requests
Action Performed:
Go to staging.new.expensify.com
Go to workspace chat.
Create an expense.
Click Submit and Approve.
Go to Spend > Reports.
Click Pay button.
Click Mark as paid.
Expected Result:
Report will be paid.
Actual Result:
Nothing happens after marking report as paid on Spend > Reports.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Regression from#92297 (Deprecate PayMoneyRequestOnSearch in favor of individual pay commands per report). This matches the symptom: reproducible in staging, not production, and only single-report pay from Spend > Reports is broken.
In the Search/Spend view, report data is served from the search snapshot, and the parent workspace chat (policyExpenseChat) is frequently absent from the live COLLECTION.REPORT. When that happens chatReport is undefined, the guard returns early, no PayMoneyRequest command fires, and nothing happens — silently.
Production is unaffected because it still uses the old bulk payMoneyRequestOnSearch command, which never required a resolved chatReport.
Why the bulk/other paths still work but this one doesn't
The bulk-pay path and handleActionButtonPress → getPayActionCallback resolve the chat report with a snapshot fallback via getChatReportForSearchPay / getReportFromSearchSnapshot (snapshot → live Onyx → getReportOrDraftReport). PayActionCell has no equivalent fallback — it depends solely on the live useOnyx(REPORT_<chatReportID>), so it short-circuits when the chat report isn't in live Onyx.
What changes do you think we should make in order to solve the problem?
Make PayActionCell resolve chatReport with the same snapshot-aware fallback the other pay paths already use, instead of relying solely on live Onyx. Concretely, in PayActionCell.tsx, source chatReport as liveChatReport ?? snapshotChatReport (read the snapshot for ${ONYXKEYS.COLLECTION.REPORT}${iouReport?.chatReportID} from the search results context), mirroring getChatReportForSearchPay. The cleanest approach is to extract a small shared helper/hook so both the per-row and bulk paths stay in sync.
Do not simply drop the !chatReport guard — payMoneyRequest/payInvoice use chatReport.policyID and build optimistic data from it, so passing undefined would break the payment rather than fix it.
What alternative solutions did you explore? (Optional)
Given this is a deploy blocker, reverting #92297 is the fastest safe option if a forward fix can't be verified quickly.
Evidence / investigation details
iouReport comes from useReportWithTransactionsAndViolations (live Onyx). In the repro the IOU report was just created so it's present and iouReport.chatReportID resolves — but the parent chat report often isn't in live Onyx, which is the trigger.
Optional production confirmation: check whether a PayMoneyRequest/PayInvoice command is emitted when "Mark as paid" is clicked from Spend > Reports for an affected user. Absence confirms the early return.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/93230) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.5-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@luacmartins The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
changed the title [-][Due for payment 2026-06-18] Spend - Unable to pay report on Spend[/-][+][Due for payment 2026-06-19] [Due for payment 2026-06-18] Spend - Unable to pay report on Spend[/+]on Jun 12, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.6-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@luacmartins The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Jun 11, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/dd07743265b18eff3d00b49e57a73d386894ca964c147e4fb5bb7aeb0170b98e
melvin-bot commentedon Jun 11, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #92297
melvin-bot commentedon Jun 11, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jun 11, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Jun 11, 2026
Proposal
Regression from #92297 (
Deprecate PayMoneyRequestOnSearch in favor of individual pay commands per report). This matches the symptom: reproducible in staging, not production, and only single-report pay from Spend > Reports is broken.What is the root cause of that problem?
Paying a single report from the Spend > Reports row goes through
PayActionCell.confirmPayment(thePAYaction routes toPayActionCell, seeActionCell/index.tsx:68-80).PR #92297 added a new
|| !chatReportcondition to the early-return guard:chatReportis read only from live Onyx atPayActionCell.tsx:40:In the Search/Spend view, report data is served from the search snapshot, and the parent workspace chat (
policyExpenseChat) is frequently absent from the liveCOLLECTION.REPORT. When that happenschatReportisundefined, the guard returns early, noPayMoneyRequestcommand fires, and nothing happens — silently.Production is unaffected because it still uses the old bulk
payMoneyRequestOnSearchcommand, which never required a resolvedchatReport.Why the bulk/other paths still work but this one doesn't
The bulk-pay path and
handleActionButtonPress→getPayActionCallbackresolve the chat report with a snapshot fallback viagetChatReportForSearchPay/getReportFromSearchSnapshot(snapshot → live Onyx →getReportOrDraftReport).PayActionCellhas no equivalent fallback — it depends solely on the liveuseOnyx(REPORT_<chatReportID>), so it short-circuits when the chat report isn't in live Onyx.What changes do you think we should make in order to solve the problem?
Make
PayActionCellresolvechatReportwith the same snapshot-aware fallback the other pay paths already use, instead of relying solely on live Onyx. Concretely, inPayActionCell.tsx, sourcechatReportasliveChatReport ?? snapshotChatReport(read the snapshot for${ONYXKEYS.COLLECTION.REPORT}${iouReport?.chatReportID}from the search results context), mirroringgetChatReportForSearchPay. The cleanest approach is to extract a small shared helper/hook so both the per-row and bulk paths stay in sync.Do not simply drop the
!chatReportguard —payMoneyRequest/payInvoiceusechatReport.policyIDand build optimistic data from it, so passingundefinedwould break the payment rather than fix it.What alternative solutions did you explore? (Optional)
Given this is a deploy blocker, reverting #92297 is the fastest safe option if a forward fix can't be verified quickly.
Evidence / investigation details
iouReportcomes fromuseReportWithTransactionsAndViolations(live Onyx). In the repro the IOU report was just created so it's present andiouReport.chatReportIDresolves — but the parent chat report often isn't in live Onyx, which is the trigger.|| !chatReportguard and the per-reportpayMoneyRequest/payInvoicecalls are both introduced by [Payment due @daledah] Deprecate PayMoneyRequestOnSearch in favor of individual pay commands per report #92297.PayMoneyRequest/PayInvoicecommand is emitted when "Mark as paid" is clicked from Spend > Reports for an affected user. Absence confirms the early return.Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/93230)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
IuliiaHerets commentedon Jun 11, 2026
Chrome / v9.4.5-2
Passed
REC-20260611223920.mp4
luacmartins commentedon Jun 11, 2026
Fixed. Closing.
[-]Spend - Unable to pay report on Spend[/-][+][Due for payment 2026-06-18] Spend - Unable to pay report on Spend[/+]melvin-bot commentedon Jun 11, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 11, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.5-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-06-18. 🎊
melvin-bot commentedon Jun 11, 2026
@luacmartins The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
[-][Due for payment 2026-06-18] Spend - Unable to pay report on Spend[/-][+][Due for payment 2026-06-19] [Due for payment 2026-06-18] Spend - Unable to pay report on Spend[/+]melvin-bot commentedon Jun 12, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.6-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-06-19. 🎊
melvin-bot commentedon Jun 12, 2026
@luacmartins The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]