Skip to content

[Due for payment 2026-06-19] [Due for payment 2026-06-18] Spend - Unable to pay report on Spend #93230

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.4.5-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #92297
Email or phone of affected tester (no customers): jsodinjosdjsoinjsiojs@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create an expense.
  4. Click Submit and Approve.
  5. Go to Spend > Reports.
  6. Click Pay button.
  7. Click Mark as paid.

Expected Result:

Report will be paid.

Actual Result:

Nothing happens after marking report as paid on Spend > Reports.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7177425_1781135481211.1.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7177425

Activity

  1. applause-bot commented on Jun 11, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/dd07743265b18eff3d00b49e57a73d386894ca964c147e4fb5bb7aeb0170b98e

  2. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 11, 2026
  3. melvin-bot commented on Jun 11, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #92297

  4. melvin-bot commented on Jun 11, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jun 11, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on Jun 11, 2026

    @MelvinBot
    Contributor

    Proposal

    Regression from #92297 (Deprecate PayMoneyRequestOnSearch in favor of individual pay commands per report). This matches the symptom: reproducible in staging, not production, and only single-report pay from Spend > Reports is broken.

    What is the root cause of that problem?

    Paying a single report from the Spend > Reports row goes through PayActionCell.confirmPayment (the PAY action routes to PayActionCell, see ActionCell/index.tsx:68-80).

    PR #92297 added a new || !chatReport condition to the early-return guard:

    if (!type || !reportID || !hash || !amount || !chatReport) { return; }
    

    chatReport is read only from live Onyx at PayActionCell.tsx:40:

    const [chatReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${iouReport?.chatReportID}`);
    

    In the Search/Spend view, report data is served from the search snapshot, and the parent workspace chat (policyExpenseChat) is frequently absent from the live COLLECTION.REPORT. When that happens chatReport is undefined, the guard returns early, no PayMoneyRequest command fires, and nothing happens — silently.

    Production is unaffected because it still uses the old bulk payMoneyRequestOnSearch command, which never required a resolved chatReport.

    Why the bulk/other paths still work but this one doesn't

    The bulk-pay path and handleActionButtonPress → getPayActionCallback resolve the chat report with a snapshot fallback via getChatReportForSearchPay / getReportFromSearchSnapshot (snapshot → live Onyx → getReportOrDraftReport). PayActionCell has no equivalent fallback — it depends solely on the live useOnyx(REPORT_<chatReportID>), so it short-circuits when the chat report isn't in live Onyx.

    What changes do you think we should make in order to solve the problem?

    Make PayActionCell resolve chatReport with the same snapshot-aware fallback the other pay paths already use, instead of relying solely on live Onyx. Concretely, in PayActionCell.tsx, source chatReport as liveChatReport ?? snapshotChatReport (read the snapshot for ${ONYXKEYS.COLLECTION.REPORT}${iouReport?.chatReportID} from the search results context), mirroring getChatReportForSearchPay. The cleanest approach is to extract a small shared helper/hook so both the per-row and bulk paths stay in sync.

    Do not simply drop the !chatReport guard — payMoneyRequest/payInvoice use chatReport.policyID and build optimistic data from it, so passing undefined would break the payment rather than fix it.

    What alternative solutions did you explore? (Optional)

    Given this is a deploy blocker, reverting #92297 is the fastest safe option if a forward fix can't be verified quickly.

    Evidence / investigation details

    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/93230) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.

  7. IuliiaHerets commented on Jun 11, 2026

    @IuliiaHerets

    Chrome / v9.4.5-2
    Passed

    REC-20260611223920.mp4
  8. luacmartins commented on Jun 11, 2026

    @luacmartins
    Contributor

    Fixed. Closing.

  9. changed the title [-]Spend - Unable to pay report on Spend[/-] [+][Due for payment 2026-06-18] Spend - Unable to pay report on Spend[/+] on Jun 11, 2026
  10. melvin-bot commented on Jun 11, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Jun 11, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.5-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-06-18. 🎊

  12. melvin-bot commented on Jun 11, 2026

    @melvin-bot

    @luacmartins The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  13. changed the title [-][Due for payment 2026-06-18] Spend - Unable to pay report on Spend[/-] [+][Due for payment 2026-06-19] [Due for payment 2026-06-18] Spend - Unable to pay report on Spend[/+] on Jun 12, 2026
  14. melvin-bot commented on Jun 12, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.6-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-06-19. 🎊

  15. melvin-bot commented on Jun 12, 2026

    @melvin-bot

    @luacmartins The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions